Title: [209593] trunk/Source/WebCore
- Revision
- 209593
- Author
- [email protected]
- Date
- 2016-12-08 19:10:02 -0800 (Thu, 08 Dec 2016)
Log Message
FileHandle::printf doesn't build on Windows
https://bugs.webkit.org/show_bug.cgi?id=165642
Reviewed by Ryosuke Niwa.
Fix the build -- vasprintf does not exist on Windows, so make
FileHandle::printf a no-op on that platform.
No new tests -- affected facility is currently only used in testing
code and is not user reachable.
* platform/FileHandle.cpp:
(WebCore::FileHandle::printf):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (209592 => 209593)
--- trunk/Source/WebCore/ChangeLog 2016-12-09 02:37:45 UTC (rev 209592)
+++ trunk/Source/WebCore/ChangeLog 2016-12-09 03:10:02 UTC (rev 209593)
@@ -1,3 +1,19 @@
+2016-12-08 Keith Rollin <[email protected]>
+
+ FileHandle::printf doesn't build on Windows
+ https://bugs.webkit.org/show_bug.cgi?id=165642
+
+ Reviewed by Ryosuke Niwa.
+
+ Fix the build -- vasprintf does not exist on Windows, so make
+ FileHandle::printf a no-op on that platform.
+
+ No new tests -- affected facility is currently only used in testing
+ code and is not user reachable.
+
+ * platform/FileHandle.cpp:
+ (WebCore::FileHandle::printf):
+
2016-12-08 Antoine Quint <[email protected]>
[Modern Media Controls] Exiting fullscreen with paused media shows the start button
Modified: trunk/Source/WebCore/platform/FileHandle.cpp (209592 => 209593)
--- trunk/Source/WebCore/platform/FileHandle.cpp 2016-12-09 02:37:45 UTC (rev 209592)
+++ trunk/Source/WebCore/platform/FileHandle.cpp 2016-12-09 03:10:02 UTC (rev 209593)
@@ -100,6 +100,10 @@
bool FileHandle::printf(const char* format, ...)
{
+#if OS(WINDOWS)
+ // TODO: implement this without relying on vasprintf.
+ return false;
+#else
va_list args;
va_start(args, format);
@@ -112,6 +116,7 @@
va_end(args);
return writeResult >= 0;
+#endif
}
void FileHandle::close()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
