Diff
Modified: trunk/LayoutTests/ChangeLog (209597 => 209598)
--- trunk/LayoutTests/ChangeLog 2016-12-09 06:52:51 UTC (rev 209597)
+++ trunk/LayoutTests/ChangeLog 2016-12-09 07:45:56 UTC (rev 209598)
@@ -1,3 +1,15 @@
+2016-12-08 Jiewen Tan <[email protected]>
+
+ [WebCrypto] Remove NoInterfaceObject attribute from SubtleCrypto Interface
+ https://bugs.webkit.org/show_bug.cgi?id=165629
+ <rdar://problem/29586203>
+
+ Reviewed by Chris Dumez.
+
+ * js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
+ * platform/mac/js/dom/global-constructors-attributes-expected.txt:
+ * platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
+
2016-12-08 Antoine Quint <[email protected]>
[Modern Media Controls] Exiting fullscreen with paused media shows the start button
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (209597 => 209598)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-12-09 06:52:51 UTC (rev 209597)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-12-09 07:45:56 UTC (rev 209598)
@@ -1,3 +1,13 @@
+2016-12-08 Jiewen Tan <[email protected]>
+
+ [WebCrypto] Remove NoInterfaceObject attribute from SubtleCrypto Interface
+ https://bugs.webkit.org/show_bug.cgi?id=165629
+ <rdar://problem/29586203>
+
+ Reviewed by Chris Dumez.
+
+ * WebCryptoAPI/idlharness-expected.txt:
+
2016-12-08 Chris Dumez <[email protected]>
Support running the layout tests offline
Modified: trunk/LayoutTests/imported/w3c/WebCryptoAPI/idlharness-expected.txt (209597 => 209598)
--- trunk/LayoutTests/imported/w3c/WebCryptoAPI/idlharness-expected.txt 2016-12-09 06:52:51 UTC (rev 209597)
+++ trunk/LayoutTests/imported/w3c/WebCryptoAPI/idlharness-expected.txt 2016-12-09 07:45:56 UTC (rev 209598)
@@ -24,24 +24,24 @@
PASS CryptoKey interface: attribute extractable
PASS CryptoKey interface: attribute algorithm
PASS CryptoKey interface: attribute usages
-FAIL SubtleCrypto interface: existence and properties of interface object assert_own_property: self does not have own property "SubtleCrypto" expected property "SubtleCrypto" missing
-FAIL SubtleCrypto interface object length assert_own_property: self does not have own property "SubtleCrypto" expected property "SubtleCrypto" missing
-FAIL SubtleCrypto interface object name assert_own_property: self does not have own property "SubtleCrypto" expected property "SubtleCrypto" missing
-FAIL SubtleCrypto interface: existence and properties of interface prototype object assert_own_property: self does not have own property "SubtleCrypto" expected property "SubtleCrypto" missing
-FAIL SubtleCrypto interface: existence and properties of interface prototype object's "constructor" property assert_own_property: self does not have own property "SubtleCrypto" expected property "SubtleCrypto" missing
-FAIL SubtleCrypto interface: operation encrypt(AlgorithmIdentifier,CryptoKey,BufferSource) assert_own_property: self does not have own property "SubtleCrypto" expected property "SubtleCrypto" missing
-FAIL SubtleCrypto interface: operation decrypt(AlgorithmIdentifier,CryptoKey,BufferSource) assert_own_property: self does not have own property "SubtleCrypto" expected property "SubtleCrypto" missing
-FAIL SubtleCrypto interface: operation sign(AlgorithmIdentifier,CryptoKey,BufferSource) assert_own_property: self does not have own property "SubtleCrypto" expected property "SubtleCrypto" missing
-FAIL SubtleCrypto interface: operation verify(AlgorithmIdentifier,CryptoKey,BufferSource,BufferSource) assert_own_property: self does not have own property "SubtleCrypto" expected property "SubtleCrypto" missing
-FAIL SubtleCrypto interface: operation digest(AlgorithmIdentifier,BufferSource) assert_own_property: self does not have own property "SubtleCrypto" expected property "SubtleCrypto" missing
-FAIL SubtleCrypto interface: operation generateKey(AlgorithmIdentifier,boolean,[object Object]) assert_own_property: self does not have own property "SubtleCrypto" expected property "SubtleCrypto" missing
-FAIL SubtleCrypto interface: operation deriveKey(AlgorithmIdentifier,CryptoKey,AlgorithmIdentifier,boolean,[object Object]) assert_own_property: self does not have own property "SubtleCrypto" expected property "SubtleCrypto" missing
-FAIL SubtleCrypto interface: operation deriveBits(AlgorithmIdentifier,CryptoKey,unsigned long) assert_own_property: self does not have own property "SubtleCrypto" expected property "SubtleCrypto" missing
-FAIL SubtleCrypto interface: operation importKey(KeyFormat,[object Object],[object Object],AlgorithmIdentifier,boolean,[object Object]) assert_own_property: self does not have own property "SubtleCrypto" expected property "SubtleCrypto" missing
-FAIL SubtleCrypto interface: operation exportKey(KeyFormat,CryptoKey) assert_own_property: self does not have own property "SubtleCrypto" expected property "SubtleCrypto" missing
-FAIL SubtleCrypto interface: operation wrapKey(KeyFormat,CryptoKey,CryptoKey,AlgorithmIdentifier) assert_own_property: self does not have own property "SubtleCrypto" expected property "SubtleCrypto" missing
-FAIL SubtleCrypto interface: operation unwrapKey(KeyFormat,BufferSource,CryptoKey,AlgorithmIdentifier,AlgorithmIdentifier,boolean,[object Object]) assert_own_property: self does not have own property "SubtleCrypto" expected property "SubtleCrypto" missing
-FAIL SubtleCrypto must be primary interface of crypto.subtle assert_own_property: self does not have own property "SubtleCrypto" expected property "SubtleCrypto" missing
+PASS SubtleCrypto interface: existence and properties of interface object
+PASS SubtleCrypto interface object length
+PASS SubtleCrypto interface object name
+PASS SubtleCrypto interface: existence and properties of interface prototype object
+PASS SubtleCrypto interface: existence and properties of interface prototype object's "constructor" property
+PASS SubtleCrypto interface: operation encrypt(AlgorithmIdentifier,CryptoKey,BufferSource)
+PASS SubtleCrypto interface: operation decrypt(AlgorithmIdentifier,CryptoKey,BufferSource)
+PASS SubtleCrypto interface: operation sign(AlgorithmIdentifier,CryptoKey,BufferSource)
+PASS SubtleCrypto interface: operation verify(AlgorithmIdentifier,CryptoKey,BufferSource,BufferSource)
+PASS SubtleCrypto interface: operation digest(AlgorithmIdentifier,BufferSource)
+PASS SubtleCrypto interface: operation generateKey(AlgorithmIdentifier,boolean,[object Object])
+PASS SubtleCrypto interface: operation deriveKey(AlgorithmIdentifier,CryptoKey,AlgorithmIdentifier,boolean,[object Object])
+PASS SubtleCrypto interface: operation deriveBits(AlgorithmIdentifier,CryptoKey,unsigned long)
+PASS SubtleCrypto interface: operation importKey(KeyFormat,[object Object],[object Object],AlgorithmIdentifier,boolean,[object Object])
+PASS SubtleCrypto interface: operation exportKey(KeyFormat,CryptoKey)
+PASS SubtleCrypto interface: operation wrapKey(KeyFormat,CryptoKey,CryptoKey,AlgorithmIdentifier)
+PASS SubtleCrypto interface: operation unwrapKey(KeyFormat,BufferSource,CryptoKey,AlgorithmIdentifier,AlgorithmIdentifier,boolean,[object Object])
+PASS SubtleCrypto must be primary interface of crypto.subtle
PASS Stringification of crypto.subtle
PASS SubtleCrypto interface: crypto.subtle must inherit property "encrypt" with the proper type (0)
PASS SubtleCrypto interface: calling encrypt(AlgorithmIdentifier,CryptoKey,BufferSource) on crypto.subtle with too few arguments must throw TypeError
Modified: trunk/LayoutTests/js/dom/global-constructors-attributes-dedicated-worker-expected.txt (209597 => 209598)
--- trunk/LayoutTests/js/dom/global-constructors-attributes-dedicated-worker-expected.txt 2016-12-09 06:52:51 UTC (rev 209597)
+++ trunk/LayoutTests/js/dom/global-constructors-attributes-dedicated-worker-expected.txt 2016-12-09 07:45:56 UTC (rev 209598)
@@ -249,6 +249,11 @@
PASS [Worker] Object.getOwnPropertyDescriptor(global, 'String').hasOwnProperty('set') is false
PASS [Worker] Object.getOwnPropertyDescriptor(global, 'String').enumerable is false
PASS [Worker] Object.getOwnPropertyDescriptor(global, 'String').configurable is true
+PASS [Worker] Object.getOwnPropertyDescriptor(global, 'SubtleCrypto').value is SubtleCrypto
+PASS [Worker] Object.getOwnPropertyDescriptor(global, 'SubtleCrypto').hasOwnProperty('get') is false
+PASS [Worker] Object.getOwnPropertyDescriptor(global, 'SubtleCrypto').hasOwnProperty('set') is false
+PASS [Worker] Object.getOwnPropertyDescriptor(global, 'SubtleCrypto').enumerable is false
+PASS [Worker] Object.getOwnPropertyDescriptor(global, 'SubtleCrypto').configurable is true
PASS [Worker] Object.getOwnPropertyDescriptor(global, 'Symbol').value is Symbol
PASS [Worker] Object.getOwnPropertyDescriptor(global, 'Symbol').hasOwnProperty('get') is false
PASS [Worker] Object.getOwnPropertyDescriptor(global, 'Symbol').hasOwnProperty('set') is false
Modified: trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt (209597 => 209598)
--- trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt 2016-12-09 06:52:51 UTC (rev 209597)
+++ trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt 2016-12-09 07:45:56 UTC (rev 209598)
@@ -2113,6 +2113,11 @@
PASS Object.getOwnPropertyDescriptor(global, 'StyleSheetList').hasOwnProperty('set') is false
PASS Object.getOwnPropertyDescriptor(global, 'StyleSheetList').enumerable is false
PASS Object.getOwnPropertyDescriptor(global, 'StyleSheetList').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'SubtleCrypto').value is SubtleCrypto
+PASS Object.getOwnPropertyDescriptor(global, 'SubtleCrypto').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SubtleCrypto').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SubtleCrypto').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'SubtleCrypto').configurable is true
PASS Object.getOwnPropertyDescriptor(global, 'Symbol').value is Symbol
PASS Object.getOwnPropertyDescriptor(global, 'Symbol').hasOwnProperty('get') is false
PASS Object.getOwnPropertyDescriptor(global, 'Symbol').hasOwnProperty('set') is false
Modified: trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt (209597 => 209598)
--- trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt 2016-12-09 06:52:51 UTC (rev 209597)
+++ trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt 2016-12-09 07:45:56 UTC (rev 209598)
@@ -2113,6 +2113,11 @@
PASS Object.getOwnPropertyDescriptor(global, 'StyleSheetList').hasOwnProperty('set') is false
PASS Object.getOwnPropertyDescriptor(global, 'StyleSheetList').enumerable is false
PASS Object.getOwnPropertyDescriptor(global, 'StyleSheetList').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'SubtleCrypto').value is SubtleCrypto
+PASS Object.getOwnPropertyDescriptor(global, 'SubtleCrypto').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SubtleCrypto').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'SubtleCrypto').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'SubtleCrypto').configurable is true
PASS Object.getOwnPropertyDescriptor(global, 'Symbol').value is Symbol
PASS Object.getOwnPropertyDescriptor(global, 'Symbol').hasOwnProperty('get') is false
PASS Object.getOwnPropertyDescriptor(global, 'Symbol').hasOwnProperty('set') is false
Modified: trunk/Source/WebCore/ChangeLog (209597 => 209598)
--- trunk/Source/WebCore/ChangeLog 2016-12-09 06:52:51 UTC (rev 209597)
+++ trunk/Source/WebCore/ChangeLog 2016-12-09 07:45:56 UTC (rev 209598)
@@ -1,3 +1,15 @@
+2016-12-08 Jiewen Tan <[email protected]>
+
+ [WebCrypto] Remove NoInterfaceObject attribute from SubtleCrypto Interface
+ https://bugs.webkit.org/show_bug.cgi?id=165629
+ <rdar://problem/29586203>
+
+ Reviewed by Chris Dumez.
+
+ Covered by existing tests.
+
+ * crypto/SubtleCrypto.idl:
+
2016-12-08 Keith Rollin <[email protected]>
FileHandle::printf doesn't build on Windows
Modified: trunk/Source/WebCore/crypto/SubtleCrypto.idl (209597 => 209598)
--- trunk/Source/WebCore/crypto/SubtleCrypto.idl 2016-12-09 06:52:51 UTC (rev 209597)
+++ trunk/Source/WebCore/crypto/SubtleCrypto.idl 2016-12-09 07:45:56 UTC (rev 209598)
@@ -29,7 +29,6 @@
Conditional=SUBTLE_CRYPTO,
Exposed=(Window,Worker),
GenerateIsReachable=ImplScriptExecutionContext,
- NoInterfaceObject,
] interface SubtleCrypto {
[Custom] Promise<any> encrypt(AlgorithmIdentifier algorithm, CryptoKey key, BufferSource data);
[Custom] Promise<any> decrypt(AlgorithmIdentifier algorithm, CryptoKey key, BufferSource data);
