Title: [209641] trunk/Source/WebCore
Revision
209641
Author
[email protected]
Date
2016-12-09 18:03:45 -0800 (Fri, 09 Dec 2016)

Log Message

Remove QuickLook scheme from the list of secure schemes
https://bugs.webkit.org/show_bug.cgi?id=165699

Reviewed by Andy Estes.

Following r207155 we use a unique origin for QuickLook documents. Unique origins are not
subject to mixed content restrictions. Prior to r207155 QuickLook documents used the
origin from which they were served. We added the QuickLook scheme to the list of secure
schemes as a workaround to avoid mixed content errors when loading subresources in a
QuickLook document served over HTTPS. Now that we use a unique origin for QuickLook
documents we no longer need this workaround.

* platform/SchemeRegistry.cpp:
(WebCore::secureSchemes):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (209640 => 209641)


--- trunk/Source/WebCore/ChangeLog	2016-12-10 01:25:53 UTC (rev 209640)
+++ trunk/Source/WebCore/ChangeLog	2016-12-10 02:03:45 UTC (rev 209641)
@@ -1,3 +1,20 @@
+2016-12-09  Daniel Bates  <[email protected]>
+
+        Remove QuickLook scheme from the list of secure schemes
+        https://bugs.webkit.org/show_bug.cgi?id=165699
+
+        Reviewed by Andy Estes.
+
+        Following r207155 we use a unique origin for QuickLook documents. Unique origins are not
+        subject to mixed content restrictions. Prior to r207155 QuickLook documents used the
+        origin from which they were served. We added the QuickLook scheme to the list of secure
+        schemes as a workaround to avoid mixed content errors when loading subresources in a
+        QuickLook document served over HTTPS. Now that we use a unique origin for QuickLook
+        documents we no longer need this workaround.
+
+        * platform/SchemeRegistry.cpp:
+        (WebCore::secureSchemes):
+
 2016-12-09  Brady Eidson  <[email protected]>
 
         Re-landing:

Modified: trunk/Source/WebCore/platform/SchemeRegistry.cpp (209640 => 209641)


--- trunk/Source/WebCore/platform/SchemeRegistry.cpp	2016-12-10 01:25:53 UTC (rev 209640)
+++ trunk/Source/WebCore/platform/SchemeRegistry.cpp	2016-12-10 02:03:45 UTC (rev 209641)
@@ -28,10 +28,6 @@
 #include <wtf/MainThread.h>
 #include <wtf/NeverDestroyed.h>
 
-#if USE(QUICK_LOOK)
-#include "QuickLook.h"
-#endif
-
 namespace WebCore {
 
 static URLSchemesMap& localURLSchemes()
@@ -63,9 +59,6 @@
         secureSchemes.get().add("about");
         secureSchemes.get().add("data");
         secureSchemes.get().add("wss");
-#if USE(QUICK_LOOK)
-        secureSchemes.get().add(QLPreviewProtocol());
-#endif
 #if PLATFORM(GTK)
         secureSchemes.get().add("resource");
 #endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to