Title: [209709] trunk/Source/WebInspectorUI
- Revision
- 209709
- Author
- [email protected]
- Date
- 2016-12-12 09:20:37 -0800 (Mon, 12 Dec 2016)
Log Message
Web Inspector: Allow keyboard navigation in Heap Snapshot data grids
https://bugs.webkit.org/show_bug.cgi?id=165752
Reviewed by Brian Burg.
* UserInterface/Views/DOMTreeOutline.css:
(.tree-outline.dom:focus li.selected > span::after):
Use new color variable.
* UserInterface/Views/HeapSnapshotInstanceDataGridNode.js:
(WebInspector.HeapSnapshotInstanceDataGridNode.prototype.get selectable): Deleted.
Should be selectable.
* UserInterface/Views/HeapSnapshotInstancesContentView.css:
(.heap-snapshot > .data-grid:focus tr.selected > td .sub-retained):
(.heap-snapshot > .data-grid:focus tr.selected .object-id,):
(.heap-snapshot > .data-grid:focus tr.selected .formatted-string,):
(.heap-snapshot > .data-grid:focus tr.selected td .location):
Selected row text should just be white, except for values that are usually
gray (object ID, object size, and sub-retained size values). These should
be styled like the "= $0" marker in the DOM tree outline.
(.heap-snapshot > .data-grid:matches(:focus, .force-focus) tr.selected td .location): Deleted.
Removed forced-focus reference. Only used by TreeOutlineDataGridSynchronizer.
* UserInterface/Views/Variables.css:
(:root):
Added --selected-secondary-text-color.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (209708 => 209709)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-12-12 17:10:30 UTC (rev 209708)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-12-12 17:20:37 UTC (rev 209709)
@@ -1,5 +1,36 @@
2016-12-12 Matt Baker <[email protected]>
+ Web Inspector: Allow keyboard navigation in Heap Snapshot data grids
+ https://bugs.webkit.org/show_bug.cgi?id=165752
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/DOMTreeOutline.css:
+ (.tree-outline.dom:focus li.selected > span::after):
+ Use new color variable.
+
+ * UserInterface/Views/HeapSnapshotInstanceDataGridNode.js:
+ (WebInspector.HeapSnapshotInstanceDataGridNode.prototype.get selectable): Deleted.
+ Should be selectable.
+
+ * UserInterface/Views/HeapSnapshotInstancesContentView.css:
+ (.heap-snapshot > .data-grid:focus tr.selected > td .sub-retained):
+ (.heap-snapshot > .data-grid:focus tr.selected .object-id,):
+ (.heap-snapshot > .data-grid:focus tr.selected .formatted-string,):
+ (.heap-snapshot > .data-grid:focus tr.selected td .location):
+ Selected row text should just be white, except for values that are usually
+ gray (object ID, object size, and sub-retained size values). These should
+ be styled like the "= $0" marker in the DOM tree outline.
+
+ (.heap-snapshot > .data-grid:matches(:focus, .force-focus) tr.selected td .location): Deleted.
+ Removed forced-focus reference. Only used by TreeOutlineDataGridSynchronizer.
+
+ * UserInterface/Views/Variables.css:
+ (:root):
+ Added --selected-secondary-text-color.
+
+2016-12-12 Matt Baker <[email protected]>
+
Web Inspector: Breakpoint Log action should support template literals
https://bugs.webkit.org/show_bug.cgi?id=165116
<rdar://problem/29464765>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css (209708 => 209709)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css 2016-12-12 17:10:30 UTC (rev 209708)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css 2016-12-12 17:20:37 UTC (rev 209709)
@@ -72,7 +72,7 @@
}
.tree-outline.dom:focus li.selected > span::after {
- color: hsla(0, 100%, 100%, 0.7);
+ color: var(--selected-secondary-text-color);
}
.tree-outline.dom ol {
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotInstanceDataGridNode.js (209708 => 209709)
--- trunk/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotInstanceDataGridNode.js 2016-12-12 17:10:30 UTC (rev 209708)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotInstanceDataGridNode.js 2016-12-12 17:20:37 UTC (rev 209709)
@@ -95,7 +95,6 @@
get data() { return this._node; }
get node() { return this._node; }
- get selectable() { return false; }
get propertyName()
{
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotInstancesContentView.css (209708 => 209709)
--- trunk/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotInstancesContentView.css 2016-12-12 17:10:30 UTC (rev 209708)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/HeapSnapshotInstancesContentView.css 2016-12-12 17:20:37 UTC (rev 209709)
@@ -49,12 +49,26 @@
text-decoration: underline;
}
+.heap-snapshot > .data-grid:focus tr.selected > td .sub-retained {
+ color: var(--selected-secondary-text-color);
+}
+
+.heap-snapshot > .data-grid:focus tr.selected .object-id,
+.heap-snapshot > .data-grid:focus tr.selected .object-preview > .size {
+ color: var(--selected-secondary-text-color);
+}
+
+.heap-snapshot > .data-grid:focus tr.selected .formatted-string,
+.heap-snapshot > .data-grid:focus tr.selected .object-preview span {
+ color: var(--selected-foreground-color);
+}
+
.heap-snapshot > .data-grid td .location {
margin-left: 1ex;
color: hsl(0, 0%, 60%);
}
-.heap-snapshot > .data-grid:matches(:focus, .force-focus) tr.selected td .location {
+.heap-snapshot > .data-grid:focus tr.selected td .location {
color: hsl(0, 0%, 85%);
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css (209708 => 209709)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css 2016-12-12 17:10:30 UTC (rev 209708)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css 2016-12-12 17:20:37 UTC (rev 209709)
@@ -33,6 +33,7 @@
--z-index-uncaught-exception-sheet: 4096;
--selected-foreground-color: white;
+ --selected-secondary-text-color: hsla(0, 100%, 100%, 0.7);
--selected-background-color: hsl(212, 92%, 54%);
--selected-background-color-unfocused: hsl(0, 0%, 83%);
--selected-background-color-active: hsl(218, 85%, 52%);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
