Title: [209769] trunk/Source/WebKit2
Revision
209769
Author
[email protected]
Date
2016-12-13 12:23:07 -0800 (Tue, 13 Dec 2016)

Log Message

NSArray leaks seen in Safari, allocated under WKIconDatabaseTryCopyCGImageArrayForURL
https://bugs.webkit.org/show_bug.cgi?id=165809

Patch by Joseph Pecoraro <[email protected]> on 2016-12-13
Reviewed by Dan Bernstein.

* UIProcess/API/C/cg/WKIconDatabaseCG.cpp:
(WKIconDatabaseTryCopyCGImageArrayForURL):
Avoid an extra retain on already newly created array.

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (209768 => 209769)


--- trunk/Source/WebKit2/ChangeLog	2016-12-13 20:18:01 UTC (rev 209768)
+++ trunk/Source/WebKit2/ChangeLog	2016-12-13 20:23:07 UTC (rev 209769)
@@ -1,3 +1,14 @@
+2016-12-13  Joseph Pecoraro  <[email protected]>
+
+        NSArray leaks seen in Safari, allocated under WKIconDatabaseTryCopyCGImageArrayForURL
+        https://bugs.webkit.org/show_bug.cgi?id=165809
+
+        Reviewed by Dan Bernstein.
+
+        * UIProcess/API/C/cg/WKIconDatabaseCG.cpp:
+        (WKIconDatabaseTryCopyCGImageArrayForURL):
+        Avoid an extra retain on already newly created array.
+
 2016-12-13  Eric Carlson  <[email protected]>
 
         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag

Modified: trunk/Source/WebKit2/UIProcess/API/C/cg/WKIconDatabaseCG.cpp (209768 => 209769)


--- trunk/Source/WebKit2/UIProcess/API/C/cg/WKIconDatabaseCG.cpp	2016-12-13 20:18:01 UTC (rev 209768)
+++ trunk/Source/WebKit2/UIProcess/API/C/cg/WKIconDatabaseCG.cpp	2016-12-13 20:23:07 UTC (rev 209769)
@@ -54,6 +54,5 @@
     for (auto nativeImage : nativeImages)
         CFArrayAppendValue(array, nativeImage.get());
     
-    return static_cast<CFArrayRef>(CFRetain(array));
+    return static_cast<CFArrayRef>(array);
 }
-
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to