Title: [209828] trunk/Source/WebCore
- Revision
- 209828
- Author
- [email protected]
- Date
- 2016-12-14 13:14:25 -0800 (Wed, 14 Dec 2016)
Log Message
[iOS] MediaDocuments have controls on the bottom of the page
https://bugs.webkit.org/show_bug.cgi?id=165865
<rdar://problem/28757268>
Reviewed by Jon Lee.
MediaDocuments on iOS are incorrectly placing the controls at
the bottom of the page. This is due to the <video> element
getting a height of 100%. It should be "auto" instead.
* html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::createDocumentStructure):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (209827 => 209828)
--- trunk/Source/WebCore/ChangeLog 2016-12-14 21:05:56 UTC (rev 209827)
+++ trunk/Source/WebCore/ChangeLog 2016-12-14 21:14:25 UTC (rev 209828)
@@ -1,3 +1,18 @@
+2016-12-14 Dean Jackson <[email protected]>
+
+ [iOS] MediaDocuments have controls on the bottom of the page
+ https://bugs.webkit.org/show_bug.cgi?id=165865
+ <rdar://problem/28757268>
+
+ Reviewed by Jon Lee.
+
+ MediaDocuments on iOS are incorrectly placing the controls at
+ the bottom of the page. This is due to the <video> element
+ getting a height of 100%. It should be "auto" instead.
+
+ * html/MediaDocument.cpp:
+ (WebCore::MediaDocumentParser::createDocumentStructure):
+
2016-12-14 Dave Hyatt <[email protected]>
[CSS Parser] Implement deferred parsing of properties, @media, @supports and @keyframes
Modified: trunk/Source/WebCore/html/MediaDocument.cpp (209827 => 209828)
--- trunk/Source/WebCore/html/MediaDocument.cpp 2016-12-14 21:05:56 UTC (rev 209827)
+++ trunk/Source/WebCore/html/MediaDocument.cpp 2016-12-14 21:14:25 UTC (rev 209828)
@@ -122,7 +122,7 @@
StringBuilder elementStyle;
elementStyle.appendLiteral("max-width: 100%; max-height: 100%;");
#if PLATFORM(IOS)
- elementStyle.appendLiteral("width: 100%; height: 100%;");
+ elementStyle.appendLiteral("width: 100%; height: auto;");
#endif
if (RuntimeEnabledFeatures::sharedFeatures().modernMediaControlsEnabled()) {
elementStyle.appendLiteral("min-height: 50px;");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
