Title: [209834] trunk/Source/WebInspectorUI
- Revision
- 209834
- Author
- [email protected]
- Date
- 2016-12-14 14:04:25 -0800 (Wed, 14 Dec 2016)
Log Message
Web Inspector: Zooming in on the Timeline should always zoom right where the cursor is
https://bugs.webkit.org/show_bug.cgi?id=151118
<rdar://problem/23487912>
Reviewed by Timothy Hatcher.
Use correct left edge for timeline overview graph elements.
* UserInterface/Views/TimelineOverview.js:
(WebInspector.TimelineOverview.prototype._handleWheelEvent):
(WebInspector.TimelineOverview._handleGestureStart):
(WebInspector.TimelineOverview.prototype._handleGestureChange):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (209833 => 209834)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-12-14 21:57:37 UTC (rev 209833)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-12-14 22:04:25 UTC (rev 209834)
@@ -1,3 +1,18 @@
+2016-12-14 Matt Baker <[email protected]>
+
+ Web Inspector: Zooming in on the Timeline should always zoom right where the cursor is
+ https://bugs.webkit.org/show_bug.cgi?id=151118
+ <rdar://problem/23487912>
+
+ Reviewed by Timothy Hatcher.
+
+ Use correct left edge for timeline overview graph elements.
+
+ * UserInterface/Views/TimelineOverview.js:
+ (WebInspector.TimelineOverview.prototype._handleWheelEvent):
+ (WebInspector.TimelineOverview._handleGestureStart):
+ (WebInspector.TimelineOverview.prototype._handleGestureChange):
+
2016-12-12 Nikita Vasilyev <[email protected]>
[GTK] Web Inspector: Add NavigationItemCodeCoverage.svg icon
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js (209833 => 209834)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js 2016-12-14 21:57:37 UTC (rev 209833)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js 2016-12-14 22:04:25 UTC (rev 209834)
@@ -544,7 +544,7 @@
}
// Remember the mouse position in time.
- let mouseOffset = event.pageX - this.element.totalOffsetLeft;
+ let mouseOffset = event.pageX - this._graphsContainerView.element.totalOffsetLeft;
let mousePositionTime = this._currentSettings.scrollStartTime + (mouseOffset * this.secondsPerPixel);
let deviceDirection = event.webkitDirectionInvertedFromDevice ? 1 : -1;
let delta = event.deltaY * (this.secondsPerPixel / WebInspector.TimelineOverview.ScrollDeltaDenominator) * deviceDirection;
@@ -576,7 +576,7 @@
return;
}
- let mouseOffset = event.pageX - this.element.totalOffsetLeft;
+ let mouseOffset = event.pageX - this._graphsContainerView.element.totalOffsetLeft;
let mousePositionTime = this._currentSettings.scrollStartTime + (mouseOffset * this.secondsPerPixel);
this._handlingGesture = true;
@@ -592,7 +592,7 @@
// Cap zooming out at 5x.
let scale = Math.max(1 / 5, event.scale);
- let mouseOffset = event.pageX - this.element.totalOffsetLeft;
+ let mouseOffset = event.pageX - this._graphsContainerView.element.totalOffsetLeft;
let newSecondsPerPixel = this._gestureStartDurationPerPixel / scale;
this.secondsPerPixel = newSecondsPerPixel;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
