Title: [209851] trunk/Source/WebKit2
Revision
209851
Author
[email protected]
Date
2016-12-14 19:48:49 -0800 (Wed, 14 Dec 2016)

Log Message

Only send Messages::WebPageProxy::DidSaveToPageCache once when entering page cache.
<https://webkit.org/b/165887>

Reviewed by Brady Eidson.

We were sending one of these IPC messages per frame when a page enters the page cache,
and we really only need one, so only do it for the main frame.

(This message is used to adopt the page cache on the UI process side, in case another
web process currently owns the cache. That happens in WebProcessPool::processDidCachePage().)

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::didSaveToPageCache):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (209850 => 209851)


--- trunk/Source/WebKit2/ChangeLog	2016-12-15 03:30:44 UTC (rev 209850)
+++ trunk/Source/WebKit2/ChangeLog	2016-12-15 03:48:49 UTC (rev 209851)
@@ -1,3 +1,19 @@
+2016-12-14  Andreas Kling  <[email protected]>
+
+        Only send Messages::WebPageProxy::DidSaveToPageCache once when entering page cache.
+        <https://webkit.org/b/165887>
+
+        Reviewed by Brady Eidson.
+
+        We were sending one of these IPC messages per frame when a page enters the page cache,
+        and we really only need one, so only do it for the main frame.
+
+        (This message is used to adopt the page cache on the UI process side, in case another
+        web process currently owns the cache. That happens in WebProcessPool::processDidCachePage().)
+
+        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+        (WebKit::WebFrameLoaderClient::didSaveToPageCache):
+
 2016-12-14  Simon Fraser  <[email protected]>
 
         Fix cause of viewport-related flakiness in iOS tests

Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (209850 => 209851)


--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp	2016-12-15 03:30:44 UTC (rev 209850)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp	2016-12-15 03:48:49 UTC (rev 209851)
@@ -1370,7 +1370,8 @@
     if (!webPage)
         return;
 
-    webPage->send(Messages::WebPageProxy::DidSaveToPageCache());
+    if (m_frame->isMainFrame())
+        webPage->send(Messages::WebPageProxy::DidSaveToPageCache());
 }
 
 void WebFrameLoaderClient::didRestoreFromPageCache()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to