Title: [209855] trunk/Source/WebInspectorUI
- Revision
- 209855
- Author
- [email protected]
- Date
- 2016-12-14 21:15:11 -0800 (Wed, 14 Dec 2016)
Log Message
Web Inspector: Jumping to the definition of a custom elements is broken
https://bugs.webkit.org/show_bug.cgi?id=165890
Reviewed by Joseph Pecoraro.
Fix the regression from https://trac.webkit.org/changeset/208304.
* UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype._showCustomElementDefinition): Use the main target
since a custom element definition can never come from a worker.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (209854 => 209855)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-12-15 05:10:45 UTC (rev 209854)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-12-15 05:15:11 UTC (rev 209855)
@@ -1,3 +1,16 @@
+2016-12-14 Ryosuke Niwa <[email protected]>
+
+ Web Inspector: Jumping to the definition of a custom elements is broken
+ https://bugs.webkit.org/show_bug.cgi?id=165890
+
+ Reviewed by Joseph Pecoraro.
+
+ Fix the regression from https://trac.webkit.org/changeset/208304.
+
+ * UserInterface/Views/DOMTreeElement.js:
+ (WebInspector.DOMTreeElement.prototype._showCustomElementDefinition): Use the main target
+ since a custom element definition can never come from a worker.
+
2016-12-14 Matt Baker <[email protected]>
Web Inspector: Zooming in on the Timeline should always zoom right where the cursor is
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js (209854 => 209855)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js 2016-12-15 05:10:45 UTC (rev 209854)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js 2016-12-15 05:15:11 UTC (rev 209855)
@@ -1509,7 +1509,7 @@
return;
let location = response.location;
- let sourceCode = WebInspector.debuggerManager.scriptForIdentifier(location.scriptId);
+ let sourceCode = WebInspector.debuggerManager.scriptForIdentifier(location.scriptId, WebInspector.mainTarget);
if (!sourceCode)
return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
