Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (209870 => 209871)
--- trunk/Source/_javascript_Core/ChangeLog 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-12-15 21:26:08 UTC (rev 209871)
@@ -1,3 +1,14 @@
+2016-12-15 Konstantin Tokarev <[email protected]>
+
+ Added missing override and final specifiers
+ https://bugs.webkit.org/show_bug.cgi?id=165903
+
+ Reviewed by Darin Adler.
+
+ * bytecompiler/BytecodeGenerator.h:
+ * jsc.cpp:
+ * parser/Nodes.h:
+
2016-12-15 Chris Dumez <[email protected]>
Harden JSObject::getOwnPropertyDescriptor()
Modified: trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h (209870 => 209871)
--- trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -139,7 +139,7 @@
{
}
- virtual ForInContextType type() const
+ ForInContextType type() const override
{
return StructureForInContextType;
}
@@ -162,7 +162,7 @@
{
}
- virtual ForInContextType type() const
+ ForInContextType type() const override
{
return IndexedForInContextType;
}
Modified: trunk/Source/_javascript_Core/jsc.cpp (209870 => 209871)
--- trunk/Source/_javascript_Core/jsc.cpp 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/_javascript_Core/jsc.cpp 2016-12-15 21:26:08 UTC (rev 209871)
@@ -201,7 +201,7 @@
class ElementHandleOwner : public WeakHandleOwner {
public:
- virtual bool isReachableFromOpaqueRoots(Handle<JSC::Unknown> handle, void*, SlotVisitor& visitor)
+ bool isReachableFromOpaqueRoots(Handle<JSC::Unknown> handle, void*, SlotVisitor& visitor) override
{
Element* element = jsCast<Element*>(handle.slot()->asCell());
return visitor.containsOpaqueRoot(element->root());
Modified: trunk/Source/_javascript_Core/parser/Nodes.h (209870 => 209871)
--- trunk/Source/_javascript_Core/parser/Nodes.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/_javascript_Core/parser/Nodes.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -1752,7 +1752,7 @@
class ModuleDeclarationNode : public StatementNode {
public:
virtual void analyzeModule(ModuleAnalyzer&) = 0;
- virtual bool isModuleDeclarationNode() const { return true; }
+ bool isModuleDeclarationNode() const override { return true; }
protected:
ModuleDeclarationNode(const JSTokenLocation&);
Modified: trunk/Source/WTF/ChangeLog (209870 => 209871)
--- trunk/Source/WTF/ChangeLog 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WTF/ChangeLog 2016-12-15 21:26:08 UTC (rev 209871)
@@ -1,3 +1,12 @@
+2016-12-15 Konstantin Tokarev <[email protected]>
+
+ Added missing override and final specifiers
+ https://bugs.webkit.org/show_bug.cgi?id=165903
+
+ Reviewed by Darin Adler.
+
+ * wtf/RunLoop.h:
+
2016-12-15 Yusuke Suzuki <[email protected]>
[JSC] Optimize Kraken stringify
Modified: trunk/Source/WTF/wtf/RunLoop.h (209870 => 209871)
--- trunk/Source/WTF/wtf/RunLoop.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WTF/wtf/RunLoop.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -142,7 +142,7 @@
}
private:
- virtual void fired() { (m_object->*m_function)(); }
+ void fired() override { (m_object->*m_function)(); }
TimerFiredClass* m_object;
TimerFiredFunction m_function;
Modified: trunk/Source/WebCore/ChangeLog (209870 => 209871)
--- trunk/Source/WebCore/ChangeLog 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/ChangeLog 2016-12-15 21:26:08 UTC (rev 209871)
@@ -1,3 +1,83 @@
+2016-12-15 Konstantin Tokarev <[email protected]>
+
+ Added missing override and final specifiers
+ https://bugs.webkit.org/show_bug.cgi?id=165903
+
+ Reviewed by Darin Adler.
+
+ No new tests needed.
+
+ * Modules/mediastream/OverconstrainedErrorEvent.h:
+ * bindings/js/JSCallbackData.h:
+ * bindings/js/JSCustomXPathNSResolver.h:
+ * bindings/js/JSErrorHandler.h:
+ * css/StyleRuleImport.h:
+ * dom/SecurityPolicyViolationEvent.h:
+ * editing/CreateLinkCommand.h:
+ * editing/DeleteSelectionCommand.h:
+ * editing/DictationCommand.h:
+ * editing/Editor.cpp:
+ * editing/FormatBlockCommand.h:
+ * editing/IndentOutdentCommand.h:
+ * editing/InsertLineBreakCommand.h:
+ * editing/InsertParagraphSeparatorCommand.h:
+ * editing/ModifySelectionListLevel.h:
+ * editing/MoveSelectionCommand.h:
+ * editing/RemoveFormatCommand.h:
+ * editing/RemoveNodePreservingChildrenCommand.h:
+ * editing/ReplaceSelectionCommand.h:
+ * editing/SimplifyMarkupCommand.h:
+ * editing/SplitTextNodeContainingElementCommand.h:
+ * editing/UnlinkCommand.h:
+ * fileapi/FileReaderLoader.h:
+ * html/canvas/ANGLEInstancedArrays.h:
+ * html/canvas/WebGLVertexArrayObjectBase.h:
+ * loader/SinkDocument.h:
+ * loader/archive/mhtml/MHTMLArchive.h:
+ * page/animation/CSSPropertyAnimation.cpp:
+ * platform/audio/MultiChannelResampler.cpp:
+ * platform/audio/SincResampler.cpp:
+ * platform/audio/gstreamer/AudioDestinationGStreamer.h:
+ * platform/audio/gstreamer/AudioSourceProviderGStreamer.h:
+ * platform/graphics/TextTrackRepresentation.cpp:
+ * platform/graphics/displaylists/DisplayListItems.h:
+ * platform/graphics/filters/FEBlend.h:
+ * platform/graphics/filters/FEColorMatrix.h:
+ * platform/graphics/filters/FEComponentTransfer.h:
+ * platform/graphics/filters/FEConvolveMatrix.h:
+ * platform/graphics/filters/FEDiffuseLighting.h:
+ * platform/graphics/filters/FEDropShadow.h:
+ * platform/graphics/filters/FEGaussianBlur.h:
+ * platform/graphics/filters/FELighting.h:
+ * platform/graphics/filters/FEMerge.h:
+ * platform/graphics/filters/FEMorphology.h:
+ * platform/graphics/filters/FEOffset.h:
+ * platform/graphics/filters/FESpecularLighting.h:
+ * platform/graphics/filters/FETile.h:
+ * platform/graphics/filters/FETurbulence.h:
+ * platform/graphics/filters/SourceAlpha.h:
+ * platform/graphics/filters/SourceGraphic.h:
+ * platform/graphics/opengl/Extensions3DOpenGL.h:
+ * platform/graphics/opengl/Extensions3DOpenGLCommon.h:
+ * platform/graphics/texmap/TextureMapperBackingStore.h:
+ * platform/mediastream/openwebrtc/RealtimeMediaSourceOwr.h:
+ * platform/mock/GeolocationClientMock.h:
+ * platform/text/TextCodecICU.h:
+ * platform/text/TextCodecLatin1.h:
+ * platform/text/TextCodecUTF16.h:
+ * platform/text/TextCodecUTF8.h:
+ * platform/text/TextCodecUserDefined.h:
+ * rendering/RenderFullScreen.cpp:
+ * storage/StorageEvent.h:
+ * svg/properties/SVGListProperty.h:
+ * svg/properties/SVGStaticListPropertyTearOff.h:
+ * svg/properties/SVGStaticPropertyTearOff.h:
+ * xml/NativeXPathNSResolver.h:
+ * xml/XMLHttpRequestProgressEvent.h:
+ * xml/XMLHttpRequestProgressEventThrottle.h:
+ * xml/XPathVariableReference.h:
+ * xml/XSLImportRule.h:
+
2016-12-15 Chris Dumez <[email protected]>
Inline Document::existingAXObjectCache()
Modified: trunk/Source/WebCore/Modules/mediastream/OverconstrainedErrorEvent.h (209870 => 209871)
--- trunk/Source/WebCore/Modules/mediastream/OverconstrainedErrorEvent.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/Modules/mediastream/OverconstrainedErrorEvent.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -55,7 +55,7 @@
}
OverconstrainedError* error() const { return m_error.get(); }
- virtual EventInterface eventInterface() const { return OverconstrainedErrorEventInterfaceType; }
+ EventInterface eventInterface() const override { return OverconstrainedErrorEventInterfaceType; }
private:
explicit OverconstrainedErrorEvent(const AtomicString& type, bool canBubble, bool cancelable, OverconstrainedError* error)
Modified: trunk/Source/WebCore/bindings/js/JSCallbackData.h (209870 => 209871)
--- trunk/Source/WebCore/bindings/js/JSCallbackData.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/bindings/js/JSCallbackData.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -105,7 +105,7 @@
private:
class WeakOwner : public JSC::WeakHandleOwner {
- virtual bool isReachableFromOpaqueRoots(JSC::Handle<JSC::Unknown>, void* context, JSC::SlotVisitor&);
+ bool isReachableFromOpaqueRoots(JSC::Handle<JSC::Unknown>, void* context, JSC::SlotVisitor&) override;
};
WeakOwner m_weakOwner;
JSC::Weak<JSC::JSObject> m_callback;
Modified: trunk/Source/WebCore/bindings/js/JSCustomXPathNSResolver.h (209870 => 209871)
--- trunk/Source/WebCore/bindings/js/JSCustomXPathNSResolver.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/bindings/js/JSCustomXPathNSResolver.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -49,7 +49,7 @@
virtual ~JSCustomXPathNSResolver();
- virtual String lookupNamespaceURI(const String& prefix);
+ String lookupNamespaceURI(const String& prefix) override;
private:
JSCustomXPathNSResolver(JSC::ExecState*, JSC::JSObject*, JSDOMWindow*);
Modified: trunk/Source/WebCore/bindings/js/JSErrorHandler.h (209870 => 209871)
--- trunk/Source/WebCore/bindings/js/JSErrorHandler.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/bindings/js/JSErrorHandler.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -45,7 +45,7 @@
private:
JSErrorHandler(JSC::JSObject* function, JSC::JSObject* wrapper, bool isAttribute, DOMWrapperWorld&);
- virtual void handleEvent(ScriptExecutionContext*, Event*);
+ void handleEvent(ScriptExecutionContext*, Event*) final;
};
// Creates a JS EventListener for "onerror" event handler in worker context. It has custom implementation because
Modified: trunk/Source/WebCore/css/StyleRuleImport.h (209870 => 209871)
--- trunk/Source/WebCore/css/StyleRuleImport.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/css/StyleRuleImport.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -59,7 +59,7 @@
public:
ImportedStyleSheetClient(StyleRuleImport* ownerRule) : m_ownerRule(ownerRule) { }
virtual ~ImportedStyleSheetClient() { }
- virtual void setCSSStyleSheet(const String& href, const URL& baseURL, const String& charset, const CachedCSSStyleSheet* sheet)
+ void setCSSStyleSheet(const String& href, const URL& baseURL, const String& charset, const CachedCSSStyleSheet* sheet) final
{
m_ownerRule->setCSSStyleSheet(href, baseURL, charset, sheet);
}
Modified: trunk/Source/WebCore/dom/SecurityPolicyViolationEvent.h (209870 => 209871)
--- trunk/Source/WebCore/dom/SecurityPolicyViolationEvent.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/dom/SecurityPolicyViolationEvent.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -70,7 +70,7 @@
int lineNumber() const { return m_lineNumber; }
int columnNumber() const { return m_columnNumber; }
- virtual EventInterface eventInterface() const { return SecurityPolicyViolationEventInterfaceType; }
+ EventInterface eventInterface() const final { return SecurityPolicyViolationEventInterfaceType; }
private:
SecurityPolicyViolationEvent()
Modified: trunk/Source/WebCore/editing/CreateLinkCommand.h (209870 => 209871)
--- trunk/Source/WebCore/editing/CreateLinkCommand.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/editing/CreateLinkCommand.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -36,13 +36,13 @@
return adoptRef(*new CreateLinkCommand(document, linkURL));
}
- bool isCreateLinkCommand() const { return true; }
+ bool isCreateLinkCommand() const override { return true; }
private:
CreateLinkCommand(Document&, const String& linkURL);
- virtual void doApply();
- virtual EditAction editingAction() const { return EditActionCreateLink; }
+ void doApply() override;
+ EditAction editingAction() const override { return EditActionCreateLink; }
String m_url;
};
Modified: trunk/Source/WebCore/editing/DeleteSelectionCommand.h (209870 => 209871)
--- trunk/Source/WebCore/editing/DeleteSelectionCommand.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/editing/DeleteSelectionCommand.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -48,9 +48,9 @@
private:
DeleteSelectionCommand(const VisibleSelection&, bool smartDelete, bool mergeBlocksAfterDelete, bool replace, bool expandForSpecialElements, bool sanitizeMarkup, EditAction);
- virtual void doApply();
+ void doApply() override;
- virtual bool preservesTypingStyle() const;
+ bool preservesTypingStyle() const override;
void initializeStartEnd(Position&, Position&);
void setStartingSelectionOnSmartDelete(const Position&, const Position&);
@@ -66,8 +66,8 @@
void calculateTypingStyleAfterDelete();
void clearTransientState();
void makeStylingElementsDirectChildrenOfEditableRootToPreventStyleLoss();
- virtual void removeNode(PassRefPtr<Node>, ShouldAssumeContentIsAlwaysEditable = DoNotAssumeContentIsAlwaysEditable);
- virtual void deleteTextFromNode(PassRefPtr<Text>, unsigned, unsigned);
+ void removeNode(PassRefPtr<Node>, ShouldAssumeContentIsAlwaysEditable = DoNotAssumeContentIsAlwaysEditable) override;
+ void deleteTextFromNode(PassRefPtr<Text>, unsigned, unsigned) override;
void removeRedundantBlocks();
// This function provides access to original string after the correction has been deleted.
Modified: trunk/Source/WebCore/editing/DictationCommand.h (209870 => 209871)
--- trunk/Source/WebCore/editing/DictationCommand.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/editing/DictationCommand.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -34,7 +34,7 @@
friend class DictationCommandLineOperation;
public:
static void insertText(Document&, const String&, const Vector<DictationAlternative>& alternatives, const VisibleSelection&);
- virtual bool isDictationCommand() const { return true; }
+ bool isDictationCommand() const override { return true; }
private:
static Ref<DictationCommand> create(Document& document, const String& text, const Vector<DictationAlternative>& alternatives)
{
@@ -43,7 +43,7 @@
DictationCommand(Document&, const String& text, const Vector<DictationAlternative>& alternatives);
- virtual void doApply();
+ void doApply() override;
void insertTextRunWithoutNewlines(size_t lineStart, size_t lineLength);
void insertParagraphSeparator();
Modified: trunk/Source/WebCore/editing/Editor.cpp (209870 => 209871)
--- trunk/Source/WebCore/editing/Editor.cpp 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/editing/Editor.cpp 2016-12-15 21:26:08 UTC (rev 209871)
@@ -146,7 +146,7 @@
static void CreateAndApply(const RefPtr<Frame> frame);
private:
- virtual EditAction editingAction() const;
+ EditAction editingAction() const override;
};
ClearTextCommand::ClearTextCommand(Document& document)
Modified: trunk/Source/WebCore/editing/FormatBlockCommand.h (209870 => 209871)
--- trunk/Source/WebCore/editing/FormatBlockCommand.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/editing/FormatBlockCommand.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -44,7 +44,7 @@
return adoptRef(*new FormatBlockCommand(document, tagName));
}
- virtual bool preservesTypingStyle() const { return true; }
+ bool preservesTypingStyle() const override { return true; }
static Element* elementForFormatBlockCommand(Range*);
bool didApply() const { return m_didApply; }
@@ -52,9 +52,9 @@
private:
FormatBlockCommand(Document&, const QualifiedName& tagName);
- void formatSelection(const VisiblePosition& startOfSelection, const VisiblePosition& endOfSelection);
- void formatRange(const Position& start, const Position& end, const Position& endOfSelection, RefPtr<Element>&);
- EditAction editingAction() const { return EditActionFormatBlock; }
+ void formatSelection(const VisiblePosition& startOfSelection, const VisiblePosition& endOfSelection) override;
+ void formatRange(const Position& start, const Position& end, const Position& endOfSelection, RefPtr<Element>&) override;
+ EditAction editingAction() const override { return EditActionFormatBlock; }
bool m_didApply;
};
Modified: trunk/Source/WebCore/editing/IndentOutdentCommand.h (209870 => 209871)
--- trunk/Source/WebCore/editing/IndentOutdentCommand.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/editing/IndentOutdentCommand.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -38,12 +38,12 @@
return adoptRef(*new IndentOutdentCommand(document, type, marginInPixels));
}
- virtual bool preservesTypingStyle() const { return true; }
+ bool preservesTypingStyle() const override { return true; }
private:
IndentOutdentCommand(Document&, EIndentType, int marginInPixels);
- virtual EditAction editingAction() const { return m_typeOfAction == Indent ? EditActionIndent : EditActionOutdent; }
+ EditAction editingAction() const override { return m_typeOfAction == Indent ? EditActionIndent : EditActionOutdent; }
void indentRegion(const VisiblePosition&, const VisiblePosition&);
void outdentRegion(const VisiblePosition&, const VisiblePosition&);
@@ -51,8 +51,8 @@
bool tryIndentingAsListItem(const Position&, const Position&);
void indentIntoBlockquote(const Position&, const Position&, RefPtr<Element>&);
- void formatSelection(const VisiblePosition& startOfSelection, const VisiblePosition& endOfSelection);
- void formatRange(const Position& start, const Position& end, const Position& endOfSelection, RefPtr<Element>& blockquoteForNextIndent);
+ void formatSelection(const VisiblePosition& startOfSelection, const VisiblePosition& endOfSelection) override;
+ void formatRange(const Position& start, const Position& end, const Position& endOfSelection, RefPtr<Element>& blockquoteForNextIndent) override;
EIndentType m_typeOfAction;
int m_marginInPixels;
Modified: trunk/Source/WebCore/editing/InsertLineBreakCommand.h (209870 => 209871)
--- trunk/Source/WebCore/editing/InsertLineBreakCommand.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/editing/InsertLineBreakCommand.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -39,9 +39,9 @@
private:
explicit InsertLineBreakCommand(Document&);
- virtual void doApply();
+ void doApply() override;
- virtual bool preservesTypingStyle() const;
+ bool preservesTypingStyle() const override;
void insertNodeAfterPosition(Node*, const Position&);
void insertNodeBeforePosition(Node*, const Position&);
Modified: trunk/Source/WebCore/editing/InsertParagraphSeparatorCommand.h (209870 => 209871)
--- trunk/Source/WebCore/editing/InsertParagraphSeparatorCommand.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/editing/InsertParagraphSeparatorCommand.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -41,7 +41,7 @@
private:
InsertParagraphSeparatorCommand(Document&, bool useDefaultParagraphElement, bool pasteBlockqutoeIntoUnquotedArea, EditAction);
- virtual void doApply();
+ void doApply() override;
void calculateStyleBeforeInsertion(const Position&);
void applyStyleAfterInsertion(Node* originalEnclosingBlock);
@@ -50,7 +50,7 @@
bool shouldUseDefaultParagraphElement(Node*) const;
- virtual bool preservesTypingStyle() const;
+ bool preservesTypingStyle() const override;
RefPtr<EditingStyle> m_style;
Modified: trunk/Source/WebCore/editing/ModifySelectionListLevel.h (209870 => 209871)
--- trunk/Source/WebCore/editing/ModifySelectionListLevel.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/editing/ModifySelectionListLevel.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -41,7 +41,7 @@
void insertSiblingNodeRangeAfter(Node* startNode, Node* endNode, Node* refNode);
private:
- virtual bool preservesTypingStyle() const;
+ bool preservesTypingStyle() const override;
};
// IncreaseSelectionListLevelCommand moves the selected list items one level deeper.
@@ -63,7 +63,7 @@
IncreaseSelectionListLevelCommand(Document&, Type);
- virtual void doApply();
+ void doApply() override;
Type m_listType;
RefPtr<Node> m_listElement;
@@ -83,7 +83,7 @@
explicit DecreaseSelectionListLevelCommand(Document&);
- virtual void doApply();
+ void doApply() override;
};
} // namespace WebCore
Modified: trunk/Source/WebCore/editing/MoveSelectionCommand.h (209870 => 209871)
--- trunk/Source/WebCore/editing/MoveSelectionCommand.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/editing/MoveSelectionCommand.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -41,8 +41,8 @@
private:
MoveSelectionCommand(PassRefPtr<DocumentFragment>, const Position&, bool smartInsert, bool smartDelete);
- virtual void doApply();
- virtual EditAction editingAction() const;
+ void doApply() override;
+ EditAction editingAction() const override;
bool shouldDispatchInputEvents() const final { return false; }
RefPtr<DocumentFragment> m_fragment;
Modified: trunk/Source/WebCore/editing/RemoveFormatCommand.h (209870 => 209871)
--- trunk/Source/WebCore/editing/RemoveFormatCommand.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/editing/RemoveFormatCommand.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -39,8 +39,8 @@
private:
explicit RemoveFormatCommand(Document&);
- virtual void doApply();
- virtual EditAction editingAction() const { return EditActionUnspecified; }
+ void doApply() override;
+ EditAction editingAction() const override { return EditActionUnspecified; }
};
} // namespace WebCore
Modified: trunk/Source/WebCore/editing/RemoveNodePreservingChildrenCommand.h (209870 => 209871)
--- trunk/Source/WebCore/editing/RemoveNodePreservingChildrenCommand.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/editing/RemoveNodePreservingChildrenCommand.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -39,7 +39,7 @@
private:
explicit RemoveNodePreservingChildrenCommand(PassRefPtr<Node>, ShouldAssumeContentIsAlwaysEditable, EditAction);
- virtual void doApply();
+ void doApply() override;
RefPtr<Node> m_node;
ShouldAssumeContentIsAlwaysEditable m_shouldAssumeContentIsAlwaysEditable;
Modified: trunk/Source/WebCore/editing/ReplaceSelectionCommand.h (209870 => 209871)
--- trunk/Source/WebCore/editing/ReplaceSelectionCommand.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/editing/ReplaceSelectionCommand.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -60,7 +60,7 @@
String inputEventData() const final;
RefPtr<DataTransfer> inputEventDataTransfer() const final;
bool willApplyCommand() final;
- virtual void doApply();
+ void doApply() override;
class InsertedNodes {
public:
Modified: trunk/Source/WebCore/editing/SimplifyMarkupCommand.h (209870 => 209871)
--- trunk/Source/WebCore/editing/SimplifyMarkupCommand.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/editing/SimplifyMarkupCommand.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -39,7 +39,7 @@
private:
SimplifyMarkupCommand(Document&, Node* firstNode, Node* nodeAfterLast);
- virtual void doApply();
+ void doApply() override;
int pruneSubsequentAncestorsToRemove(Vector<RefPtr<Node>>& nodesToRemove, size_t startNodeIndex);
RefPtr<Node> m_firstNode;
Modified: trunk/Source/WebCore/editing/SplitTextNodeContainingElementCommand.h (209870 => 209871)
--- trunk/Source/WebCore/editing/SplitTextNodeContainingElementCommand.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/editing/SplitTextNodeContainingElementCommand.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -39,7 +39,7 @@
private:
SplitTextNodeContainingElementCommand(PassRefPtr<Text>, int offset);
- virtual void doApply();
+ void doApply() override;
RefPtr<Text> m_text;
int m_offset;
Modified: trunk/Source/WebCore/editing/UnlinkCommand.h (209870 => 209871)
--- trunk/Source/WebCore/editing/UnlinkCommand.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/editing/UnlinkCommand.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -39,8 +39,8 @@
private:
explicit UnlinkCommand(Document&);
- virtual void doApply();
- virtual EditAction editingAction() const { return EditActionUnlink; }
+ void doApply() override;
+ EditAction editingAction() const override { return EditActionUnlink; }
};
} // namespace WebCore
Modified: trunk/Source/WebCore/fileapi/FileReaderLoader.h (209870 => 209871)
--- trunk/Source/WebCore/fileapi/FileReaderLoader.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/fileapi/FileReaderLoader.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -68,10 +68,10 @@
void cancel();
// ThreadableLoaderClient
- virtual void didReceiveResponse(unsigned long, const ResourceResponse&);
- virtual void didReceiveData(const char*, int);
- virtual void didFinishLoading(unsigned long, double);
- virtual void didFail(const ResourceError&);
+ void didReceiveResponse(unsigned long, const ResourceResponse&) override;
+ void didReceiveData(const char*, int) override;
+ void didFinishLoading(unsigned long, double) override;
+ void didFail(const ResourceError&) override;
String stringResult();
RefPtr<JSC::ArrayBuffer> arrayBufferResult() const;
Modified: trunk/Source/WebCore/html/canvas/ANGLEInstancedArrays.h (209870 => 209871)
--- trunk/Source/WebCore/html/canvas/ANGLEInstancedArrays.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/html/canvas/ANGLEInstancedArrays.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -36,7 +36,7 @@
explicit ANGLEInstancedArrays(WebGLRenderingContextBase&);
virtual ~ANGLEInstancedArrays();
- virtual ExtensionName getName() const;
+ ExtensionName getName() const final;
static bool supported(WebGLRenderingContextBase&);
Modified: trunk/Source/WebCore/html/canvas/WebGLVertexArrayObjectBase.h (209870 => 209871)
--- trunk/Source/WebCore/html/canvas/WebGLVertexArrayObjectBase.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/html/canvas/WebGLVertexArrayObjectBase.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -85,7 +85,7 @@
protected:
WebGLVertexArrayObjectBase(WebGLRenderingContextBase&, VAOType);
- virtual void deleteObjectImpl(GraphicsContext3D*, Platform3DObject) = 0;
+ void deleteObjectImpl(GraphicsContext3D*, Platform3DObject) override = 0;
VAOType m_type;
bool m_hasEverBeenBound;
Modified: trunk/Source/WebCore/loader/SinkDocument.h (209870 => 209871)
--- trunk/Source/WebCore/loader/SinkDocument.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/loader/SinkDocument.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -38,8 +38,8 @@
private:
SinkDocument(Frame*, const URL&);
-
- virtual Ref<DocumentParser> createParser();
+
+ Ref<DocumentParser> createParser() final;
};
}; // namespace WebCore
Modified: trunk/Source/WebCore/loader/archive/mhtml/MHTMLArchive.h (209870 => 209871)
--- trunk/Source/WebCore/loader/archive/mhtml/MHTMLArchive.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/loader/archive/mhtml/MHTMLArchive.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -42,7 +42,7 @@
class MHTMLArchive : public Archive {
public:
- virtual Type type() const { return MHTML; }
+ Type type() const override { return MHTML; }
static Ref<MHTMLArchive> create();
static RefPtr<MHTMLArchive> create(const URL&, SharedBuffer&);
Modified: trunk/Source/WebCore/page/animation/CSSPropertyAnimation.cpp (209870 => 209871)
--- trunk/Source/WebCore/page/animation/CSSPropertyAnimation.cpp 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/page/animation/CSSPropertyAnimation.cpp 2016-12-15 21:26:08 UTC (rev 209871)
@@ -461,7 +461,7 @@
{
}
- virtual void blend(const AnimationBase* anim, RenderStyle* dst, const RenderStyle* a, const RenderStyle* b, double progress) const
+ void blend(const AnimationBase* anim, RenderStyle* dst, const RenderStyle* a, const RenderStyle* b, double progress) const override
{
(dst->*m_setter)(blendFunc(anim, (a->*PropertyWrapperGetter<T>::m_getter)(), (b->*PropertyWrapperGetter<T>::m_getter)(), progress));
}
@@ -480,7 +480,7 @@
{
}
- virtual void blend(const AnimationBase* anim, RenderStyle* dst, const RenderStyle* a, const RenderStyle* b, double progress) const
+ void blend(const AnimationBase* anim, RenderStyle* dst, const RenderStyle* a, const RenderStyle* b, double progress) const override
{
(dst->*m_setter)(blendFunc(anim, (a->*PropertyWrapperGetter<T*>::m_getter)(), (b->*PropertyWrapperGetter<T*>::m_getter)(), progress));
}
@@ -499,7 +499,7 @@
{
}
- virtual void blend(const AnimationBase* anim, RenderStyle* dst, const RenderStyle* a, const RenderStyle* b, double progress) const
+ void blend(const AnimationBase* anim, RenderStyle* dst, const RenderStyle* a, const RenderStyle* b, double progress) const override
{
(dst->*m_setter)(blendFunc(anim, (a->*PropertyWrapperGetter<const T&>::m_getter)(), (b->*PropertyWrapperGetter<const T&>::m_getter)(), progress));
}
@@ -998,7 +998,7 @@
{
}
- virtual void blend(const AnimationBase* anim, FillLayer* dst, const FillLayer* a, const FillLayer* b, double progress) const
+ void blend(const AnimationBase* anim, FillLayer* dst, const FillLayer* a, const FillLayer* b, double progress) const override
{
(dst->*m_setter)(blendFunc(anim, (a->*FillLayerPropertyWrapperGetter<const T&>::m_getter)(), (b->*FillLayerPropertyWrapperGetter<const T&>::m_getter)(), progress));
}
@@ -1017,7 +1017,7 @@
{
}
- virtual void blend(const AnimationBase* anim, FillLayer* dst, const FillLayer* a, const FillLayer* b, double progress) const
+ void blend(const AnimationBase* anim, FillLayer* dst, const FillLayer* a, const FillLayer* b, double progress) const override
{
(dst->*m_setter)(blendFunc(anim, (a->*FillLayerPropertyWrapperGetter<T*>::m_getter)(), (b->*FillLayerPropertyWrapperGetter<T*>::m_getter)(), progress));
}
Modified: trunk/Source/WebCore/platform/audio/MultiChannelResampler.cpp (209870 => 209871)
--- trunk/Source/WebCore/platform/audio/MultiChannelResampler.cpp 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/audio/MultiChannelResampler.cpp 2016-12-15 21:26:08 UTC (rev 209871)
@@ -53,7 +53,7 @@
// provideInput() will be called once for each channel, starting with the first channel.
// Each time it's called, it will provide the next channel of data.
- virtual void provideInput(AudioBus* bus, size_t framesToProcess)
+ void provideInput(AudioBus* bus, size_t framesToProcess) override
{
bool isBusGood = bus && bus->numberOfChannels() == 1;
ASSERT(isBusGood);
Modified: trunk/Source/WebCore/platform/audio/SincResampler.cpp (209870 => 209871)
--- trunk/Source/WebCore/platform/audio/SincResampler.cpp 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/audio/SincResampler.cpp 2016-12-15 21:26:08 UTC (rev 209871)
@@ -153,7 +153,7 @@
}
// Consumes samples from the in-memory buffer.
- virtual void provideInput(AudioBus* bus, size_t framesToProcess)
+ void provideInput(AudioBus* bus, size_t framesToProcess) override
{
ASSERT(m_source && bus);
if (!m_source || !bus)
Modified: trunk/Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.h (209870 => 209871)
--- trunk/Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -34,11 +34,11 @@
AudioDestinationGStreamer(AudioIOCallback&, float sampleRate);
virtual ~AudioDestinationGStreamer();
- virtual void start();
- virtual void stop();
+ void start() override;
+ void stop() override;
- bool isPlaying() { return m_isPlaying; }
- float sampleRate() const { return m_sampleRate; }
+ bool isPlaying() override { return m_isPlaying; }
+ float sampleRate() const override { return m_sampleRate; }
AudioIOCallback& callback() const { return m_callback; }
gboolean handleMessage(GstMessage*);
Modified: trunk/Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.h (209870 => 209871)
--- trunk/Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -40,8 +40,8 @@
void configureAudioBin(GstElement* audioBin, GstElement* teePredecessor);
- void provideInput(AudioBus*, size_t framesToProcess);
- void setClient(AudioSourceProviderClient*);
+ void provideInput(AudioBus*, size_t framesToProcess) override;
+ void setClient(AudioSourceProviderClient*) override;
const AudioSourceProviderClient* client() const { return m_client; }
void handleNewDeinterleavePad(GstPad*);
Modified: trunk/Source/WebCore/platform/graphics/TextTrackRepresentation.cpp (209870 => 209871)
--- trunk/Source/WebCore/platform/graphics/TextTrackRepresentation.cpp 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/graphics/TextTrackRepresentation.cpp 2016-12-15 21:26:08 UTC (rev 209871)
@@ -36,10 +36,10 @@
class NullTextTrackRepresentation : public TextTrackRepresentation {
public:
virtual ~NullTextTrackRepresentation() { }
- virtual void update() { }
- virtual PlatformLayer* platformLayer() { return nullptr; }
- virtual void setContentScale(float) { }
- virtual IntRect bounds() const { return IntRect(); }
+ void update() override { }
+ PlatformLayer* platformLayer() override { return nullptr; }
+ void setContentScale(float) override { }
+ IntRect bounds() const override { return IntRect(); }
};
#if !(PLATFORM(IOS) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE)))
Modified: trunk/Source/WebCore/platform/graphics/displaylists/DisplayListItems.h (209870 => 209871)
--- trunk/Source/WebCore/platform/graphics/displaylists/DisplayListItems.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/graphics/displaylists/DisplayListItems.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -175,7 +175,7 @@
virtual std::optional<FloatRect> localBounds(const GraphicsContext&) const { return std::nullopt; }
private:
- virtual bool isDrawingItem() const { return true; }
+ bool isDrawingItem() const override { return true; }
std::optional<FloatRect> m_extent; // In base coordinates, taking shadows and transforms into account.
};
Modified: trunk/Source/WebCore/platform/graphics/filters/FEBlend.h (209870 => 209871)
--- trunk/Source/WebCore/platform/graphics/filters/FEBlend.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/graphics/filters/FEBlend.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -40,10 +40,10 @@
unsigned colorArrayLength);
void platformApplyNEON(unsigned char* srcPixelArrayA, unsigned char* srcPixelArrayB, unsigned char* dstPixelArray,
unsigned colorArrayLength);
- virtual void platformApplySoftware();
- virtual void dump();
+ void platformApplySoftware() override;
+ void dump() override;
- virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+ TextStream& externalRepresentation(TextStream&, int indention) const override;
private:
FEBlend(Filter&, BlendMode);
Modified: trunk/Source/WebCore/platform/graphics/filters/FEColorMatrix.h (209870 => 209871)
--- trunk/Source/WebCore/platform/graphics/filters/FEColorMatrix.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/graphics/filters/FEColorMatrix.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -47,10 +47,10 @@
const Vector<float>& values() const;
bool setValues(const Vector<float>&);
- virtual void platformApplySoftware();
- virtual void dump();
+ void platformApplySoftware() override;
+ void dump() override;
- virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+ TextStream& externalRepresentation(TextStream&, int indention) const override;
static inline void calculateSaturateComponents(float* components, float value);
static inline void calculateHueRotateComponents(float* components, float value);
Modified: trunk/Source/WebCore/platform/graphics/filters/FEComponentTransfer.h (209870 => 209871)
--- trunk/Source/WebCore/platform/graphics/filters/FEComponentTransfer.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/graphics/filters/FEComponentTransfer.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -77,10 +77,10 @@
ComponentTransferFunction alphaFunction() const;
void setAlphaFunction(const ComponentTransferFunction&);
- virtual void platformApplySoftware();
- virtual void dump();
+ void platformApplySoftware() override;
+ void dump() override;
- virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+ TextStream& externalRepresentation(TextStream&, int indention) const override;
private:
FEComponentTransfer(Filter&, const ComponentTransferFunction& redFunc, const ComponentTransferFunction& greenFunc,
Modified: trunk/Source/WebCore/platform/graphics/filters/FEConvolveMatrix.h (209870 => 209871)
--- trunk/Source/WebCore/platform/graphics/filters/FEConvolveMatrix.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/graphics/filters/FEConvolveMatrix.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -68,12 +68,12 @@
bool preserveAlpha() const;
bool setPreserveAlpha(bool);
- virtual void platformApplySoftware();
- virtual void dump();
+ void platformApplySoftware() override;
+ void dump() override;
- virtual void determineAbsolutePaintRect() { setAbsolutePaintRect(enclosingIntRect(maxEffectRect())); }
+ void determineAbsolutePaintRect() override { setAbsolutePaintRect(enclosingIntRect(maxEffectRect())); }
- virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+ TextStream& externalRepresentation(TextStream&, int indention) const override;
private:
Modified: trunk/Source/WebCore/platform/graphics/filters/FEDiffuseLighting.h (209870 => 209871)
--- trunk/Source/WebCore/platform/graphics/filters/FEDiffuseLighting.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/graphics/filters/FEDiffuseLighting.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -52,9 +52,9 @@
const LightSource* lightSource() const;
void setLightSource(PassRefPtr<LightSource>);
- virtual void dump();
+ void dump() override;
- virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+ TextStream& externalRepresentation(TextStream&, int indention) const override;
private:
FEDiffuseLighting(Filter&, const Color&, float, float, float, float, PassRefPtr<LightSource>);
Modified: trunk/Source/WebCore/platform/graphics/filters/FEDropShadow.h (209870 => 209871)
--- trunk/Source/WebCore/platform/graphics/filters/FEDropShadow.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/graphics/filters/FEDropShadow.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -48,12 +48,12 @@
float shadowOpacity() const { return m_shadowOpacity; }
void setShadowOpacity(float shadowOpacity) { m_shadowOpacity = shadowOpacity; }
- virtual void platformApplySoftware();
- virtual void dump();
+ void platformApplySoftware() override;
+ void dump() override;
- virtual void determineAbsolutePaintRect();
+ void determineAbsolutePaintRect() override;
- virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+ TextStream& externalRepresentation(TextStream&, int indention) const override;
private:
FEDropShadow(Filter&, float, float, float, float, const Color&, float);
Modified: trunk/Source/WebCore/platform/graphics/filters/FEGaussianBlur.h (209870 => 209871)
--- trunk/Source/WebCore/platform/graphics/filters/FEGaussianBlur.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/graphics/filters/FEGaussianBlur.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -41,14 +41,14 @@
EdgeModeType edgeMode() const;
void setEdgeMode(EdgeModeType);
- virtual void platformApplySoftware();
- virtual void dump();
+ void platformApplySoftware() override;
+ void dump() override;
- virtual void determineAbsolutePaintRect();
+ void determineAbsolutePaintRect() override;
static IntSize calculateKernelSize(const Filter&, const FloatPoint& stdDeviation);
static IntSize calculateUnscaledKernelSize(const FloatPoint& stdDeviation);
- virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+ TextStream& externalRepresentation(TextStream&, int indention) const override;
private:
static const int s_minimalRectDimension = 100 * 100; // Empirical data limit for parallel jobs
Modified: trunk/Source/WebCore/platform/graphics/filters/FELighting.h (209870 => 209871)
--- trunk/Source/WebCore/platform/graphics/filters/FELighting.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/graphics/filters/FELighting.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -43,9 +43,9 @@
class FELighting : public FilterEffect {
public:
- virtual void platformApplySoftware();
+ void platformApplySoftware() override;
- virtual void determineAbsolutePaintRect() { setAbsolutePaintRect(enclosingIntRect(maxEffectRect())); }
+ void determineAbsolutePaintRect() override { setAbsolutePaintRect(enclosingIntRect(maxEffectRect())); }
protected:
static const int s_minimalRectDimension = 100 * 100; // Empirical data limit for parallel jobs
Modified: trunk/Source/WebCore/platform/graphics/filters/FEMerge.h (209870 => 209871)
--- trunk/Source/WebCore/platform/graphics/filters/FEMerge.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/graphics/filters/FEMerge.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -31,10 +31,10 @@
public:
static Ref<FEMerge> create(Filter&);
- virtual void platformApplySoftware();
- virtual void dump();
+ void platformApplySoftware() override;
+ void dump() override;
- virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+ TextStream& externalRepresentation(TextStream&, int indention) const override;
private:
FEMerge(Filter&);
Modified: trunk/Source/WebCore/platform/graphics/filters/FEMorphology.h (209870 => 209871)
--- trunk/Source/WebCore/platform/graphics/filters/FEMorphology.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/graphics/filters/FEMorphology.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -46,12 +46,12 @@
float radiusY() const { return m_radiusY; }
bool setRadiusY(float);
- virtual void platformApplySoftware();
- virtual void dump();
+ void platformApplySoftware() override;
+ void dump() override;
- virtual void determineAbsolutePaintRect();
+ void determineAbsolutePaintRect() override;
- virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+ TextStream& externalRepresentation(TextStream&, int indention) const override;
struct PaintingData {
Uint8ClampedArray* srcPixelArray;
Modified: trunk/Source/WebCore/platform/graphics/filters/FEOffset.h (209870 => 209871)
--- trunk/Source/WebCore/platform/graphics/filters/FEOffset.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/graphics/filters/FEOffset.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -37,12 +37,12 @@
float dy() const;
void setDy(float);
- virtual void platformApplySoftware();
- virtual void dump();
+ void platformApplySoftware() override;
+ void dump() override;
- virtual void determineAbsolutePaintRect();
+ void determineAbsolutePaintRect() override;
- virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+ TextStream& externalRepresentation(TextStream&, int indention) const override;
private:
FEOffset(Filter&, float dx, float dy);
Modified: trunk/Source/WebCore/platform/graphics/filters/FESpecularLighting.h (209870 => 209871)
--- trunk/Source/WebCore/platform/graphics/filters/FESpecularLighting.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/graphics/filters/FESpecularLighting.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -53,9 +53,9 @@
const LightSource* lightSource() const;
void setLightSource(PassRefPtr<LightSource>);
- virtual void dump();
+ void dump() override;
- virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+ TextStream& externalRepresentation(TextStream&, int indention) const override;
private:
FESpecularLighting(Filter&, const Color&, float, float, float, float, float, PassRefPtr<LightSource>);
Modified: trunk/Source/WebCore/platform/graphics/filters/FETile.h (209870 => 209871)
--- trunk/Source/WebCore/platform/graphics/filters/FETile.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/graphics/filters/FETile.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -31,14 +31,14 @@
public:
static Ref<FETile> create(Filter&);
- virtual void platformApplySoftware();
- virtual void dump();
+ void platformApplySoftware() override;
+ void dump() override;
- virtual void determineAbsolutePaintRect() { setAbsolutePaintRect(enclosingIntRect(maxEffectRect())); }
+ void determineAbsolutePaintRect() override { setAbsolutePaintRect(enclosingIntRect(maxEffectRect())); }
- virtual FilterEffectType filterEffectType() const { return FilterEffectTypeTile; }
+ FilterEffectType filterEffectType() const override { return FilterEffectTypeTile; }
- virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+ TextStream& externalRepresentation(TextStream&, int indention) const override;
private:
FETile(Filter&);
Modified: trunk/Source/WebCore/platform/graphics/filters/FETurbulence.h (209870 => 209871)
--- trunk/Source/WebCore/platform/graphics/filters/FETurbulence.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/graphics/filters/FETurbulence.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -59,12 +59,12 @@
static void fillRegionWorker(void*);
- virtual void platformApplySoftware();
- virtual void dump();
+ void platformApplySoftware() override;
+ void dump() override;
- virtual void determineAbsolutePaintRect() { setAbsolutePaintRect(enclosingIntRect(maxEffectRect())); }
+ void determineAbsolutePaintRect() override { setAbsolutePaintRect(enclosingIntRect(maxEffectRect())); }
- virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+ TextStream& externalRepresentation(TextStream&, int indention) const override;
private:
static const int s_blockSize = 256;
Modified: trunk/Source/WebCore/platform/graphics/filters/SourceAlpha.h (209870 => 209871)
--- trunk/Source/WebCore/platform/graphics/filters/SourceAlpha.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/graphics/filters/SourceAlpha.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -31,14 +31,14 @@
static const AtomicString& effectName();
- virtual void platformApplySoftware();
- virtual void dump();
+ void platformApplySoftware() override;
+ void dump() override;
- virtual void determineAbsolutePaintRect();
+ void determineAbsolutePaintRect() override;
- virtual FilterEffectType filterEffectType() const { return FilterEffectTypeSourceInput; }
+ FilterEffectType filterEffectType() const override { return FilterEffectTypeSourceInput; }
- virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+ TextStream& externalRepresentation(TextStream&, int indention) const override;
private:
explicit SourceAlpha(FilterEffect&);
Modified: trunk/Source/WebCore/platform/graphics/filters/SourceGraphic.h (209870 => 209871)
--- trunk/Source/WebCore/platform/graphics/filters/SourceGraphic.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/graphics/filters/SourceGraphic.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -32,14 +32,14 @@
static const AtomicString& effectName();
- virtual void platformApplySoftware();
- virtual void dump();
+ void platformApplySoftware() override;
+ void dump() override;
- virtual void determineAbsolutePaintRect();
+ void determineAbsolutePaintRect() override;
- virtual FilterEffectType filterEffectType() const { return FilterEffectTypeSourceInput; }
+ FilterEffectType filterEffectType() const override { return FilterEffectTypeSourceInput; }
- virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+ TextStream& externalRepresentation(TextStream&, int indention) const override;
private:
SourceGraphic(Filter& filter)
Modified: trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.h (209870 => 209871)
--- trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -41,25 +41,25 @@
virtual ~Extensions3DOpenGL();
// Extensions3D methods.
- virtual void blitFramebuffer(long srcX0, long srcY0, long srcX1, long srcY1, long dstX0, long dstY0, long dstX1, long dstY1, unsigned long mask, unsigned long filter);
- virtual void renderbufferStorageMultisample(unsigned long target, unsigned long samples, unsigned long internalformat, unsigned long width, unsigned long height);
+ void blitFramebuffer(long srcX0, long srcY0, long srcX1, long srcY1, long dstX0, long dstY0, long dstX1, long dstY1, unsigned long mask, unsigned long filter) override;
+ void renderbufferStorageMultisample(unsigned long target, unsigned long samples, unsigned long internalformat, unsigned long width, unsigned long height) override;
- virtual Platform3DObject createVertexArrayOES();
- virtual void deleteVertexArrayOES(Platform3DObject);
- virtual GC3Dboolean isVertexArrayOES(Platform3DObject);
- virtual void bindVertexArrayOES(Platform3DObject);
- virtual void insertEventMarkerEXT(const String&);
- virtual void pushGroupMarkerEXT(const String&);
- virtual void popGroupMarkerEXT(void);
- virtual void drawBuffersEXT(GC3Dsizei, const GC3Denum*);
+ Platform3DObject createVertexArrayOES() override;
+ void deleteVertexArrayOES(Platform3DObject) override;
+ GC3Dboolean isVertexArrayOES(Platform3DObject) override;
+ void bindVertexArrayOES(Platform3DObject) override;
+ void insertEventMarkerEXT(const String&) override;
+ void pushGroupMarkerEXT(const String&) override;
+ void popGroupMarkerEXT(void) override;
+ void drawBuffersEXT(GC3Dsizei, const GC3Denum*) override;
- virtual void drawArraysInstanced(GC3Denum mode, GC3Dint first, GC3Dsizei count, GC3Dsizei primcount);
- virtual void drawElementsInstanced(GC3Denum mode, GC3Dsizei count, GC3Denum type, long long offset, GC3Dsizei primcount);
- virtual void vertexAttribDivisor(GC3Duint index, GC3Duint divisor);
+ void drawArraysInstanced(GC3Denum mode, GC3Dint first, GC3Dsizei count, GC3Dsizei primcount) override;
+ void drawElementsInstanced(GC3Denum mode, GC3Dsizei count, GC3Denum type, long long offset, GC3Dsizei primcount) override;
+ void vertexAttribDivisor(GC3Duint index, GC3Duint divisor) override;
protected:
- virtual bool supportsExtension(const WTF::String&);
- virtual String getExtensions();
+ bool supportsExtension(const WTF::String&) override;
+ String getExtensions() override;
private:
#if (PLATFORM(GTK) || PLATFORM(EFL) || PLATFORM(WIN) || PLATFORM(IOS))
Modified: trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.h (209870 => 209871)
--- trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -39,33 +39,33 @@
virtual ~Extensions3DOpenGLCommon();
// Extensions3D methods.
- virtual bool supports(const String&);
- virtual void ensureEnabled(const String&);
- virtual bool isEnabled(const String&);
- virtual int getGraphicsResetStatusARB();
+ bool supports(const String&) override;
+ void ensureEnabled(const String&) override;
+ bool isEnabled(const String&) override;
+ int getGraphicsResetStatusARB() override;
- virtual Platform3DObject createVertexArrayOES() = 0;
- virtual void deleteVertexArrayOES(Platform3DObject) = 0;
- virtual GC3Dboolean isVertexArrayOES(Platform3DObject) = 0;
- virtual void bindVertexArrayOES(Platform3DObject) = 0;
+ Platform3DObject createVertexArrayOES() override = 0;
+ void deleteVertexArrayOES(Platform3DObject) override = 0;
+ GC3Dboolean isVertexArrayOES(Platform3DObject) override = 0;
+ void bindVertexArrayOES(Platform3DObject) override = 0;
- virtual void drawBuffersEXT(GC3Dsizei, const GC3Denum*) = 0;
+ void drawBuffersEXT(GC3Dsizei, const GC3Denum*) override = 0;
- virtual String getTranslatedShaderSourceANGLE(Platform3DObject);
+ String getTranslatedShaderSourceANGLE(Platform3DObject) override;
// EXT Robustness - uses getGraphicsResetStatusARB()
- virtual void readnPixelsEXT(int x, int y, GC3Dsizei width, GC3Dsizei height, GC3Denum format, GC3Denum type, GC3Dsizei bufSize, void *data);
- virtual void getnUniformfvEXT(GC3Duint program, int location, GC3Dsizei bufSize, float *params);
- virtual void getnUniformivEXT(GC3Duint program, int location, GC3Dsizei bufSize, int *params);
+ void readnPixelsEXT(int x, int y, GC3Dsizei width, GC3Dsizei height, GC3Denum format, GC3Denum type, GC3Dsizei bufSize, void *data) override;
+ void getnUniformfvEXT(GC3Duint program, int location, GC3Dsizei bufSize, float *params) override;
+ void getnUniformivEXT(GC3Duint program, int location, GC3Dsizei bufSize, int *params) override;
- virtual bool isNVIDIA() { return m_isNVIDIA; }
- virtual bool isAMD() { return m_isAMD; }
- virtual bool isIntel() { return m_isIntel; }
- virtual bool isImagination() { return m_isImagination; }
- virtual String vendor() { return m_vendor; }
+ bool isNVIDIA() override { return m_isNVIDIA; }
+ bool isAMD() override { return m_isAMD; }
+ bool isIntel() override { return m_isIntel; }
+ bool isImagination() override { return m_isImagination; }
+ String vendor() override { return m_vendor; }
- virtual bool requiresBuiltInFunctionEmulation() { return m_requiresBuiltInFunctionEmulation; }
- virtual bool requiresRestrictedMaximumTextureSize() { return m_requiresRestrictedMaximumTextureSize; }
+ bool requiresBuiltInFunctionEmulation() override { return m_requiresBuiltInFunctionEmulation; }
+ bool requiresRestrictedMaximumTextureSize() override { return m_requiresRestrictedMaximumTextureSize; }
protected:
friend class Extensions3DOpenGLES;
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.h (209870 => 209871)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -37,7 +37,7 @@
class TextureMapperBackingStore : public TextureMapperPlatformLayer, public RefCounted<TextureMapperBackingStore> {
public:
virtual RefPtr<BitmapTexture> texture() const = 0;
- virtual void paintToTextureMapper(TextureMapper&, const FloatRect&, const TransformationMatrix&, float) = 0;
+ void paintToTextureMapper(TextureMapper&, const FloatRect&, const TransformationMatrix&, float) override = 0;
virtual void drawRepaintCounter(TextureMapper&, int /* repaintCount */, const Color&, const FloatRect&, const TransformationMatrix&) { }
virtual ~TextureMapperBackingStore() { }
Modified: trunk/Source/WebCore/platform/mediastream/openwebrtc/RealtimeMediaSourceOwr.h (209870 => 209871)
--- trunk/Source/WebCore/platform/mediastream/openwebrtc/RealtimeMediaSourceOwr.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/mediastream/openwebrtc/RealtimeMediaSourceOwr.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -72,8 +72,8 @@
setMuted(false);
}
- virtual RefPtr<RealtimeMediaSourceCapabilities> capabilities() const { return m_capabilities; }
- virtual const RealtimeMediaSourceSettings& settings() const;
+ RefPtr<RealtimeMediaSourceCapabilities> capabilities() const override { return m_capabilities; }
+ const RealtimeMediaSourceSettings& settings() const override;
OwrMediaSource* mediaSource() const { return m_mediaSource; }
Modified: trunk/Source/WebCore/platform/mock/GeolocationClientMock.h (209870 => 209871)
--- trunk/Source/WebCore/platform/mock/GeolocationClientMock.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/mock/GeolocationClientMock.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -60,13 +60,13 @@
int numberOfPendingPermissionRequests() const;
// GeolocationClient
- virtual void geolocationDestroyed();
- virtual void startUpdating();
- virtual void stopUpdating();
- virtual void setEnableHighAccuracy(bool);
- virtual GeolocationPosition* lastPosition();
- virtual void requestPermission(Geolocation*);
- virtual void cancelPermissionRequest(Geolocation*);
+ void geolocationDestroyed() override;
+ void startUpdating() override;
+ void stopUpdating() override;
+ void setEnableHighAccuracy(bool) override;
+ GeolocationPosition* lastPosition() override;
+ void requestPermission(Geolocation*) override;
+ void cancelPermissionRequest(Geolocation*) override;
private:
void asyncUpdateController();
Modified: trunk/Source/WebCore/platform/text/TextCodecICU.h (209870 => 209871)
--- trunk/Source/WebCore/platform/text/TextCodecICU.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/text/TextCodecICU.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -46,8 +46,8 @@
virtual ~TextCodecICU();
private:
- virtual String decode(const char*, size_t length, bool flush, bool stopOnError, bool& sawError);
- virtual CString encode(const UChar*, size_t length, UnencodableHandling);
+ String decode(const char*, size_t length, bool flush, bool stopOnError, bool& sawError) override;
+ CString encode(const UChar*, size_t length, UnencodableHandling) override;
void createICUConverter() const;
void releaseICUConverter() const;
Modified: trunk/Source/WebCore/platform/text/TextCodecLatin1.h (209870 => 209871)
--- trunk/Source/WebCore/platform/text/TextCodecLatin1.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/text/TextCodecLatin1.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -35,8 +35,8 @@
static void registerEncodingNames(EncodingNameRegistrar);
static void registerCodecs(TextCodecRegistrar);
- virtual String decode(const char*, size_t length, bool flush, bool stopOnError, bool& sawError);
- virtual CString encode(const UChar*, size_t length, UnencodableHandling);
+ String decode(const char*, size_t length, bool flush, bool stopOnError, bool& sawError) override;
+ CString encode(const UChar*, size_t length, UnencodableHandling) override;
};
} // namespace WebCore
Modified: trunk/Source/WebCore/platform/text/TextCodecUTF16.h (209870 => 209871)
--- trunk/Source/WebCore/platform/text/TextCodecUTF16.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/text/TextCodecUTF16.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -37,8 +37,8 @@
TextCodecUTF16(bool littleEndian) : m_littleEndian(littleEndian), m_haveBufferedByte(false) { }
- virtual String decode(const char*, size_t length, bool flush, bool stopOnError, bool& sawError);
- virtual CString encode(const UChar*, size_t length, UnencodableHandling);
+ String decode(const char*, size_t length, bool flush, bool stopOnError, bool& sawError) override;
+ CString encode(const UChar*, size_t length, UnencodableHandling) override;
private:
bool m_littleEndian;
Modified: trunk/Source/WebCore/platform/text/TextCodecUTF8.h (209870 => 209871)
--- trunk/Source/WebCore/platform/text/TextCodecUTF8.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/text/TextCodecUTF8.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -42,8 +42,8 @@
static void registerCodecs(TextCodecRegistrar);
private:
- virtual String decode(const char*, size_t length, bool flush, bool stopOnError, bool& sawError);
- virtual CString encode(const UChar*, size_t length, UnencodableHandling);
+ String decode(const char*, size_t length, bool flush, bool stopOnError, bool& sawError) override;
+ CString encode(const UChar*, size_t length, UnencodableHandling) override;
template <typename CharType>
bool handlePartialSequence(CharType*& destination, const uint8_t*& source, const uint8_t* end, bool flush, bool stopOnError, bool& sawError);
Modified: trunk/Source/WebCore/platform/text/TextCodecUserDefined.h (209870 => 209871)
--- trunk/Source/WebCore/platform/text/TextCodecUserDefined.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/platform/text/TextCodecUserDefined.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -35,8 +35,8 @@
static void registerEncodingNames(EncodingNameRegistrar);
static void registerCodecs(TextCodecRegistrar);
- virtual String decode(const char*, size_t length, bool flush, bool stopOnError, bool& sawError);
- virtual CString encode(const UChar*, size_t length, UnencodableHandling);
+ String decode(const char*, size_t length, bool flush, bool stopOnError, bool& sawError) override;
+ CString encode(const UChar*, size_t length, UnencodableHandling) override;
};
} // namespace WebCore
Modified: trunk/Source/WebCore/rendering/RenderFullScreen.cpp (209870 => 209871)
--- trunk/Source/WebCore/rendering/RenderFullScreen.cpp 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/rendering/RenderFullScreen.cpp 2016-12-15 21:26:08 UTC (rev 209871)
@@ -43,8 +43,8 @@
}
private:
- virtual bool isRenderFullScreenPlaceholder() const { return true; }
- virtual void willBeDestroyed();
+ bool isRenderFullScreenPlaceholder() const override { return true; }
+ void willBeDestroyed() override;
RenderFullScreen& m_owner;
};
Modified: trunk/Source/WebCore/storage/StorageEvent.h (209870 => 209871)
--- trunk/Source/WebCore/storage/StorageEvent.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/storage/StorageEvent.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -59,7 +59,7 @@
// Needed once we support init<blank>EventNS
// void initStorageEventNS(in DOMString namespaceURI, in DOMString typeArg, in boolean canBubbleArg, in boolean cancelableArg, in DOMString keyArg, in DOMString oldValueArg, in DOMString newValueArg, in DOMString urlArg, Storage storageAreaArg);
- virtual EventInterface eventInterface() const;
+ EventInterface eventInterface() const override;
private:
StorageEvent();
Modified: trunk/Source/WebCore/svg/properties/SVGListProperty.h (209870 => 209871)
--- trunk/Source/WebCore/svg/properties/SVGListProperty.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/svg/properties/SVGListProperty.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -470,7 +470,7 @@
delete m_values;
}
- virtual void commitChange() = 0;
+ void commitChange() override = 0;
virtual void commitChange(ListModification)
{
commitChange();
Modified: trunk/Source/WebCore/svg/properties/SVGStaticListPropertyTearOff.h (209870 => 209871)
--- trunk/Source/WebCore/svg/properties/SVGStaticListPropertyTearOff.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/svg/properties/SVGStaticListPropertyTearOff.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -82,24 +82,24 @@
{
}
- virtual bool isReadOnly() const
+ bool isReadOnly() const override
{
return m_role == AnimValRole;
}
- virtual void commitChange()
+ void commitChange() override
{
ASSERT(m_values);
m_values->commitChange(m_contextElement);
}
- virtual bool processIncomingListItemValue(const ListItemType&, unsigned*)
+ bool processIncomingListItemValue(const ListItemType&, unsigned*) override
{
// no-op for static lists
return true;
}
- virtual bool processIncomingListItemWrapper(Ref<ListItemTearOff>&, unsigned*)
+ bool processIncomingListItemWrapper(Ref<ListItemTearOff>&, unsigned*) override
{
ASSERT_NOT_REACHED();
return true;
Modified: trunk/Source/WebCore/svg/properties/SVGStaticPropertyTearOff.h (209870 => 209871)
--- trunk/Source/WebCore/svg/properties/SVGStaticPropertyTearOff.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/svg/properties/SVGStaticPropertyTearOff.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -41,7 +41,7 @@
return adoptRef(*new Self(contextElement, value, update));
}
- virtual void commitChange() { (m_contextElement.get()->*m_update)(); }
+ void commitChange() final { (m_contextElement.get()->*m_update)(); }
private:
SVGStaticPropertyTearOff(ContextElement& contextElement, PropertyType& value, UpdateMethod update)
Modified: trunk/Source/WebCore/xml/NativeXPathNSResolver.h (209870 => 209871)
--- trunk/Source/WebCore/xml/NativeXPathNSResolver.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/xml/NativeXPathNSResolver.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -37,7 +37,7 @@
static Ref<NativeXPathNSResolver> create(RefPtr<Node>&& node) { return adoptRef(*new NativeXPathNSResolver(WTFMove(node))); }
virtual ~NativeXPathNSResolver();
- virtual String lookupNamespaceURI(const String& prefix);
+ String lookupNamespaceURI(const String& prefix) override;
private:
explicit NativeXPathNSResolver(RefPtr<Node>&&);
Modified: trunk/Source/WebCore/xml/XMLHttpRequestProgressEvent.h (209870 => 209871)
--- trunk/Source/WebCore/xml/XMLHttpRequestProgressEvent.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/xml/XMLHttpRequestProgressEvent.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -40,7 +40,7 @@
unsigned long long position() const { return loaded(); }
unsigned long long totalSize() const { return total(); }
- virtual EventInterface eventInterface() const { return XMLHttpRequestProgressEventInterfaceType; }
+ EventInterface eventInterface() const override { return XMLHttpRequestProgressEventInterfaceType; }
private:
XMLHttpRequestProgressEvent(const AtomicString& type, bool lengthComputable, unsigned long long loaded, unsigned long long total)
Modified: trunk/Source/WebCore/xml/XMLHttpRequestProgressEventThrottle.h (209870 => 209871)
--- trunk/Source/WebCore/xml/XMLHttpRequestProgressEventThrottle.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/xml/XMLHttpRequestProgressEventThrottle.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -57,7 +57,7 @@
private:
static const double minimumProgressEventDispatchingIntervalInSeconds;
- virtual void fired();
+ void fired() override;
void dispatchDeferredEvents();
void flushProgressEvent();
void dispatchEvent(Event&);
Modified: trunk/Source/WebCore/xml/XPathVariableReference.h (209870 => 209871)
--- trunk/Source/WebCore/xml/XPathVariableReference.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/xml/XPathVariableReference.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -35,8 +35,8 @@
public:
explicit VariableReference(const String& name);
private:
- virtual Value evaluate() const;
- virtual Value::Type resultType() const { ASSERT_NOT_REACHED(); return Value::NumberValue; }
+ Value evaluate() const override;
+ Value::Type resultType() const override { ASSERT_NOT_REACHED(); return Value::NumberValue; }
String m_name;
};
Modified: trunk/Source/WebCore/xml/XSLImportRule.h (209870 => 209871)
--- trunk/Source/WebCore/xml/XSLImportRule.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebCore/xml/XSLImportRule.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -48,7 +48,7 @@
void loadSheet();
private:
- virtual void setXSLStyleSheet(const String& href, const URL& baseURL, const String& sheet);
+ void setXSLStyleSheet(const String& href, const URL& baseURL, const String& sheet) override;
XSLStyleSheet* m_parentStyleSheet;
String m_strHref;
Modified: trunk/Source/WebKit2/ChangeLog (209870 => 209871)
--- trunk/Source/WebKit2/ChangeLog 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebKit2/ChangeLog 2016-12-15 21:26:08 UTC (rev 209871)
@@ -1,3 +1,21 @@
+2016-12-15 Konstantin Tokarev <[email protected]>
+
+ Added missing override and final specifiers
+ https://bugs.webkit.org/show_bug.cgi?id=165903
+
+ Reviewed by Darin Adler.
+
+ * UIProcess/API/gtk/WebKitGeolocationProvider.h:
+ * UIProcess/WebFormSubmissionListenerProxy.h:
+ * UIProcess/WebFramePolicyListenerProxy.h:
+ * WebProcess/Automation/WebAutomationSessionProxy.h:
+ * WebProcess/InjectedBundle/API/gtk/DOM/GObjectXPathNSResolver.h:
+ * WebProcess/MediaCache/WebMediaKeyStorageManager.h:
+ * WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
+ * WebProcess/WebCoreSupport/WebPlugInClient.h:
+ * WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
+ * WebProcess/WebPage/FindController.h:
+
2016-12-15 Simon Fraser <[email protected]>
[iOS WK2] Don't disable position:fixed when a form element has focus
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitGeolocationProvider.h (209870 => 209871)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitGeolocationProvider.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitGeolocationProvider.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -42,8 +42,8 @@
WebKitGeolocationProvider(WebGeolocationManagerProxy*);
// GeolocationProviderGeoclueClient interface.
- virtual void notifyPositionChanged(int, double, double, double, double, double);
- virtual void notifyErrorOccurred(const char*);
+ void notifyPositionChanged(int, double, double, double, double, double) override;
+ void notifyErrorOccurred(const char*) override;
RefPtr<WebGeolocationManagerProxy> m_geolocationManager;
WebCore::GeolocationProviderGeoclue m_provider;
Modified: trunk/Source/WebKit2/UIProcess/WebFormSubmissionListenerProxy.h (209870 => 209871)
--- trunk/Source/WebKit2/UIProcess/WebFormSubmissionListenerProxy.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebKit2/UIProcess/WebFormSubmissionListenerProxy.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -52,7 +52,7 @@
private:
WebFormSubmissionListenerProxy(WebFrameProxy*, uint64_t listenerID);
- virtual Type type() const { return APIType; }
+ Type type() const override { return APIType; }
#if DELEGATE_REF_COUNTING_TO_COCOA
void* operator new(size_t size) { return newObject(size, APIType); }
Modified: trunk/Source/WebKit2/UIProcess/WebFramePolicyListenerProxy.h (209870 => 209871)
--- trunk/Source/WebKit2/UIProcess/WebFramePolicyListenerProxy.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebKit2/UIProcess/WebFramePolicyListenerProxy.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -51,7 +51,7 @@
private:
WebFramePolicyListenerProxy(WebFrameProxy*, uint64_t listenerID);
- virtual Type type() const { return APIType; }
+ Type type() const override { return APIType; }
#if DELEGATE_REF_COUNTING_TO_COCOA
void* operator new(size_t size) { return newObject(size, APIType); }
Modified: trunk/Source/WebKit2/WebProcess/Automation/WebAutomationSessionProxy.h (209870 => 209871)
--- trunk/Source/WebKit2/WebProcess/Automation/WebAutomationSessionProxy.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebKit2/WebProcess/Automation/WebAutomationSessionProxy.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -55,7 +55,7 @@
WebCore::Element* elementForNodeHandle(WebFrame&, const String&);
// Implemented in generated WebAutomationSessionProxyMessageReceiver.cpp
- void didReceiveMessage(IPC::Connection&, IPC::Decoder&);
+ void didReceiveMessage(IPC::Connection&, IPC::Decoder&) override;
// Called by WebAutomationSessionProxy messages
void evaluateJavaScriptFunction(uint64_t pageID, uint64_t frameID, const String& function, Vector<String> arguments, bool expectsImplicitCallbackArgument, int callbackTimeout, uint64_t callbackID);
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/GObjectXPathNSResolver.h (209870 => 209871)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/GObjectXPathNSResolver.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/GObjectXPathNSResolver.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -33,7 +33,7 @@
}
virtual ~GObjectXPathNSResolver();
- virtual String lookupNamespaceURI(const String& prefix);
+ String lookupNamespaceURI(const String& prefix) override;
private:
GObjectXPathNSResolver(WebKitDOMXPathNSResolver* resolver)
Modified: trunk/Source/WebKit2/WebProcess/MediaCache/WebMediaKeyStorageManager.h (209870 => 209871)
--- trunk/Source/WebKit2/WebProcess/MediaCache/WebMediaKeyStorageManager.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebKit2/WebProcess/MediaCache/WebMediaKeyStorageManager.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -55,7 +55,7 @@
void deleteAllMediaKeyEntries();
private:
- virtual void initialize(const WebProcessCreationParameters&);
+ void initialize(const WebProcessCreationParameters&) override;
String m_mediaKeyStorageDirectory;
};
Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h (209870 => 209871)
--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -90,7 +90,7 @@
private:
// WeakHandleOwner
- virtual void finalize(JSC::Handle<JSC::Unknown>, void* context);
+ void finalize(JSC::Handle<JSC::Unknown>, void* context) override;
void addToInvalidationQueue(NPObject*);
void invalidateQueuedObjects();
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPlugInClient.h (209870 => 209871)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPlugInClient.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPlugInClient.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -39,9 +39,9 @@
virtual ~WebPlugInClient();
private:
- virtual void pageDestroyed();
- virtual bool shouldAutoStartFromOrigin(const String& pageOrigin, const String& pluginOrigin, const String& mimeType);
- virtual void didStartFromOrigin(const String& pageOrigin, const String& pluginOrigin, const String& mimeType, WebCore::SessionID);
+ void pageDestroyed() override;
+ bool shouldAutoStartFromOrigin(const String& pageOrigin, const String& pluginOrigin, const String& mimeType) override;
+ void didStartFromOrigin(const String& pageOrigin, const String& pluginOrigin, const String& mimeType, WebCore::SessionID) override;
WebPage& m_webPage;
};
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h (209870 => 209871)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -52,7 +52,7 @@
private:
WebFrameNetworkingContext(WebFrame*);
- virtual WebCore::NetworkStorageSession& storageSession() const;
+ WebCore::NetworkStorageSession& storageSession() const override;
};
}
Modified: trunk/Source/WebKit2/WebProcess/WebPage/FindController.h (209870 => 209871)
--- trunk/Source/WebKit2/WebProcess/WebPage/FindController.h 2016-12-15 21:08:40 UTC (rev 209870)
+++ trunk/Source/WebKit2/WebProcess/WebPage/FindController.h 2016-12-15 21:26:08 UTC (rev 209871)
@@ -73,10 +73,10 @@
private:
// PageOverlay::Client.
- virtual void willMoveToPage(WebCore::PageOverlay&, WebCore::Page*);
- virtual void didMoveToPage(WebCore::PageOverlay&, WebCore::Page*);
- virtual bool mouseEvent(WebCore::PageOverlay&, const WebCore::PlatformMouseEvent&);
- virtual void drawRect(WebCore::PageOverlay&, WebCore::GraphicsContext&, const WebCore::IntRect& dirtyRect);
+ void willMoveToPage(WebCore::PageOverlay&, WebCore::Page*) override;
+ void didMoveToPage(WebCore::PageOverlay&, WebCore::Page*) override;
+ bool mouseEvent(WebCore::PageOverlay&, const WebCore::PlatformMouseEvent&) override;
+ void drawRect(WebCore::PageOverlay&, WebCore::GraphicsContext&, const WebCore::IntRect& dirtyRect) override;
Vector<WebCore::IntRect> rectsForTextMatchesInRect(WebCore::IntRect clipRect);
bool updateFindIndicator(WebCore::Frame& selectedFrame, bool isShowingOverlay, bool shouldAnimate = true);
