Title: [210037] trunk/Source/WebCore
- Revision
- 210037
- Author
- [email protected]
- Date
- 2016-12-20 14:16:11 -0800 (Tue, 20 Dec 2016)
Log Message
[WebIDL] Remove custom binding for WorkerGlobalScope::importScripts
https://bugs.webkit.org/show_bug.cgi?id=166243
Reviewed by Alex Christensen.
* bindings/js/JSWorkerGlobalScopeCustom.cpp:
(WebCore::JSWorkerGlobalScope::importScripts): Deleted.
* workers/WorkerGlobalScope.idl:
Import scripts can now be trivially generated.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (210036 => 210037)
--- trunk/Source/WebCore/ChangeLog 2016-12-20 21:57:22 UTC (rev 210036)
+++ trunk/Source/WebCore/ChangeLog 2016-12-20 22:16:11 UTC (rev 210037)
@@ -1,3 +1,15 @@
+2016-12-20 Sam Weinig <[email protected]>
+
+ [WebIDL] Remove custom binding for WorkerGlobalScope::importScripts
+ https://bugs.webkit.org/show_bug.cgi?id=166243
+
+ Reviewed by Alex Christensen.
+
+ * bindings/js/JSWorkerGlobalScopeCustom.cpp:
+ (WebCore::JSWorkerGlobalScope::importScripts): Deleted.
+ * workers/WorkerGlobalScope.idl:
+ Import scripts can now be trivially generated.
+
2016-12-20 Zalan Bujtas <[email protected]>
SVG elements should inherit the root's flow thread state.
Modified: trunk/Source/WebCore/bindings/js/JSWorkerGlobalScopeCustom.cpp (210036 => 210037)
--- trunk/Source/WebCore/bindings/js/JSWorkerGlobalScopeCustom.cpp 2016-12-20 21:57:22 UTC (rev 210036)
+++ trunk/Source/WebCore/bindings/js/JSWorkerGlobalScopeCustom.cpp 2016-12-20 22:16:11 UTC (rev 210037)
@@ -44,25 +44,6 @@
visitor.addOpaqueRoot(&context);
}
-JSValue JSWorkerGlobalScope::importScripts(ExecState& state)
-{
- VM& vm = state.vm();
- auto scope = DECLARE_THROW_SCOPE(vm);
-
- if (!state.argumentCount())
- return jsUndefined();
-
- Vector<String> urls;
- urls.reserveInitialCapacity(state.argumentCount());
- for (unsigned i = 0; i < state.argumentCount(); ++i) {
- urls.uncheckedAppend(convert<IDLUSVString>(state, state.uncheckedArgument(i)));
- RETURN_IF_EXCEPTION(scope, JSValue());
- }
-
- propagateException(state, scope, wrapped().importScripts(urls));
- return jsUndefined();
-}
-
JSValue JSWorkerGlobalScope::setTimeout(ExecState& state)
{
VM& vm = state.vm();
Modified: trunk/Source/WebCore/workers/WorkerGlobalScope.idl (210036 => 210037)
--- trunk/Source/WebCore/workers/WorkerGlobalScope.idl 2016-12-20 21:57:22 UTC (rev 210036)
+++ trunk/Source/WebCore/workers/WorkerGlobalScope.idl 2016-12-20 22:16:11 UTC (rev 210037)
@@ -40,7 +40,7 @@
// WorkerUtils
- [Custom] void importScripts(/*[Variadic] USVString urls */);
+ [MayThrowException] void importScripts(USVString... urls);
readonly attribute WorkerNavigator navigator;
// Additional constructors
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
