Title: [210082] trunk/Tools
- Revision
- 210082
- Author
- [email protected]
- Date
- 2016-12-21 15:58:46 -0800 (Wed, 21 Dec 2016)
Log Message
REGRESSION: API test failure: _WKDownload.OriginatingWebView
https://bugs.webkit.org/show_bug.cgi?id=166033
<rdar://problem/29758428>
Reviewed by Simon Fraser.
Add an @autoreleasepool around the code that allocates the WKWebView,
so that it can be destroyed by removing the last reference in _downloadDidStart.
* TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
(TEST):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (210081 => 210082)
--- trunk/Tools/ChangeLog 2016-12-21 23:33:37 UTC (rev 210081)
+++ trunk/Tools/ChangeLog 2016-12-21 23:58:46 UTC (rev 210082)
@@ -1,3 +1,17 @@
+2016-12-21 Alexey Proskuryakov <[email protected]>
+
+ REGRESSION: API test failure: _WKDownload.OriginatingWebView
+ https://bugs.webkit.org/show_bug.cgi?id=166033
+ <rdar://problem/29758428>
+
+ Reviewed by Simon Fraser.
+
+ Add an @autoreleasepool around the code that allocates the WKWebView,
+ so that it can be destroyed by removing the last reference in _downloadDidStart.
+
+ * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
+ (TEST):
+
2016-12-21 Daniel Bates <[email protected]>
WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm (210081 => 210082)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm 2016-12-21 23:33:37 UTC (rev 210081)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm 2016-12-21 23:58:46 UTC (rev 210082)
@@ -257,7 +257,7 @@
{
RetainPtr<DownloadNavigationDelegate> navigationDelegate = adoptNS([[DownloadNavigationDelegate alloc] init]);
RetainPtr<OriginatingWebViewDownloadDelegate> downloadDelegate;
- {
+ @autoreleasepool {
RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600)]);
[webView setNavigationDelegate:navigationDelegate.get()];
downloadDelegate = adoptNS([[OriginatingWebViewDownloadDelegate alloc] initWithWebView:webView.get()]);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
