Title: [210093] trunk/Tools
- Revision
- 210093
- Author
- [email protected]
- Date
- 2016-12-21 17:57:24 -0800 (Wed, 21 Dec 2016)
Log Message
REGRESSION: API test failure: WKWebView.LocalStorageClear
https://bugs.webkit.org/show_bug.cgi?id=166032
<rdar://problem/29758423>
Reviewed by Simon Fraser.
Add an @autoreleasepool around the code that allocates then clears the WKWebView,
to ensure that the view is destroyed before the callback fires.
* TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
(TEST):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (210092 => 210093)
--- trunk/Tools/ChangeLog 2016-12-22 01:41:51 UTC (rev 210092)
+++ trunk/Tools/ChangeLog 2016-12-22 01:57:24 UTC (rev 210093)
@@ -1,3 +1,17 @@
+2016-12-21 Alexey Proskuryakov <[email protected]>
+
+ REGRESSION: API test failure: WKWebView.LocalStorageClear
+ https://bugs.webkit.org/show_bug.cgi?id=166032
+ <rdar://problem/29758423>
+
+ Reviewed by Simon Fraser.
+
+ Add an @autoreleasepool around the code that allocates then clears the WKWebView,
+ to ensure that the view is destroyed before the callback fires.
+
+ * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
+ (TEST):
+
2016-12-21 Saam Barati <[email protected]>
WebAssembly: Import spec tests
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm (210092 => 210093)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm 2016-12-22 01:41:51 UTC (rev 210092)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm 2016-12-22 01:57:24 UTC (rev 210093)
@@ -61,15 +61,17 @@
[configuration _setNeedsStorageAccessFromFileURLsQuirk:NO];
[configuration _setAllowUniversalAccessFromFileURLs:YES];
- RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);
+ @autoreleasepool {
+ RetainPtr<WKWebView> webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);
- NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"LocalStorageClear" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
- [webView loadRequest:request];
+ NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"LocalStorageClear" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
+ [webView loadRequest:request];
- TestWebKitAPI::Util::run(&readyToContinue);
- readyToContinue = false;
+ TestWebKitAPI::Util::run(&readyToContinue);
+ readyToContinue = false;
- webView = nil;
+ webView = nil;
+ }
NSString *dbPath = [@"~/Library/WebKit/TestWebKitAPI/WebsiteData/LocalStorage/file__0.localstorage" stringByExpandingTildeInPath];
NSString *dbSHMPath = [@"~/Library/WebKit/TestWebKitAPI/WebsiteData/LocalStorage/file__0.localstorage-shm" stringByExpandingTildeInPath];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
