Title: [210096] trunk
Revision
210096
Author
[email protected]
Date
2016-12-22 01:22:42 -0800 (Thu, 22 Dec 2016)

Log Message

[WebRTC] Add support for runtime PeeConnection setting, required after r209757
https://bugs.webkit.org/show_bug.cgi?id=166346

Patch by Alejandro G. Castro <[email protected]> on 2016-12-22
Reviewed by Carlos Garcia Campos.

Source/WebKit2:

After that commit we have to enable the peerConnection runtime
flag if we want webrtc to work. We are not adding a new API for
the moment to control the peerConnection feature.

* UIProcess/API/gtk/WebKitSettings.cpp:
(webkit_settings_set_enable_media_stream): Use the mediaStream
setting to control the peerConnection

Tools:

Enable WebRTC by default to simplify testing.

* MiniBrowser/gtk/main.c:
(main):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (210095 => 210096)


--- trunk/Source/WebKit2/ChangeLog	2016-12-22 03:06:35 UTC (rev 210095)
+++ trunk/Source/WebKit2/ChangeLog	2016-12-22 09:22:42 UTC (rev 210096)
@@ -1,3 +1,18 @@
+2016-12-22  Alejandro G. Castro  <[email protected]>
+
+        [WebRTC] Add support for runtime PeeConnection setting, required after r209757
+        https://bugs.webkit.org/show_bug.cgi?id=166346
+
+        Reviewed by Carlos Garcia Campos.
+
+        After that commit we have to enable the peerConnection runtime
+        flag if we want webrtc to work. We are not adding a new API for
+        the moment to control the peerConnection feature.
+
+        * UIProcess/API/gtk/WebKitSettings.cpp:
+        (webkit_settings_set_enable_media_stream): Use the mediaStream
+        setting to control the peerConnection
+
 2016-12-21  Brent Fulgham  <[email protected]>
 
         [Mac][WK2] Stop using file* rules in WebProcess sandbox profiles

Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp (210095 => 210096)


--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp	2016-12-22 03:06:35 UTC (rev 210095)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp	2016-12-22 09:22:42 UTC (rev 210096)
@@ -2973,6 +2973,7 @@
         return;
 
     priv->preferences->setMediaStreamEnabled(enabled);
+    priv->preferences->setPeerConnectionEnabled(enabled);
     g_object_notify(G_OBJECT(settings), "enable-media-stream");
 }
 

Modified: trunk/Tools/ChangeLog (210095 => 210096)


--- trunk/Tools/ChangeLog	2016-12-22 03:06:35 UTC (rev 210095)
+++ trunk/Tools/ChangeLog	2016-12-22 09:22:42 UTC (rev 210096)
@@ -1,3 +1,15 @@
+2016-12-22  Alejandro G. Castro  <[email protected]>
+
+        [WebRTC] Add support for runtime PeeConnection setting, required after r209757
+        https://bugs.webkit.org/show_bug.cgi?id=166346
+
+        Reviewed by Carlos Garcia Campos.
+
+        Enable WebRTC by default to simplify testing.
+
+        * MiniBrowser/gtk/main.c:
+        (main):
+
 2016-12-21  Alexey Proskuryakov  <[email protected]>
 
         REGRESSION: API test failure: WKWebView.LocalStorageClear

Modified: trunk/Tools/MiniBrowser/gtk/main.c (210095 => 210096)


--- trunk/Tools/MiniBrowser/gtk/main.c	2016-12-22 03:06:35 UTC (rev 210095)
+++ trunk/Tools/MiniBrowser/gtk/main.c	2016-12-22 09:22:42 UTC (rev 210096)
@@ -269,6 +269,7 @@
     WebKitSettings *webkitSettings = webkit_settings_new();
     webkit_settings_set_enable_developer_extras(webkitSettings, TRUE);
     webkit_settings_set_enable_webgl(webkitSettings, TRUE);
+    webkit_settings_set_enable_media_stream(webkitSettings, TRUE);
     if (!addSettingsGroupToContext(context, webkitSettings))
         g_clear_object(&webkitSettings);
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to