- Revision
- 210234
- Author
- [email protected]
- Date
- 2017-01-03 01:04:20 -0800 (Tue, 03 Jan 2017)
Log Message
[GTK] HTTP auth layout tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=158919
Reviewed by Michael Catanzaro.
Source/WebKit2:
Implement NetworkSession::clearCredentials() for soup using the new libsoup API when available.
* NetworkProcess/soup/NetworkSessionSoup.cpp:
(WebKit::NetworkSessionSoup::clearCredentials):
* NetworkProcess/soup/NetworkSessionSoup.h:
Tools:
* gtk/jhbuild.modules: Update libsoup to version 2.57.1.
* gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
missing valac in the bots.
LayoutTests:
Unskip tests that should pass now.
* platform/gtk/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (210233 => 210234)
--- trunk/LayoutTests/ChangeLog 2017-01-03 08:14:58 UTC (rev 210233)
+++ trunk/LayoutTests/ChangeLog 2017-01-03 09:04:20 UTC (rev 210234)
@@ -1,3 +1,14 @@
+2017-01-03 Carlos Garcia Campos <[email protected]>
+
+ [GTK] HTTP auth layout tests are flaky
+ https://bugs.webkit.org/show_bug.cgi?id=158919
+
+ Reviewed by Michael Catanzaro.
+
+ Unskip tests that should pass now.
+
+ * platform/gtk/TestExpectations:
+
2017-01-02 Chris Fleizach <[email protected]>
AX: Expose block quote level to iOS API
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (210233 => 210234)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2017-01-03 08:14:58 UTC (rev 210233)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2017-01-03 09:04:20 UTC (rev 210234)
@@ -1323,9 +1323,6 @@
webkit.org/b/158918 fast/css3-text/css3-text-decoration/text-decoration-dotted-dashed.html [ ImageOnlyFailure Pass ]
webkit.org/b/158918 fast/css3-text/css3-text-decoration/text-decoration-dotted.html [ ImageOnlyFailure Pass ]
-webkit.org/b/158919 http/tests/loading/basic-auth-resend-wrong-credentials.html [ Failure Pass ]
-webkit.org/b/158919 http/tests/loading/basic-credentials-sent-automatically.html [ Failure Pass ]
-
# This test relies on iOS-specific font fallback.
fast/text/arabic-blacklisted-expected.html [ Pass ImageOnlyFailure ]
Modified: trunk/Source/WebKit2/ChangeLog (210233 => 210234)
--- trunk/Source/WebKit2/ChangeLog 2017-01-03 08:14:58 UTC (rev 210233)
+++ trunk/Source/WebKit2/ChangeLog 2017-01-03 09:04:20 UTC (rev 210234)
@@ -1,3 +1,16 @@
+2017-01-03 Carlos Garcia Campos <[email protected]>
+
+ [GTK] HTTP auth layout tests are flaky
+ https://bugs.webkit.org/show_bug.cgi?id=158919
+
+ Reviewed by Michael Catanzaro.
+
+ Implement NetworkSession::clearCredentials() for soup using the new libsoup API when available.
+
+ * NetworkProcess/soup/NetworkSessionSoup.cpp:
+ (WebKit::NetworkSessionSoup::clearCredentials):
+ * NetworkProcess/soup/NetworkSessionSoup.h:
+
2017-01-01 Jeff Miller <[email protected]>
Update user-visible copyright strings to include 2017
Modified: trunk/Source/WebKit2/NetworkProcess/soup/NetworkSessionSoup.cpp (210233 => 210234)
--- trunk/Source/WebKit2/NetworkProcess/soup/NetworkSessionSoup.cpp 2017-01-03 08:14:58 UTC (rev 210233)
+++ trunk/Source/WebKit2/NetworkProcess/soup/NetworkSessionSoup.cpp 2017-01-03 09:04:20 UTC (rev 210234)
@@ -28,6 +28,7 @@
#include <WebCore/NetworkStorageSession.h>
#include <WebCore/SoupNetworkSession.h>
+#include <libsoup/soup.h>
using namespace WebCore;
@@ -47,4 +48,11 @@
return networkStorageSession().soupNetworkSession().soupSession();
}
+void NetworkSessionSoup::clearCredentials()
+{
+#if SOUP_CHECK_VERSION(2, 57, 1)
+ soup_auth_manager_clear_cached_credentials(SOUP_AUTH_MANAGER(soup_session_get_feature(soupSession(), SOUP_TYPE_AUTH_MANAGER)));
+#endif
+}
+
} // namespace WebKit
Modified: trunk/Source/WebKit2/NetworkProcess/soup/NetworkSessionSoup.h (210233 => 210234)
--- trunk/Source/WebKit2/NetworkProcess/soup/NetworkSessionSoup.h 2017-01-03 08:14:58 UTC (rev 210233)
+++ trunk/Source/WebKit2/NetworkProcess/soup/NetworkSessionSoup.h 2017-01-03 09:04:20 UTC (rev 210234)
@@ -43,6 +43,8 @@
private:
NetworkSessionSoup(WebCore::SessionID);
+
+ void clearCredentials() override;
};
} // namespace WebKit
Modified: trunk/Tools/ChangeLog (210233 => 210234)
--- trunk/Tools/ChangeLog 2017-01-03 08:14:58 UTC (rev 210233)
+++ trunk/Tools/ChangeLog 2017-01-03 09:04:20 UTC (rev 210234)
@@ -1,5 +1,17 @@
2017-01-03 Carlos Garcia Campos <[email protected]>
+ [GTK] HTTP auth layout tests are flaky
+ https://bugs.webkit.org/show_bug.cgi?id=158919
+
+ Reviewed by Michael Catanzaro.
+
+ * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
+ * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
+ introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
+ missing valac in the bots.
+
+2017-01-03 Carlos Garcia Campos <[email protected]>
+
REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
https://bugs.webkit.org/show_bug.cgi?id=165797
Modified: trunk/Tools/gtk/jhbuild.modules (210233 => 210234)
--- trunk/Tools/gtk/jhbuild.modules 2017-01-03 08:14:58 UTC (rev 210233)
+++ trunk/Tools/gtk/jhbuild.modules 2017-01-03 09:04:20 UTC (rev 210234)
@@ -236,9 +236,9 @@
<dependencies>
<dep package="glib-networking"/>
</dependencies>
- <branch module="libsoup" version="2.49.91.1"
+ <branch module="libsoup" version="2.57.1"
repo="git.gnome.org"
- tag="f7292448160128b3cb4b7cd06c2447f81fd8c6c9"/>
+ tag="6acdbacc107c99fe6f05b78b81f4a40fb3fde9e9"/>
</autotools>
<autotools id="fontconfig"
Modified: trunk/Tools/gtk/jhbuildrc (210233 => 210234)
--- trunk/Tools/gtk/jhbuildrc 2017-01-03 08:14:58 UTC (rev 210233)
+++ trunk/Tools/gtk/jhbuildrc 2017-01-03 09:04:20 UTC (rev 210234)
@@ -26,10 +26,6 @@
sys.path = [__gtk_tools_directory] + sys.path
import common
-# We always enable introspection so that we can sniff out problems with our
-# annotations sooner rather than later.
-autogenargs='--enable-introspection'
-
# LLVM requires that builddir != srcdir, and it's not possible to do that in jhbuild only
# for a module, so we do it here globally since it's a good idea for all other modules as well.
buildroot = os.path.join(os.path.dirname(checkoutroot), "Build")
