Title: [210249] trunk/Source/WebInspectorUI
- Revision
- 210249
- Author
- [email protected]
- Date
- 2017-01-03 14:12:27 -0800 (Tue, 03 Jan 2017)
Log Message
Web Inspector: opening Test.html in a normal browser window doesn't log errors to console
https://bugs.webkit.org/show_bug.cgi?id=166570
Reviewed by Joseph Pecoraro.
Early syntax errors in the test harness should be logged to the page console since they are easier to
debug in a normal browser using Web Inspector. But, the checks to revert to normal console don't work.
* UserInterface/Test/FrontendTestHarness.js:
(FrontendTestHarness.prototype.reportUncaughtException):
Add a helper to encapsulate the meaning of checking this._shouldResendResults.
This flag is always true until the test page injects its initializers into the
inspector page, which will never happen when we view Test.html outside of the test harness.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (210248 => 210249)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-01-03 22:03:33 UTC (rev 210248)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-01-03 22:12:27 UTC (rev 210249)
@@ -1,3 +1,19 @@
+2017-01-03 Brian Burg <[email protected]>
+
+ Web Inspector: opening Test.html in a normal browser window doesn't log errors to console
+ https://bugs.webkit.org/show_bug.cgi?id=166570
+
+ Reviewed by Joseph Pecoraro.
+
+ Early syntax errors in the test harness should be logged to the page console since they are easier to
+ debug in a normal browser using Web Inspector. But, the checks to revert to normal console don't work.
+
+ * UserInterface/Test/FrontendTestHarness.js:
+ (FrontendTestHarness.prototype.reportUncaughtException):
+ Add a helper to encapsulate the meaning of checking this._shouldResendResults.
+ This flag is always true until the test page injects its initializers into the
+ inspector page, which will never happen when we view Test.html outside of the test harness.
+
2016-12-22 Commit Queue <[email protected]>
Unreviewed, rolling out r210069.
Modified: trunk/Source/WebInspectorUI/UserInterface/Test/FrontendTestHarness.js (210248 => 210249)
--- trunk/Source/WebInspectorUI/UserInterface/Test/FrontendTestHarness.js 2017-01-03 22:03:33 UTC (rev 210248)
+++ trunk/Source/WebInspectorUI/UserInterface/Test/FrontendTestHarness.js 2017-01-03 22:12:27 UTC (rev 210249)
@@ -195,7 +195,7 @@
// If the connection to the test page is not set up, then just dump to console and give up.
// Errors encountered this early can be debugged by loading Test.html in a normal browser page.
- if (this._originalConsole && (!InspectorFrontendHost || !InspectorBackend)) {
+ if (this._originalConsole && !this._testPageHasLoaded()) {
this._originalConsole["error"](result);
return false;
}
@@ -208,6 +208,11 @@
// Private
+ _testPageHasLoaded()
+ {
+ return self._shouldResendResults;
+ }
+
_resendResults()
{
console.assert(this._shouldResendResults);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
