Title: [210434] trunk/Tools
Revision
210434
Author
[email protected]
Date
2017-01-06 01:16:17 -0800 (Fri, 06 Jan 2017)

Log Message

Warning about unconnectable outlets when opening a MiniBrowser window
https://bugs.webkit.org/show_bug.cgi?id=166756

Reviewed by Dan Bernstein.

* MiniBrowser/mac/BrowserWindow.xib:
When launching MiniBrowser, it says:
Failed to connect (Share) outlet from (WK1BrowserWindowController) to
    (MBToolbarItem): missing setter or instance variable
Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
    (NSButtonCell): missing setter or instance variable.

It looks like someone added the connection from the share button
to the BrowserWindowController three times; only one of the connections
is valid. Remove the other two.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (210433 => 210434)


--- trunk/Tools/ChangeLog	2017-01-06 04:09:49 UTC (rev 210433)
+++ trunk/Tools/ChangeLog	2017-01-06 09:16:17 UTC (rev 210434)
@@ -1,3 +1,21 @@
+2017-01-06  Tim Horton  <[email protected]>
+
+        Warning about unconnectable outlets when opening a MiniBrowser window
+        https://bugs.webkit.org/show_bug.cgi?id=166756
+
+        Reviewed by Dan Bernstein.
+
+        * MiniBrowser/mac/BrowserWindow.xib:
+        When launching MiniBrowser, it says:
+        Failed to connect (Share) outlet from (WK1BrowserWindowController) to
+            (MBToolbarItem): missing setter or instance variable
+        Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
+            (NSButtonCell): missing setter or instance variable.
+
+        It looks like someone added the connection from the share button
+        to the BrowserWindowController three times; only one of the connections
+        is valid. Remove the other two.
+
 2017-01-05  Keith Rollin  <[email protected]>
 
         Add WebCore::URL::protocolHostAndPort

Modified: trunk/Tools/MiniBrowser/mac/BrowserWindow.xib (210433 => 210434)


--- trunk/Tools/MiniBrowser/mac/BrowserWindow.xib	2017-01-06 04:09:49 UTC (rev 210433)
+++ trunk/Tools/MiniBrowser/mac/BrowserWindow.xib	2017-01-06 09:16:17 UTC (rev 210434)
@@ -7,7 +7,6 @@
     <objects>
         <customObject id="-2" userLabel="File's Owner" customClass="BrowserWindowController">
             <connections>
-                <outlet property="Share" destination="dJx-dw-gcC" id="j0J-ps-exa"/>
                 <outlet property="backButton" destination="40" id="46"/>
                 <outlet property="containerView" destination="9" id="37"/>
                 <outlet property="findPanelWindow" destination="70" id="77"/>
@@ -15,7 +14,6 @@
                 <outlet property="progressIndicator" destination="21" id="33"/>
                 <outlet property="reloadButton" destination="23" id="34"/>
                 <outlet property="share" destination="1hB-AH-eUl" id="si4-8e-DsM"/>
-                <outlet property="shareButton" destination="S1v-UD-QhI" id="t4L-Uq-paq"/>
                 <outlet property="toggleUseShrinkToFitButton" destination="82" id="9w7-AB-Ye3"/>
                 <outlet property="toolbar" destination="48" id="67"/>
                 <outlet property="urlText" destination="10" id="32"/>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to