Diff
Modified: trunk/LayoutTests/ChangeLog (210448 => 210449)
--- trunk/LayoutTests/ChangeLog 2017-01-06 19:54:43 UTC (rev 210448)
+++ trunk/LayoutTests/ChangeLog 2017-01-06 20:02:45 UTC (rev 210449)
@@ -1,3 +1,24 @@
+2017-01-06 Joseph Pecoraro <[email protected]>
+
+ Add some missing longhand properties to CSSComputedStyleDeclaration and fix default values
+ https://bugs.webkit.org/show_bug.cgi?id=166674
+ <rdar://problem/6026159>
+
+ Reviewed by Darin Adler.
+
+ * fast/css/getComputedStyle/computed-style-font-family.html:
+ Skip font-variation-settings which is only available if the feature flag is enabled.
+
+ * fast/css/getComputedStyle/counterIncrement-without-counter-expected.txt:
+ * fast/css/getComputedStyle/counterIncrement-without-counter.html:
+ Fix the default value to be "none" instead of the empty string.
+
+ * svg/css/getComputedStyle-basic-expected.txt:
+ * fast/css/getComputedStyle/computed-style-expected.txt:
+ * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
+ * fast/css/getComputedStyle/resources/property-names.js:
+ Add some always expected to be available longhand properties to check.
+
2017-01-06 Chris Dumez <[email protected]>
[Form Validation] "character" in maxlength validation message should be singular when maxlength is 1
Modified: trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt (210448 => 210449)
--- trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt 2017-01-06 19:54:43 UTC (rev 210448)
+++ trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt 2017-01-06 20:02:45 UTC (rev 210449)
@@ -37,6 +37,8 @@
clear: none;
clip: auto;
color: rgb(0, 0, 0);
+counter-increment: none;
+counter-reset: none;
content: ;
cursor: auto;
direction: ltr;
@@ -48,6 +50,7 @@
font-synthesis: style weight small-caps;
font-variant: normal;
font-weight: normal;
+hanging-punctuation: none;
height: 576px;
image-rendering: auto;
left: auto;
@@ -64,11 +67,15 @@
max-width: none;
min-height: 0px;
min-width: 0px;
+object-fit: fill;
+object-position: 50% 50%;
opacity: 1;
orphans: auto;
outline-color: rgb(0, 0, 0);
+outline-offset: 0px;
outline-style: none;
outline-width: 0px;
+overflow-wrap: normal;
overflow-x: visible;
overflow-y: visible;
padding-bottom: 0px;
@@ -96,6 +103,10 @@
transform: none;
transform-origin: 392px 288px;
transform-style: flat;
+transition-delay: 0s;
+transition-duration: 0s;
+transition-property: all;
+transition-timing-function: ease;
unicode-bidi: normal;
vertical-align: baseline;
visibility: visible;
@@ -102,6 +113,7 @@
white-space: normal;
widows: auto;
width: 784px;
+will-change: auto;
word-break: normal;
word-spacing: 0px;
word-wrap: normal;
@@ -144,7 +156,11 @@
align-items: normal;
align-self: normal;
filter: none;
+flex-basis: auto;
flex-direction: row;
+flex-flow: row nowrap;
+flex-grow: 0;
+flex-shrink: 1;
flex-wrap: nowrap;
justify-content: normal;
justify-self: normal;
@@ -203,6 +219,7 @@
perspective-origin: 392px 288px;
-webkit-print-color-adjust: economy;
-webkit-rtl-ordering: logical;
+shape-outside: none;
-webkit-text-combine: none;
-webkit-text-decorations-in-effect: none;
-webkit-text-emphasis-color: rgb(0, 0, 0);
@@ -217,9 +234,15 @@
-webkit-user-drag: auto;
-webkit-user-modify: read-only;
-webkit-user-select: text;
+shape-image-threshold: 0;
+shape-margin: 0px;
+shape-outside: none;
+shape-rendering: auto;
+buffered-rendering: auto;
clip-path: none;
clip-rule: nonzero;
mask: none;
+mask-type: luminance;
filter: none;
flood-color: rgb(0, 0, 0);
flood-opacity: 1;
@@ -235,7 +258,7 @@
marker-end: none;
marker-mid: none;
marker-start: none;
-shape-rendering: auto;
+paint-order: normal;
stroke: none;
stroke-dasharray: none;
stroke-dashoffset: 0px;
Modified: trunk/LayoutTests/fast/css/getComputedStyle/computed-style-font-family.html (210448 => 210449)
--- trunk/LayoutTests/fast/css/getComputedStyle/computed-style-font-family.html 2017-01-06 19:54:43 UTC (rev 210448)
+++ trunk/LayoutTests/fast/css/getComputedStyle/computed-style-font-family.html 2017-01-06 20:02:45 UTC (rev 210449)
@@ -7,7 +7,7 @@
var text = "";
for (var i = 0; i != style.length; ++i) {
var name = style.item(i);
- if (!name.match(/^font/))
+ if (!name.match(/^font/) || name === "font-variation-settings")
continue;
var value = style.getPropertyValue(name);
text += name + ": " + value + ";\n";
Modified: trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt (210448 => 210449)
--- trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt 2017-01-06 19:54:43 UTC (rev 210448)
+++ trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt 2017-01-06 20:02:45 UTC (rev 210449)
@@ -36,6 +36,8 @@
clear: none
clip: auto
color: rgb(0, 0, 0)
+counter-increment: none
+counter-reset: none
content:
cursor: auto
direction: ltr
@@ -47,6 +49,7 @@
font-synthesis: style weight small-caps
font-variant: normal
font-weight: normal
+hanging-punctuation: none
height: 100px
image-rendering: auto
left: auto
@@ -63,11 +66,15 @@
max-width: none
min-height: 0px
min-width: 0px
+object-fit: fill
+object-position: 50% 50%
opacity: 1
orphans: auto
outline-color: rgb(0, 0, 0)
+outline-offset: 0px
outline-style: none
outline-width: 0px
+overflow-wrap: normal
overflow-x: visible
overflow-y: visible
padding-bottom: 0px
@@ -95,6 +102,10 @@
transform: none
transform-origin: 50% 50%
transform-style: flat
+transition-delay: 0s
+transition-duration: 0s
+transition-property: all
+transition-timing-function: ease
unicode-bidi: normal
vertical-align: baseline
visibility: visible
@@ -101,6 +112,7 @@
white-space: normal
widows: auto
width: 50%
+will-change: auto
word-break: normal
word-spacing: 0px
word-wrap: normal
@@ -143,7 +155,11 @@
align-items: normal
align-self: normal
filter: none
+flex-basis: auto
flex-direction: row
+flex-flow: row nowrap
+flex-grow: 0
+flex-shrink: 1
flex-wrap: nowrap
justify-content: normal
justify-self: normal
@@ -202,6 +218,7 @@
perspective-origin: 50% 50%
-webkit-print-color-adjust: economy
-webkit-rtl-ordering: logical
+shape-outside: none
-webkit-text-combine: none
-webkit-text-decorations-in-effect: none
-webkit-text-emphasis-color: rgb(0, 0, 0)
@@ -216,9 +233,15 @@
-webkit-user-drag: auto
-webkit-user-modify: read-only
-webkit-user-select: text
+shape-image-threshold: 0
+shape-margin: 0px
+shape-outside: none
+shape-rendering: auto
+buffered-rendering: auto
clip-path: none
clip-rule: nonzero
mask: none
+mask-type: luminance
filter: none
flood-color: rgb(0, 0, 0)
flood-opacity: 1
@@ -234,7 +257,7 @@
marker-end: none
marker-mid: none
marker-start: none
-shape-rendering: auto
+paint-order: normal
stroke: none
stroke-dasharray: none
stroke-dashoffset: 0px
Modified: trunk/LayoutTests/fast/css/getComputedStyle/counterIncrement-without-counter-expected.txt (210448 => 210449)
--- trunk/LayoutTests/fast/css/getComputedStyle/counterIncrement-without-counter-expected.txt 2017-01-06 19:54:43 UTC (rev 210448)
+++ trunk/LayoutTests/fast/css/getComputedStyle/counterIncrement-without-counter-expected.txt 2017-01-06 20:02:45 UTC (rev 210449)
@@ -1,3 +1,3 @@
-PASS style.counterIncrement is '';
-PASS style.counterReset is '';
+PASS style.counterIncrement is "none"
+PASS style.counterReset is "none"
Modified: trunk/LayoutTests/fast/css/getComputedStyle/counterIncrement-without-counter.html (210448 => 210449)
--- trunk/LayoutTests/fast/css/getComputedStyle/counterIncrement-without-counter.html 2017-01-06 19:54:43 UTC (rev 210448)
+++ trunk/LayoutTests/fast/css/getComputedStyle/counterIncrement-without-counter.html 2017-01-06 20:02:45 UTC (rev 210449)
@@ -3,11 +3,11 @@
<script src=""
</head>
<body>
- <div id="console"></div>
- <script>
- var style = window.getComputedStyle(document.body, null);
- shouldBe("style.counterIncrement", "'';");
- shouldBe("style.counterReset", "'';");
- </script>
+<div id="console"></div>
+<script>
+var style = window.getComputedStyle(document.body, null);
+shouldBeEqualToString("style.counterIncrement", "none");
+shouldBeEqualToString("style.counterReset", "none");
+</script>
</body>
</html>
Modified: trunk/LayoutTests/fast/css/getComputedStyle/resources/property-names.js (210448 => 210449)
--- trunk/LayoutTests/fast/css/getComputedStyle/resources/property-names.js 2017-01-06 19:54:43 UTC (rev 210448)
+++ trunk/LayoutTests/fast/css/getComputedStyle/resources/property-names.js 2017-01-06 20:02:45 UTC (rev 210449)
@@ -44,7 +44,13 @@
"column-rule-width": true,
"column-span": true,
"column-width": true,
+ "counter-increment": true,
+ "counter-reset": true,
+ "flex-basis": true,
"flex-direction": true,
+ "flex-flow": true,
+ "flex-grow": true,
+ "flex-shrink": true,
"flex-wrap": true,
"-webkit-font-kerning": true,
"-webkit-font-smoothing": true,
@@ -114,10 +120,10 @@
"transform-origin": true,
"transform-style": true,
"-webkit-transform-style": true,
- "-webkit-transition-delay": true,
- "-webkit-transition-duration": true,
- "-webkit-transition-property": true,
- "-webkit-transition-timing-function": true,
+ "transition-delay": true,
+ "transition-duration": true,
+ "transition-property": true,
+ "transition-timing-function": true,
"-webkit-user-drag": true,
"-webkit-user-modify": true,
"-webkit-user-select": true,
@@ -157,6 +163,7 @@
"bottom": true,
"box-shadow": true,
"box-sizing": true,
+ "buffered-rendering": true,
"caption-side": true,
"clear": true,
"clip": true,
@@ -183,15 +190,16 @@
"font-style": true,
"font-synthesis": true,
"font-variant": true,
+ "font-variant-alternates": true,
+ "font-variant-caps": true,
+ "font-variant-east-asian": true,
"font-variant-ligatures": true,
+ "font-variant-numeric": true,
"font-variant-position": true,
- "font-variant-caps": true,
- "font-variant-numeric": true,
- "font-variant-alternates": true,
- "font-variant-east-asian": true,
"font-weight": true,
"glyph-orientation-horizontal": true,
"glyph-orientation-vertical": true,
+ "hanging-punctuation": true,
"height": true,
"image-rendering": true,
"kerning": true,
@@ -210,15 +218,20 @@
"marker-mid": true,
"marker-start": true,
"mask": true,
+ "mask-type": true,
"max-height": true,
"max-width": true,
"min-height": true,
"min-width": true,
+ "object-fit": true,
+ "object-position": true,
"opacity": true,
"orphans": true,
"outline-color": true,
+ "outline-offset": true,
"outline-style": true,
"outline-width": true,
+ "overflow-wrap": true,
"overflow-x": true,
"overflow-y": true,
"padding-bottom": true,
@@ -228,10 +241,14 @@
"page-break-after": true,
"page-break-before": true,
"page-break-inside": true,
+ "paint-order": true,
"pointer-events": true,
"position": true,
"resize": true,
"right": true,
+ "shape-image-threshold": true,
+ "shape-margin": true,
+ "shape-outside": true,
"shape-rendering": true,
"speak": true,
"stop-color": true,
@@ -262,6 +279,7 @@
"white-space": true,
"widows": true,
"width": true,
+ "will-change": true,
"word-break": true,
"word-spacing": true,
"word-wrap": true,
Modified: trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt (210448 => 210449)
--- trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt 2017-01-06 19:54:43 UTC (rev 210448)
+++ trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt 2017-01-06 20:02:45 UTC (rev 210449)
@@ -72,6 +72,10 @@
rect: style.getPropertyCSSValue(clip) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(color) : rgb(0, 0, 0)
rect: style.getPropertyCSSValue(color) : [object CSSPrimitiveValue]
+rect: style.getPropertyValue(counter-increment) : none
+rect: style.getPropertyCSSValue(counter-increment) : [object CSSPrimitiveValue]
+rect: style.getPropertyValue(counter-reset) : none
+rect: style.getPropertyCSSValue(counter-reset) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(content) :
rect: style.getPropertyCSSValue(content) : [object CSSValueList]
rect: style.getPropertyValue(cursor) : auto
@@ -94,6 +98,8 @@
rect: style.getPropertyCSSValue(font-variant) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(font-weight) : normal
rect: style.getPropertyCSSValue(font-weight) : [object CSSPrimitiveValue]
+rect: style.getPropertyValue(hanging-punctuation) : none
+rect: style.getPropertyCSSValue(hanging-punctuation) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(height) : 100px
rect: style.getPropertyCSSValue(height) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(image-rendering) : auto
@@ -126,6 +132,10 @@
rect: style.getPropertyCSSValue(min-height) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(min-width) : 0px
rect: style.getPropertyCSSValue(min-width) : [object CSSPrimitiveValue]
+rect: style.getPropertyValue(object-fit) : fill
+rect: style.getPropertyCSSValue(object-fit) : [object CSSPrimitiveValue]
+rect: style.getPropertyValue(object-position) : 50% 50%
+rect: style.getPropertyCSSValue(object-position) : [object CSSValueList]
rect: style.getPropertyValue(opacity) : 1
rect: style.getPropertyCSSValue(opacity) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(orphans) : auto
@@ -132,10 +142,14 @@
rect: style.getPropertyCSSValue(orphans) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(outline-color) : rgb(0, 0, 0)
rect: style.getPropertyCSSValue(outline-color) : [object CSSPrimitiveValue]
+rect: style.getPropertyValue(outline-offset) : 0px
+rect: style.getPropertyCSSValue(outline-offset) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(outline-style) : none
rect: style.getPropertyCSSValue(outline-style) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(outline-width) : 0px
rect: style.getPropertyCSSValue(outline-width) : [object CSSPrimitiveValue]
+rect: style.getPropertyValue(overflow-wrap) : normal
+rect: style.getPropertyCSSValue(overflow-wrap) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(overflow-x) : visible
rect: style.getPropertyCSSValue(overflow-x) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(overflow-y) : visible
@@ -190,6 +204,14 @@
rect: style.getPropertyCSSValue(transform-origin) : [object CSSValueList]
rect: style.getPropertyValue(transform-style) : flat
rect: style.getPropertyCSSValue(transform-style) : [object CSSPrimitiveValue]
+rect: style.getPropertyValue(transition-delay) : 0s
+rect: style.getPropertyCSSValue(transition-delay) : [object CSSValueList]
+rect: style.getPropertyValue(transition-duration) : 0s
+rect: style.getPropertyCSSValue(transition-duration) : [object CSSValueList]
+rect: style.getPropertyValue(transition-property) : all
+rect: style.getPropertyCSSValue(transition-property) : [object CSSValueList]
+rect: style.getPropertyValue(transition-timing-function) : ease
+rect: style.getPropertyCSSValue(transition-timing-function) : [object CSSValueList]
rect: style.getPropertyValue(unicode-bidi) : normal
rect: style.getPropertyCSSValue(unicode-bidi) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(vertical-align) : baseline
@@ -202,6 +224,8 @@
rect: style.getPropertyCSSValue(widows) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(width) : 100px
rect: style.getPropertyCSSValue(width) : [object CSSPrimitiveValue]
+rect: style.getPropertyValue(will-change) : auto
+rect: style.getPropertyCSSValue(will-change) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(word-break) : normal
rect: style.getPropertyCSSValue(word-break) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(word-spacing) : 0px
@@ -286,8 +310,16 @@
rect: style.getPropertyCSSValue(align-self) : [object CSSValueList]
rect: style.getPropertyValue(filter) : none
rect: style.getPropertyCSSValue(filter) : [object CSSPrimitiveValue]
+rect: style.getPropertyValue(flex-basis) : auto
+rect: style.getPropertyCSSValue(flex-basis) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(flex-direction) : row
rect: style.getPropertyCSSValue(flex-direction) : [object CSSPrimitiveValue]
+rect: style.getPropertyValue(flex-flow) : row nowrap
+rect: style.getPropertyCSSValue(flex-flow) : [object CSSValueList]
+rect: style.getPropertyValue(flex-grow) : 0
+rect: style.getPropertyCSSValue(flex-grow) : [object CSSPrimitiveValue]
+rect: style.getPropertyValue(flex-shrink) : 1
+rect: style.getPropertyCSSValue(flex-shrink) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(flex-wrap) : nowrap
rect: style.getPropertyCSSValue(flex-wrap) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(justify-content) : normal
@@ -404,6 +436,8 @@
rect: style.getPropertyCSSValue(-webkit-print-color-adjust) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(-webkit-rtl-ordering) : logical
rect: style.getPropertyCSSValue(-webkit-rtl-ordering) : [object CSSPrimitiveValue]
+rect: style.getPropertyValue(shape-outside) : none
+rect: style.getPropertyCSSValue(shape-outside) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(-webkit-text-combine) : none
rect: style.getPropertyCSSValue(-webkit-text-combine) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(-webkit-text-decorations-in-effect) : none
@@ -432,6 +466,16 @@
rect: style.getPropertyCSSValue(-webkit-user-modify) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(-webkit-user-select) : text
rect: style.getPropertyCSSValue(-webkit-user-select) : [object CSSPrimitiveValue]
+rect: style.getPropertyValue(shape-image-threshold) : 0
+rect: style.getPropertyCSSValue(shape-image-threshold) : [object CSSPrimitiveValue]
+rect: style.getPropertyValue(shape-margin) : 0px
+rect: style.getPropertyCSSValue(shape-margin) : [object CSSPrimitiveValue]
+rect: style.getPropertyValue(shape-outside) : none
+rect: style.getPropertyCSSValue(shape-outside) : [object CSSPrimitiveValue]
+rect: style.getPropertyValue(shape-rendering) : auto
+rect: style.getPropertyCSSValue(shape-rendering) : [object CSSPrimitiveValue]
+rect: style.getPropertyValue(buffered-rendering) : auto
+rect: style.getPropertyCSSValue(buffered-rendering) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(clip-path) : none
rect: style.getPropertyCSSValue(clip-path) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(clip-rule) : nonzero
@@ -438,6 +482,8 @@
rect: style.getPropertyCSSValue(clip-rule) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(mask) : none
rect: style.getPropertyCSSValue(mask) : [object CSSPrimitiveValue]
+rect: style.getPropertyValue(mask-type) : luminance
+rect: style.getPropertyCSSValue(mask-type) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(filter) : none
rect: style.getPropertyCSSValue(filter) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(flood-color) : rgb(0, 0, 0)
@@ -468,8 +514,8 @@
rect: style.getPropertyCSSValue(marker-mid) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(marker-start) : none
rect: style.getPropertyCSSValue(marker-start) : [object CSSPrimitiveValue]
-rect: style.getPropertyValue(shape-rendering) : auto
-rect: style.getPropertyCSSValue(shape-rendering) : [object CSSPrimitiveValue]
+rect: style.getPropertyValue(paint-order) : normal
+rect: style.getPropertyCSSValue(paint-order) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(stroke) : rgb(255, 165, 0)
rect: style.getPropertyCSSValue(stroke) : [object CSSPrimitiveValue]
rect: style.getPropertyValue(stroke-dasharray) : none
@@ -580,6 +626,10 @@
g: style.getPropertyCSSValue(clip) : [object CSSPrimitiveValue]
g: style.getPropertyValue(color) : rgb(0, 0, 0)
g: style.getPropertyCSSValue(color) : [object CSSPrimitiveValue]
+g: style.getPropertyValue(counter-increment) : none
+g: style.getPropertyCSSValue(counter-increment) : [object CSSPrimitiveValue]
+g: style.getPropertyValue(counter-reset) : none
+g: style.getPropertyCSSValue(counter-reset) : [object CSSPrimitiveValue]
g: style.getPropertyValue(content) :
g: style.getPropertyCSSValue(content) : [object CSSValueList]
g: style.getPropertyValue(cursor) : auto
@@ -602,6 +652,8 @@
g: style.getPropertyCSSValue(font-variant) : [object CSSPrimitiveValue]
g: style.getPropertyValue(font-weight) : normal
g: style.getPropertyCSSValue(font-weight) : [object CSSPrimitiveValue]
+g: style.getPropertyValue(hanging-punctuation) : none
+g: style.getPropertyCSSValue(hanging-punctuation) : [object CSSPrimitiveValue]
g: style.getPropertyValue(height) : auto
g: style.getPropertyCSSValue(height) : [object CSSPrimitiveValue]
g: style.getPropertyValue(image-rendering) : auto
@@ -634,6 +686,10 @@
g: style.getPropertyCSSValue(min-height) : [object CSSPrimitiveValue]
g: style.getPropertyValue(min-width) : 0px
g: style.getPropertyCSSValue(min-width) : [object CSSPrimitiveValue]
+g: style.getPropertyValue(object-fit) : fill
+g: style.getPropertyCSSValue(object-fit) : [object CSSPrimitiveValue]
+g: style.getPropertyValue(object-position) : 50% 50%
+g: style.getPropertyCSSValue(object-position) : [object CSSValueList]
g: style.getPropertyValue(opacity) : 1
g: style.getPropertyCSSValue(opacity) : [object CSSPrimitiveValue]
g: style.getPropertyValue(orphans) : auto
@@ -640,10 +696,14 @@
g: style.getPropertyCSSValue(orphans) : [object CSSPrimitiveValue]
g: style.getPropertyValue(outline-color) : rgb(0, 0, 0)
g: style.getPropertyCSSValue(outline-color) : [object CSSPrimitiveValue]
+g: style.getPropertyValue(outline-offset) : 0px
+g: style.getPropertyCSSValue(outline-offset) : [object CSSPrimitiveValue]
g: style.getPropertyValue(outline-style) : none
g: style.getPropertyCSSValue(outline-style) : [object CSSPrimitiveValue]
g: style.getPropertyValue(outline-width) : 0px
g: style.getPropertyCSSValue(outline-width) : [object CSSPrimitiveValue]
+g: style.getPropertyValue(overflow-wrap) : normal
+g: style.getPropertyCSSValue(overflow-wrap) : [object CSSPrimitiveValue]
g: style.getPropertyValue(overflow-x) : visible
g: style.getPropertyCSSValue(overflow-x) : [object CSSPrimitiveValue]
g: style.getPropertyValue(overflow-y) : visible
@@ -698,6 +758,14 @@
g: style.getPropertyCSSValue(transform-origin) : [object CSSValueList]
g: style.getPropertyValue(transform-style) : flat
g: style.getPropertyCSSValue(transform-style) : [object CSSPrimitiveValue]
+g: style.getPropertyValue(transition-delay) : 0s
+g: style.getPropertyCSSValue(transition-delay) : [object CSSValueList]
+g: style.getPropertyValue(transition-duration) : 0s
+g: style.getPropertyCSSValue(transition-duration) : [object CSSValueList]
+g: style.getPropertyValue(transition-property) : all
+g: style.getPropertyCSSValue(transition-property) : [object CSSValueList]
+g: style.getPropertyValue(transition-timing-function) : ease
+g: style.getPropertyCSSValue(transition-timing-function) : [object CSSValueList]
g: style.getPropertyValue(unicode-bidi) : normal
g: style.getPropertyCSSValue(unicode-bidi) : [object CSSPrimitiveValue]
g: style.getPropertyValue(vertical-align) : baseline
@@ -710,6 +778,8 @@
g: style.getPropertyCSSValue(widows) : [object CSSPrimitiveValue]
g: style.getPropertyValue(width) : auto
g: style.getPropertyCSSValue(width) : [object CSSPrimitiveValue]
+g: style.getPropertyValue(will-change) : auto
+g: style.getPropertyCSSValue(will-change) : [object CSSPrimitiveValue]
g: style.getPropertyValue(word-break) : normal
g: style.getPropertyCSSValue(word-break) : [object CSSPrimitiveValue]
g: style.getPropertyValue(word-spacing) : 0px
@@ -794,8 +864,16 @@
g: style.getPropertyCSSValue(align-self) : [object CSSValueList]
g: style.getPropertyValue(filter) : none
g: style.getPropertyCSSValue(filter) : [object CSSPrimitiveValue]
+g: style.getPropertyValue(flex-basis) : auto
+g: style.getPropertyCSSValue(flex-basis) : [object CSSPrimitiveValue]
g: style.getPropertyValue(flex-direction) : row
g: style.getPropertyCSSValue(flex-direction) : [object CSSPrimitiveValue]
+g: style.getPropertyValue(flex-flow) : row nowrap
+g: style.getPropertyCSSValue(flex-flow) : [object CSSValueList]
+g: style.getPropertyValue(flex-grow) : 0
+g: style.getPropertyCSSValue(flex-grow) : [object CSSPrimitiveValue]
+g: style.getPropertyValue(flex-shrink) : 1
+g: style.getPropertyCSSValue(flex-shrink) : [object CSSPrimitiveValue]
g: style.getPropertyValue(flex-wrap) : nowrap
g: style.getPropertyCSSValue(flex-wrap) : [object CSSPrimitiveValue]
g: style.getPropertyValue(justify-content) : normal
@@ -912,6 +990,8 @@
g: style.getPropertyCSSValue(-webkit-print-color-adjust) : [object CSSPrimitiveValue]
g: style.getPropertyValue(-webkit-rtl-ordering) : logical
g: style.getPropertyCSSValue(-webkit-rtl-ordering) : [object CSSPrimitiveValue]
+g: style.getPropertyValue(shape-outside) : none
+g: style.getPropertyCSSValue(shape-outside) : [object CSSPrimitiveValue]
g: style.getPropertyValue(-webkit-text-combine) : none
g: style.getPropertyCSSValue(-webkit-text-combine) : [object CSSPrimitiveValue]
g: style.getPropertyValue(-webkit-text-decorations-in-effect) : none
@@ -940,6 +1020,16 @@
g: style.getPropertyCSSValue(-webkit-user-modify) : [object CSSPrimitiveValue]
g: style.getPropertyValue(-webkit-user-select) : text
g: style.getPropertyCSSValue(-webkit-user-select) : [object CSSPrimitiveValue]
+g: style.getPropertyValue(shape-image-threshold) : 0
+g: style.getPropertyCSSValue(shape-image-threshold) : [object CSSPrimitiveValue]
+g: style.getPropertyValue(shape-margin) : 0px
+g: style.getPropertyCSSValue(shape-margin) : [object CSSPrimitiveValue]
+g: style.getPropertyValue(shape-outside) : none
+g: style.getPropertyCSSValue(shape-outside) : [object CSSPrimitiveValue]
+g: style.getPropertyValue(shape-rendering) : auto
+g: style.getPropertyCSSValue(shape-rendering) : [object CSSPrimitiveValue]
+g: style.getPropertyValue(buffered-rendering) : auto
+g: style.getPropertyCSSValue(buffered-rendering) : [object CSSPrimitiveValue]
g: style.getPropertyValue(clip-path) : none
g: style.getPropertyCSSValue(clip-path) : [object CSSPrimitiveValue]
g: style.getPropertyValue(clip-rule) : nonzero
@@ -946,6 +1036,8 @@
g: style.getPropertyCSSValue(clip-rule) : [object CSSPrimitiveValue]
g: style.getPropertyValue(mask) : none
g: style.getPropertyCSSValue(mask) : [object CSSPrimitiveValue]
+g: style.getPropertyValue(mask-type) : luminance
+g: style.getPropertyCSSValue(mask-type) : [object CSSPrimitiveValue]
g: style.getPropertyValue(filter) : none
g: style.getPropertyCSSValue(filter) : [object CSSPrimitiveValue]
g: style.getPropertyValue(flood-color) : rgb(0, 0, 0)
@@ -976,8 +1068,8 @@
g: style.getPropertyCSSValue(marker-mid) : [object CSSPrimitiveValue]
g: style.getPropertyValue(marker-start) : none
g: style.getPropertyCSSValue(marker-start) : [object CSSPrimitiveValue]
-g: style.getPropertyValue(shape-rendering) : auto
-g: style.getPropertyCSSValue(shape-rendering) : [object CSSPrimitiveValue]
+g: style.getPropertyValue(paint-order) : normal
+g: style.getPropertyCSSValue(paint-order) : [object CSSPrimitiveValue]
g: style.getPropertyValue(stroke) : rgb(255, 165, 0)
g: style.getPropertyCSSValue(stroke) : [object CSSPrimitiveValue]
g: style.getPropertyValue(stroke-dasharray) : none
Modified: trunk/Source/WebCore/ChangeLog (210448 => 210449)
--- trunk/Source/WebCore/ChangeLog 2017-01-06 19:54:43 UTC (rev 210448)
+++ trunk/Source/WebCore/ChangeLog 2017-01-06 20:02:45 UTC (rev 210449)
@@ -1,3 +1,18 @@
+2017-01-06 Joseph Pecoraro <[email protected]>
+
+ Add some missing longhand properties to CSSComputedStyleDeclaration and fix default values
+ https://bugs.webkit.org/show_bug.cgi?id=166674
+ <rdar://problem/6026159>
+
+ Reviewed by Darin Adler.
+
+ * css/CSSComputedStyleDeclaration.cpp:
+ Add some missing longhand properties to the list of all longhand properties.
+
+ (WebCore::counterToCSSValue):
+ The default value for counter-increment and counter-reset should be "none"
+ not the empty string.
+
2017-01-06 Chris Dumez <[email protected]>
[Form Validation] "character" in maxlength validation message should be singular when maxlength is 1
Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (210448 => 210449)
--- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2017-01-06 19:54:43 UTC (rev 210448)
+++ trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2017-01-06 20:02:45 UTC (rev 210449)
@@ -147,6 +147,8 @@
CSSPropertyClear,
CSSPropertyClip,
CSSPropertyColor,
+ CSSPropertyCounterIncrement,
+ CSSPropertyCounterReset,
CSSPropertyContent,
CSSPropertyCursor,
CSSPropertyDirection,
@@ -159,6 +161,7 @@
CSSPropertyFontSynthesis,
CSSPropertyFontVariant,
CSSPropertyFontWeight,
+ CSSPropertyHangingPunctuation,
CSSPropertyHeight,
#if ENABLE(CSS_IMAGE_ORIENTATION)
CSSPropertyImageOrientation,
@@ -181,6 +184,8 @@
CSSPropertyMaxWidth,
CSSPropertyMinHeight,
CSSPropertyMinWidth,
+ CSSPropertyObjectFit,
+ CSSPropertyObjectPosition,
CSSPropertyOpacity,
CSSPropertyOrphans,
CSSPropertyOutlineColor,
@@ -234,6 +239,7 @@
CSSPropertyWhiteSpace,
CSSPropertyWidows,
CSSPropertyWidth,
+ CSSPropertyWillChange,
CSSPropertyWordBreak,
CSSPropertyWordSpacing,
CSSPropertyWordWrap,
@@ -308,9 +314,10 @@
CSSPropertyAlignSelf,
CSSPropertyFilter,
CSSPropertyFlexBasis,
+ CSSPropertyFlexDirection,
+ CSSPropertyFlexFlow,
CSSPropertyFlexGrow,
CSSPropertyFlexShrink,
- CSSPropertyFlexDirection,
CSSPropertyFlexWrap,
CSSPropertyJustifyContent,
#if ENABLE(CSS_GRID_LAYOUT)
@@ -328,6 +335,9 @@
CSSPropertyFontVariantNumeric,
CSSPropertyFontVariantAlternates,
CSSPropertyFontVariantEastAsian,
+#if ENABLE(VARIATION_FONTS)
+ CSSPropertyFontVariationSettings,
+#endif
#if ENABLE(CSS_GRID_LAYOUT)
CSSPropertyGridAutoColumns,
CSSPropertyGridAutoFlow,
@@ -417,8 +427,10 @@
CSSPropertyWebkitRegionBreakInside,
CSSPropertyWebkitRegionFragment,
#endif
+ CSSPropertyShapeImageThreshold,
CSSPropertyShapeMargin,
- CSSPropertyShapeImageThreshold,
+ CSSPropertyShapeOutside,
+ CSSPropertyShapeRendering,
CSSPropertyBufferedRendering,
CSSPropertyClipPath,
CSSPropertyClipRule,
@@ -425,6 +437,7 @@
CSSPropertyCx,
CSSPropertyCy,
CSSPropertyMask,
+ CSSPropertyMaskType,
CSSPropertyFilter,
CSSPropertyFloodColor,
CSSPropertyFloodOpacity,
@@ -440,12 +453,10 @@
CSSPropertyMarkerEnd,
CSSPropertyMarkerMid,
CSSPropertyMarkerStart,
- CSSPropertyMaskType,
CSSPropertyPaintOrder,
CSSPropertyR,
CSSPropertyRx,
CSSPropertyRy,
- CSSPropertyShapeRendering,
CSSPropertyStroke,
CSSPropertyStrokeDasharray,
CSSPropertyStrokeDashoffset,
@@ -1847,11 +1858,11 @@
return list;
}
-static RefPtr<CSSValue> counterToCSSValue(const RenderStyle* style, CSSPropertyID propertyID)
+static Ref<CSSValue> counterToCSSValue(const RenderStyle* style, CSSPropertyID propertyID)
{
const CounterDirectiveMap* map = style->counterDirectives();
if (!map)
- return nullptr;
+ return CSSValuePool::singleton().createIdentifierValue(CSSValueNone);
auto& cssValuePool = CSSValuePool::singleton();
auto list = CSSValueList::createSpaceSeparated();
