Title: [210472] trunk/Source/WebCore
- Revision
- 210472
- Author
- [email protected]
- Date
- 2017-01-06 22:53:54 -0800 (Fri, 06 Jan 2017)
Log Message
REGRESSION(r208886) Web Inspector: Toggling CSS Properties in Styles Sidebar (comment / uncomment)
https://bugs.webkit.org/show_bug.cgi?id=166786
<rdar://problem/29767412>
Patch by Joseph Pecoraro <[email protected]> on 2017-01-06
Reviewed by Brian Burg.
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::populateAllProperties):
Match earlier behavior and don't send the frontend information about
disabled (commented out) properties. Follow-up later to send this
information when implementing proper handling of them in the frontend.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (210471 => 210472)
--- trunk/Source/WebCore/ChangeLog 2017-01-07 06:52:27 UTC (rev 210471)
+++ trunk/Source/WebCore/ChangeLog 2017-01-07 06:53:54 UTC (rev 210472)
@@ -1,3 +1,17 @@
+2017-01-06 Joseph Pecoraro <[email protected]>
+
+ REGRESSION(r208886) Web Inspector: Toggling CSS Properties in Styles Sidebar (comment / uncomment)
+ https://bugs.webkit.org/show_bug.cgi?id=166786
+ <rdar://problem/29767412>
+
+ Reviewed by Brian Burg.
+
+ * inspector/InspectorStyleSheet.cpp:
+ (WebCore::InspectorStyle::populateAllProperties):
+ Match earlier behavior and don't send the frontend information about
+ disabled (commented out) properties. Follow-up later to send this
+ information when implementing proper handling of them in the frontend.
+
2017-01-06 Sam Weinig <[email protected]>
[WebIDL] Remove custom bindings from CanvasRenderingContext2D
Modified: trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp (210471 => 210472)
--- trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp 2017-01-07 06:52:27 UTC (rev 210471)
+++ trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp 2017-01-07 06:53:54 UTC (rev 210472)
@@ -604,6 +604,9 @@
ASSERT(!styleDeclarationOrException.hasException());
String styleDeclaration = styleDeclarationOrException.hasException() ? emptyString() : styleDeclarationOrException.releaseReturnValue();
for (auto& sourceData : *sourcePropertyData) {
+ // FIXME: <https://webkit.org/b/166787> Web Inspector: Frontend should be made to expect and handle disabled properties
+ if (sourceData.disabled)
+ continue;
InspectorStyleProperty p(sourceData, true, sourceData.disabled);
p.setRawTextFromStyleDeclaration(styleDeclaration);
result->append(p);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
