Title: [210475] trunk/Source/WebKit2
- Revision
- 210475
- Author
- [email protected]
- Date
- 2017-01-06 23:42:19 -0800 (Fri, 06 Jan 2017)
Log Message
Attempt to fix the EFL build following <http://trac.webkit.org/changeset/210461>
(https://bugs.webkit.org/show_bug.cgi?id=166781)
* UIProcess/API/C/WKWebsitePolicies.cpp:
(WKWebsitePoliciesGetAutoplayPolicy): Invoke ASSERT_NOT_REACHED() and return kWKWebsiteAutoplayPolicyUseHeuristics
if the specified policy is not covered by a switch case.
(WKWebsitePoliciesSetAutoplayPolicy): Substituted "return" for "break" in each switch case and
invoke ASSERT_NOT_REACHED() if the specified policy is not covered by a switch case.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (210474 => 210475)
--- trunk/Source/WebKit2/ChangeLog 2017-01-07 07:14:03 UTC (rev 210474)
+++ trunk/Source/WebKit2/ChangeLog 2017-01-07 07:42:19 UTC (rev 210475)
@@ -1,3 +1,14 @@
+2017-01-06 Daniel Bates <[email protected]>
+
+ Attempt to fix the EFL build following <http://trac.webkit.org/changeset/210461>
+ (https://bugs.webkit.org/show_bug.cgi?id=166781)
+
+ * UIProcess/API/C/WKWebsitePolicies.cpp:
+ (WKWebsitePoliciesGetAutoplayPolicy): Invoke ASSERT_NOT_REACHED() and return kWKWebsiteAutoplayPolicyUseHeuristics
+ if the specified policy is not covered by a switch case.
+ (WKWebsitePoliciesSetAutoplayPolicy): Substituted "return" for "break" in each switch case and
+ invoke ASSERT_NOT_REACHED() if the specified policy is not covered by a switch case.
+
2017-01-06 Matt Rajca <[email protected]>
Add infrastructure for sending autoplay website policies to WebKit
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKWebsitePolicies.cpp (210474 => 210475)
--- trunk/Source/WebKit2/UIProcess/API/C/WKWebsitePolicies.cpp 2017-01-07 07:14:03 UTC (rev 210474)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKWebsitePolicies.cpp 2017-01-07 07:42:19 UTC (rev 210475)
@@ -62,6 +62,8 @@
case WebsiteAutoplayPolicy::UseHeuristics:
return kWKWebsiteAutoplayPolicyUseHeuristics;
}
+ ASSERT_NOT_REACHED();
+ return kWKWebsiteAutoplayPolicyUseHeuristics;
}
void WKWebsitePoliciesSetAutoplayPolicy(WKWebsitePoliciesRef websitePolicies, WKWebsiteAutoplayPolicy autoplayPolicy)
@@ -69,12 +71,13 @@
switch (autoplayPolicy) {
case kWKWebsiteAutoplayPolicyAlwaysAllow:
toImpl(websitePolicies)->setAutoplayPolicy(WebsiteAutoplayPolicy::AlwaysAllow);
- break;
+ return;
case kWKWebsiteAutoplayPolicyAlwaysDeny:
toImpl(websitePolicies)->setAutoplayPolicy(WebsiteAutoplayPolicy::AlwaysDeny);
- break;
+ return;
case kWKWebsiteAutoplayPolicyUseHeuristics:
toImpl(websitePolicies)->setAutoplayPolicy(WebsiteAutoplayPolicy::UseHeuristics);
- break;
+ return;
}
+ ASSERT_NOT_REACHED();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes