Title: [210569] trunk/Tools
- Revision
- 210569
- Author
- [email protected]
- Date
- 2017-01-10 17:28:00 -0800 (Tue, 10 Jan 2017)
Log Message
Reverting run-jsc-stress-tests' $buildType to use string values.
https://bugs.webkit.org/show_bug.cgi?id=166912
Rubber stamped by Filip Pizlo.
This is so that we can test for it in the tests e.g.
//@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
* Scripts/run-jsc-stress-tests:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (210568 => 210569)
--- trunk/Tools/ChangeLog 2017-01-11 01:22:21 UTC (rev 210568)
+++ trunk/Tools/ChangeLog 2017-01-11 01:28:00 UTC (rev 210569)
@@ -1,3 +1,15 @@
+2017-01-10 Mark Lam <[email protected]>
+
+ Reverting run-jsc-stress-tests' $buildType to use string values.
+ https://bugs.webkit.org/show_bug.cgi?id=166912
+
+ Rubber stamped by Filip Pizlo.
+
+ This is so that we can test for it in the tests e.g.
+ //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
+
+ * Scripts/run-jsc-stress-tests:
+
2017-01-10 Ryosuke Niwa <[email protected]>
Temporarily add back the file removed in r210463 to unbreak internal bots.
Modified: trunk/Tools/Scripts/run-jsc-stress-tests (210568 => 210569)
--- trunk/Tools/Scripts/run-jsc-stress-tests 2017-01-11 01:22:21 UTC (rev 210568)
+++ trunk/Tools/Scripts/run-jsc-stress-tests 2017-01-11 01:28:00 UTC (rev 210569)
@@ -117,7 +117,7 @@
$filter = nil
$envVars = []
$quickMode = false
-$buildType = :release
+$buildType = "release"
$forceCollectContinuously = false
def usage
@@ -231,9 +231,9 @@
when '--quick'
$quickMode = true
when '--debug'
- $buildType = :debug
+ $buildType = "debug"
when '--release'
- $buildType = :release
+ $buildType = "release"
end
}
@@ -257,7 +257,7 @@
unless jscArg
# If we're not provided a JSC path, try to come up with a sensible JSC path automagically.
command = SCRIPTS_PATH.join("webkit-build-directory").to_s
- command += ($buildType == :release) ? " --release" : " --debug"
+ command += ($buildType == "release") ? " --release" : " --debug"
command += " --executablePath"
output = `#{command}`.split("\n")
@@ -431,7 +431,7 @@
FTL_OPTIONS = ["--useFTLJIT=true"]
def shouldCollectContinuously?
- $buildType == :release or $forceCollectContinuously
+ $buildType == "release" or $forceCollectContinuously
end
COLLECT_CONTINUOUSLY_OPTIONS = shouldCollectContinuously? ? ["--collectContinuously=true", "--useGenerationalGC=false"] : []
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
