Title: [210679] trunk/Source/WebCore
- Revision
- 210679
- Author
- [email protected]
- Date
- 2017-01-12 13:26:48 -0800 (Thu, 12 Jan 2017)
Log Message
OneDrive application crashes upon launch
https://bugs.webkit.org/show_bug.cgi?id=166975
Patch by Youenn Fablet <[email protected]> on 2017-01-12
Reviewed by Brady Eidson.
Checking whether load is terminated just after calling ResourceLoader::willSendRequestInternal.
The reason is that delegate call may actually cancel the load at that point.
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequestInternal):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (210678 => 210679)
--- trunk/Source/WebCore/ChangeLog 2017-01-12 21:05:28 UTC (rev 210678)
+++ trunk/Source/WebCore/ChangeLog 2017-01-12 21:26:48 UTC (rev 210679)
@@ -1,3 +1,16 @@
+2017-01-12 Youenn Fablet <[email protected]>
+
+ OneDrive application crashes upon launch
+ https://bugs.webkit.org/show_bug.cgi?id=166975
+
+ Reviewed by Brady Eidson.
+
+ Checking whether load is terminated just after calling ResourceLoader::willSendRequestInternal.
+ The reason is that delegate call may actually cancel the load at that point.
+
+ * loader/SubresourceLoader.cpp:
+ (WebCore::SubresourceLoader::willSendRequestInternal):
+
2017-01-12 Jer Noble <[email protected]>
Protect MediaPlayer from being destroyed mid-load()
Modified: trunk/Source/WebCore/loader/SubresourceLoader.cpp (210678 => 210679)
--- trunk/Source/WebCore/loader/SubresourceLoader.cpp 2017-01-12 21:05:28 UTC (rev 210678)
+++ trunk/Source/WebCore/loader/SubresourceLoader.cpp 2017-01-12 21:26:48 UTC (rev 210679)
@@ -235,6 +235,10 @@
return;
ResourceLoader::willSendRequestInternal(newRequest, redirectResponse);
+
+ if (reachedTerminalState())
+ return;
+
if (newRequest.isNull()) {
cancel();
return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes