Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (210754 => 210755)
--- trunk/Websites/perf.webkit.org/ChangeLog 2017-01-14 01:32:50 UTC (rev 210754)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2017-01-14 02:53:57 UTC (rev 210755)
@@ -1,3 +1,102 @@
+2017-01-13 Ryosuke Niwa <[email protected]>
+
+ Instrument calls to render()
+ https://bugs.webkit.org/show_bug.cgi?id=167037
+
+ Reviewed by Sam Weinig.
+
+ Wrap every call to render() by newly added ComponentBase.updateRendering() to instrument it.
+ Also, use arrow functions instead of this.render.bind or regular closures for simplicity.
+
+ Currently, we're making 5100 calls to render() while opening the summary page, and that's way too high.
+
+ * public/v3/components/analysis-results-viewer.js:
+ (AnalysisResultsViewer.prototype._expandBetween):
+ * public/v3/components/bar-graph-group.js:
+ (BarGraphGroup.prototype.updateGroupRendering): Renamed form render() as BarGraphGroup is not a component.
+ * public/v3/components/base.js:
+ (ComponentBase.prototype.updateRendering): Added. Instruments render() call.
+ * public/v3/components/chart-pane-base.js:
+ (ChartPaneBase.prototype.fetchAnalysisTasks):
+ (ChartPaneBase.prototype._mainSelectionDidZoom):
+ (ChartPaneBase.prototype._updateStatus):
+ (ChartPaneBase.prototype._requestOpeningCommitViewer):
+ (ChartPaneBase.prototype._keyup):
+ (ChartPaneBase.prototype.render):
+ * public/v3/components/commit-log-viewer.js:
+ * public/v3/components/customizable-test-group-form.js:
+ (CustomizableTestGroupForm):
+ (CustomizableTestGroupForm.prototype._customize):
+ * public/v3/components/editable-text.js:
+ (EditableText.prototype._didUpdate):
+ * public/v3/components/pane-selector.js:
+ (PaneSelector.prototype._selectedItem):
+ * public/v3/components/results-table.js:
+ (ResultsTable.prototype.render):
+ * public/v3/components/time-series-chart.js:
+ (TimeSeriesChart._renderEnqueuedCharts):
+ * public/v3/pages/analysis-category-page.js:
+ (AnalysisCategoryPage.prototype.open):
+ (AnalysisCategoryPage.prototype.updateFromSerializedState):
+ (AnalysisCategoryPage.prototype.filterDidChange):
+ (AnalysisCategoryPage.prototype.render):
+ * public/v3/pages/analysis-task-page.js:
+ (AnalysisTaskChartPane.prototype._updateStatus):
+ (AnalysisTaskPage.prototype.updateFromSerializedState):
+ (AnalysisTaskPage.prototype._didFetchTask):
+ (AnalysisTaskPage.prototype._didFetchRelatedAnalysisTasks):
+ (AnalysisTaskPage.prototype._didFetchMeasurement):
+ (AnalysisTaskPage.prototype._didFetchTestGroups):
+ (AnalysisTaskPage.prototype._showAllTestGroups):
+ (AnalysisTaskPage.prototype._didFetchAnalysisResults):
+ (AnalysisTaskPage.prototype.render):
+ (AnalysisTaskPage.prototype._renderTestGroupList.):
+ (AnalysisTaskPage.prototype._renderTestGroupList):
+ (AnalysisTaskPage.prototype._createTestGroupListItem):
+ (AnalysisTaskPage.prototype._showTestGroup):
+ (AnalysisTaskPage.prototype._didStartEditingTaskName):
+ (AnalysisTaskPage.prototype._updateTaskName):
+ (AnalysisTaskPage.prototype._updateTestGroupName):
+ (AnalysisTaskPage.prototype._hideCurrentTestGroup):
+ (AnalysisTaskPage.prototype._updateChangeType):
+ (AnalysisTaskPage.prototype._associateBug):
+ (AnalysisTaskPage.prototype._dissociateBug):
+ (AnalysisTaskPage.prototype._associateCommit):
+ (AnalysisTaskPage.prototype._dissociateCommit):
+ (AnalysisTaskPage.prototype._chartSelectionDidChange):
+ (AnalysisTaskPage.prototype._selectedRowInAnalysisResultsViewer):
+ * public/v3/pages/build-request-queue-page.js:
+ (BuildRequestQueuePage.prototype.open.):
+ (BuildRequestQueuePage.prototype.open):
+ * public/v3/pages/chart-pane.js:
+ (ChartPane.prototype.setOpenRepository):
+ (ChartPane.prototype._trendLineTypeDidChange):
+ (ChartPane.prototype._updateTrendLine):
+ * public/v3/pages/charts-page.js:
+ (ChartsPage.prototype.updateFromSerializedState):
+ (ChartsPage.prototype._updateDomainsFromSerializedState):
+ (ChartsPage.prototype.setNumberOfDaysFromToolbar):
+ (ChartsPage.prototype._didMutatePaneList):
+ (ChartsPage.prototype.render):
+ * public/v3/pages/charts-toolbar.js:
+ (ChartsToolbar.prototype.render):
+ * public/v3/pages/create-analysis-task-page.js:
+ (CreateAnalysisTaskPage.prototype.updateFromSerializedState):
+ * public/v3/pages/dashboard-page.js:
+ (DashboardPage.prototype.updateFromSerializedState):
+ (DashboardPage.prototype._fetchedData):
+ * public/v3/pages/heading.js:
+ (Heading.prototype.render):
+ * public/v3/pages/page-with-heading.js:
+ (PageWithHeading.prototype.render):
+ * public/v3/pages/page.js:
+ (Page.prototype.open):
+ * public/v3/pages/summary-page.js:
+ (SummaryPage.prototype.open):
+ (SummaryPage.prototype.this._renderQueue.push):
+ (SummaryPage):
+ (SummaryPage.prototype._renderCell):
+
2017-01-12 Ryosuke Niwa <[email protected]>
Outliers are not hidden in v3 UI
Modified: trunk/Websites/perf.webkit.org/public/v3/components/analysis-results-viewer.js (210754 => 210755)
--- trunk/Websites/perf.webkit.org/public/v3/components/analysis-results-viewer.js 2017-01-14 01:32:50 UTC (rev 210754)
+++ trunk/Websites/perf.webkit.org/public/v3/components/analysis-results-viewer.js 2017-01-14 02:53:57 UTC (rev 210755)
@@ -260,7 +260,7 @@
for (var i = indexBeforeStart + 1; i < indexAfterEnd; i += increment)
this._expandedPoints.add(series.findPointByIndex(i));
this._shouldRenderTable = true;
- this.render();
+ this.updateRendering();
}
static htmlTemplate()
Modified: trunk/Websites/perf.webkit.org/public/v3/components/bar-graph-group.js (210754 => 210755)
--- trunk/Websites/perf.webkit.org/public/v3/components/bar-graph-group.js 2017-01-14 01:32:50 UTC (rev 210754)
+++ trunk/Websites/perf.webkit.org/public/v3/components/bar-graph-group.js 2017-01-14 02:53:57 UTC (rev 210755)
@@ -13,9 +13,9 @@
return newBar;
}
- render()
+ updateGroupRendering()
{
- Instrumentation.startMeasuringTime('BarGraphGroup', 'render');
+ Instrumentation.startMeasuringTime('BarGraphGroup', 'updateGroupRendering');
var min = Infinity;
var max = -Infinity;
@@ -35,10 +35,10 @@
var start = min - (range - diff) / 2;
entry.bar.update((value - start) / range, formattedValue);
- entry.bar.render();
+ entry.bar.updateRendering();
}
- Instrumentation.endMeasuringTime('BarGraphGroup', 'render');
+ Instrumentation.endMeasuringTime('BarGraphGroup', 'updateGroupRendering');
}
}
Modified: trunk/Websites/perf.webkit.org/public/v3/components/base.js (210754 => 210755)
--- trunk/Websites/perf.webkit.org/public/v3/components/base.js 2017-01-14 01:32:50 UTC (rev 210754)
+++ trunk/Websites/perf.webkit.org/public/v3/components/base.js 2017-01-14 02:53:57 UTC (rev 210755)
@@ -12,6 +12,13 @@
content() { return this._shadow; }
render() { }
+ updateRendering()
+ {
+ Instrumentation.startMeasuringTime('ComponentBase', 'updateRendering');
+ this.render();
+ Instrumentation.endMeasuringTime('ComponentBase', 'updateRendering');
+ }
+
renderReplace(element, content) { ComponentBase.renderReplace(element, content); }
static renderReplace(element, content)
Modified: trunk/Websites/perf.webkit.org/public/v3/components/chart-pane-base.js (210754 => 210755)
--- trunk/Websites/perf.webkit.org/public/v3/components/chart-pane-base.js 2017-01-14 01:32:50 UTC (rev 210754)
+++ trunk/Websites/perf.webkit.org/public/v3/components/chart-pane-base.js 2017-01-14 02:53:57 UTC (rev 210755)
@@ -96,7 +96,7 @@
AnalysisTask.fetchByPlatformAndMetric(this._platformId, this._metricId, noCache).then(function (tasks) {
self._tasksForAnnotations = tasks;
self._renderedAnnotations = false;
- self.render();
+ self.updateRendering();
});
}
@@ -132,7 +132,7 @@
{
this._overviewChart.setSelection(selection, this);
this._mainChart.setSelection(null);
- this.render();
+ this.updateRendering();
}
_indicatorDidChange(indicatorID, isLocked)
@@ -148,8 +148,9 @@
_updateStatus()
{
var range = this._mainChartStatus.updateRevisionList();
- this._commitLogViewer.view(range.repository, range.from, range.to).then(this.render.bind(this));
- this.render();
+ const updateRendering = () => { this.updateRendering(); };
+ this._commitLogViewer.view(range.repository, range.from, range.to).then(updateRendering);
+ updateRendering();
}
_openAnalysisTask(annotation)
@@ -164,8 +165,9 @@
_requestOpeningCommitViewer(repository, from, to)
{
this._mainChartStatus.setCurrentRepository(repository);
- this._commitLogViewer.view(repository, from, to).then(this.render.bind(this));
- this.render();
+ const updateRendering = () => { this.updateRendering(); };
+ this._commitLogViewer.view(repository, from, to).then(updateRendering);
+ updateRendering();
}
_keyup(event)
@@ -189,7 +191,7 @@
return;
}
- this.render();
+ this.updateRendering();
event.preventDefault();
event.stopPropagation();
@@ -215,12 +217,12 @@
this._renderAnnotations();
if (this._mainChartStatus)
- this._mainChartStatus.render();
+ this._mainChartStatus.updateRendering();
var body = this.content().querySelector('.chart-pane-body');
if (this._commitLogViewer && this._commitLogViewer.currentRepository()) {
body.classList.add('has-second-sidebar');
- this._commitLogViewer.render();
+ this._commitLogViewer.updateRendering();
} else
body.classList.remove('has-second-sidebar');
Modified: trunk/Websites/perf.webkit.org/public/v3/components/commit-log-viewer.js (210754 => 210755)
--- trunk/Websites/perf.webkit.org/public/v3/components/commit-log-viewer.js 2017-01-14 01:32:50 UTC (rev 210754)
+++ trunk/Websites/perf.webkit.org/public/v3/components/commit-log-viewer.js 2017-01-14 02:53:57 UTC (rev 210755)
@@ -31,7 +31,7 @@
if (!to) {
this._fetchingPromise = null;
- this.render();
+ this.updateRendering();
return Promise.resolve(null);
}
@@ -41,7 +41,7 @@
var self = this;
var spinnerTimer = setTimeout(function () {
- self.render();
+ self.updateRendering();
}, 300);
this._fetchingPromise.then(function (commits) {
Modified: trunk/Websites/perf.webkit.org/public/v3/components/customizable-test-group-form.js (210754 => 210755)
--- trunk/Websites/perf.webkit.org/public/v3/components/customizable-test-group-form.js 2017-01-14 01:32:50 UTC (rev 210754)
+++ trunk/Websites/perf.webkit.org/public/v3/components/customizable-test-group-form.js 2017-01-14 02:53:57 UTC (rev 210755)
@@ -8,7 +8,7 @@
this._renderedRepositorylist = null;
this._customized = false;
this._nameControl = this.content().querySelector('.name');
- this._nameControl._oninput_ = this.render.bind(this);
+ this._nameControl._oninput_ = () => { this.updateRendering(); }
this.content().querySelector('a')._onclick_ = this._customize.bind(this);
}
@@ -28,7 +28,7 @@
{
event.preventDefault();
this._customized = true;
- this.render();
+ this.updateRendering();
}
_computeRootSetMap()
Modified: trunk/Websites/perf.webkit.org/public/v3/components/editable-text.js (210754 => 210755)
--- trunk/Websites/perf.webkit.org/public/v3/components/editable-text.js 2017-01-14 01:32:50 UTC (rev 210754)
+++ trunk/Websites/perf.webkit.org/public/v3/components/editable-text.js 2017-01-14 02:53:57 UTC (rev 210755)
@@ -73,7 +73,7 @@
{
this._inEditingMode = false;
this._updatingPromise = null;
- this.render();
+ this.updateRendering();
}
static htmlTemplate()
Modified: trunk/Websites/perf.webkit.org/public/v3/components/pane-selector.js (210754 => 210755)
--- trunk/Websites/perf.webkit.org/public/v3/components/pane-selector.js 2017-01-14 01:32:50 UTC (rev 210754)
+++ trunk/Websites/perf.webkit.org/public/v3/components/pane-selector.js 2017-01-14 02:53:57 UTC (rev 210755)
@@ -167,7 +167,7 @@
if (data instanceof Metric && data.test().onlyContainsSingleMetric())
this._currentPath.splice(this._currentPath.length - 2, 1);
}
- this.render();
+ this.updateRendering();
}
setCallback(callback)
Modified: trunk/Websites/perf.webkit.org/public/v3/components/results-table.js (210754 => 210755)
--- trunk/Websites/perf.webkit.org/public/v3/components/results-table.js 2017-01-14 01:32:50 UTC (rev 210754)
+++ trunk/Websites/perf.webkit.org/public/v3/components/results-table.js 2017-01-14 02:53:57 UTC (rev 210755)
@@ -87,7 +87,7 @@
this.renderReplace(this.content().querySelector('.results-table-extra-repositories'),
extraRepositories.map(function (commit) { return element('li', commit.title()); }));
- barGraphGroup.render();
+ barGraphGroup.updateGroupRendering();
Instrumentation.endMeasuringTime('ResultsTable', 'render');
}
Modified: trunk/Websites/perf.webkit.org/public/v3/components/time-series-chart.js (210754 => 210755)
--- trunk/Websites/perf.webkit.org/public/v3/components/time-series-chart.js 2017-01-14 01:32:50 UTC (rev 210754)
+++ trunk/Websites/perf.webkit.org/public/v3/components/time-series-chart.js 2017-01-14 02:53:57 UTC (rev 210755)
@@ -69,7 +69,7 @@
static _renderEnqueuedCharts()
{
for (var chart of TimeSeriesChart._chartQueue)
- chart.render();
+ chart.updateRendering();
TimeSeriesChart._chartQueue = null;
}
Modified: trunk/Websites/perf.webkit.org/public/v3/pages/analysis-category-page.js (210754 => 210755)
--- trunk/Websites/perf.webkit.org/public/v3/pages/analysis-category-page.js 2017-01-14 01:32:50 UTC (rev 210754)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/analysis-category-page.js 2017-01-14 02:53:57 UTC (rev 210755)
@@ -23,10 +23,10 @@
var self = this;
AnalysisTask.fetchAll().then(function () {
self._fetched = true;
- self.render();
+ self.updateRendering();
}, function (error) {
self._errorMessage = 'Failed to fetch the list of analysis tasks: ' + error;
- self.render();
+ self.updateRendering();
});
super.open(state);
}
@@ -59,12 +59,12 @@
this._categoryToolbar.setFilter(state.filter);
if (!isOpen)
- this.render();
+ this.updateRendering();
}
filterDidChange(shouldUpdateState)
{
- this.render();
+ this.updateRendering();
if (shouldUpdateState)
this.scheduleUrlStateUpdate();
}
@@ -74,7 +74,7 @@
Instrumentation.startMeasuringTime('AnalysisCategoryPage', 'render');
super.render();
- this._categoryToolbar.render();
+ this._categoryToolbar.updateRendering();
if (this._errorMessage) {
console.assert(!this._fetched);
Modified: trunk/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js (210754 => 210755)
--- trunk/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js 2017-01-14 01:32:50 UTC (rev 210754)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js 2017-01-14 02:53:57 UTC (rev 210755)
@@ -19,7 +19,7 @@
_updateStatus()
{
super._updateStatus();
- this._page.render();
+ this._page.updateRendering();
}
selectedPoints()
@@ -101,7 +101,7 @@
var taskId = parseInt(state.remainingRoute);
AnalysisTask.fetchById(taskId).then(this._didFetchTask.bind(this), function (error) {
self._errorMessage = `Failed to fetch the analysis task ${state.remainingRoute}: ${error}`;
- self.render();
+ self.updateRendering();
});
this._fetchRelatedInfoForTaskId(taskId);
} else if (state.buildRequest) {
@@ -110,7 +110,7 @@
self._fetchRelatedInfoForTaskId(task.id());
}, function (error) {
self._errorMessage = `Failed to fetch the analysis task for the build request ${buildRequestId}: ${error}`;
- self.render();
+ self.updateRendering();
});
}
}
@@ -146,7 +146,7 @@
this._chartPane.setOverviewDomain(domain[0], domain[1]);
this._chartPane.setMainDomain(domain[0], domain[1]);
- this.render();
+ this.updateRendering();
return task;
}
@@ -154,7 +154,7 @@
_didFetchRelatedAnalysisTasks(relatedTasks)
{
this._relatedTasks = relatedTasks;
- this.render();
+ this.updateRendering();
}
_didFetchMeasurement()
@@ -171,7 +171,7 @@
this._startPoint = startPoint;
this._endPoint = endPoint;
- this.render();
+ this.updateRendering();
}
_didFetchTestGroups(testGroups)
@@ -179,7 +179,7 @@
this._testGroups = testGroups.sort(function (a, b) { return +a.createdAt() - b.createdAt(); });
this._didUpdateTestGroupHiddenState();
this._assignTestResultsIfPossible();
- this.render();
+ this.updateRendering();
}
_showAllTestGroups()
@@ -186,7 +186,7 @@
{
this._showHiddenTestGroups = true;
this._didUpdateTestGroupHiddenState();
- this.render();
+ this.updateRendering();
}
_didUpdateTestGroupHiddenState()
@@ -206,7 +206,7 @@
{
this._analysisResults = results;
if (this._assignTestResultsIfPossible())
- this.render();
+ this.updateRendering();
}
_assignTestResultsIfPossible()
@@ -233,7 +233,7 @@
this.content().querySelector('.error-message').textContent = this._errorMessage || '';
- this._chartPane.render();
+ this._chartPane.updateRendering();
var element = ComponentBase.createElement;
var link = ComponentBase.createLink;
@@ -264,18 +264,18 @@
} else
repositoryList = Repository.sortByNamePreferringOnesWithURL(Repository.all());
- this._bugList.render();
+ this._bugList.updateRendering();
this._causeList.setKindList(repositoryList);
- this._causeList.render();
+ this._causeList.updateRendering();
this._fixList.setKindList(repositoryList);
- this._fixList.render();
+ this._fixList.updateRendering();
this.content().querySelector('.analysis-task-status').style.display = this._task ? null : 'none';
this.content().querySelector('.overview-chart').style.display = this._task ? null : 'none';
this.content().querySelector('.test-group-view').style.display = this._task && this._testGroups && this._testGroups.length ? null : 'none';
- this._taskNameLabel.render();
+ this._taskNameLabel.updateRendering();
if (this._relatedTasks && this._task) {
var router = this.router();
@@ -296,7 +296,7 @@
var a = selectedRange['A'];
var b = selectedRange['B'];
this._newTestGroupFormForViewer.setRootSetMap(a && b ? {'A': a.rootSet(), 'B': b.rootSet()} : null);
- this._newTestGroupFormForViewer.render();
+ this._newTestGroupFormForViewer.updateRendering();
this._newTestGroupFormForViewer.element().style.display = this._triggerable ? null : 'none';
this._renderTestGroupList();
@@ -308,13 +308,13 @@
var points = this._chartPane.selectedPoints();
this._newTestGroupFormForChart.setRootSetMap(points && points.length >= 2 ?
{'A': points[0].rootSet(), 'B': points[points.length - 1].rootSet()} : null);
- this._newTestGroupFormForChart.render();
+ this._newTestGroupFormForChart.updateRendering();
this._newTestGroupFormForChart.element().style.display = this._triggerable ? null : 'none';
this._analysisResultsViewer.setCurrentTestGroup(this._currentTestGroup);
- this._analysisResultsViewer.render();
+ this._analysisResultsViewer.updateRendering();
- this._testGroupResultsTable.render();
+ this._testGroupResultsTable.updateRendering();
Instrumentation.endMeasuringTime('AnalysisTaskPage', 'render');
}
@@ -356,7 +356,7 @@
for (var testGroup of this._filteredTestGroups) {
var label = this._testGroupLabelMap.get(testGroup);
label.setText(testGroup.label());
- label.render();
+ label.updateRendering();
}
}
}
@@ -364,7 +364,7 @@
_createTestGroupListItem(group)
{
var text = new EditableText(group.label());
- text.setStartedEditingCallback(function () { return text.render(); });
+ text.setStartedEditingCallback(() => { return text.updateRendering(); });
text.setUpdateCallback(this._updateTestGroupName.bind(this, group));
this._testGroupLabelMap.set(group, text);
@@ -408,7 +408,7 @@
this._renderedCurrentTestGroup = this._currentTestGroup;
}
- this._retryForm.render();
+ this._retryForm.updateRendering();
}
_showTestGroup(testGroup)
@@ -415,24 +415,23 @@
{
this._currentTestGroup = testGroup;
this._testGroupResultsTable.setTestGroup(this._currentTestGroup);
- this.render();
+ this.updateRendering();
}
_didStartEditingTaskName()
{
- this._taskNameLabel.render();
+ this._taskNameLabel.updateRendering();
}
_updateTaskName()
{
console.assert(this._task);
- this._taskNameLabel.render();
+ this._taskNameLabel.updateRendering();
- var self = this;
- return self._task.updateName(self._taskNameLabel.editedText()).then(function () {
- self.render();
- }, function (error) {
- self.render();
+ return this._task.updateName(this._taskNameLabel.editedText()).then(() => {
+ this.updateRendering();
+ }, (error) => {
+ this.updateRendering();
alert('Failed to update the name: ' + error);
});
}
@@ -440,13 +439,12 @@
_updateTestGroupName(testGroup)
{
var label = this._testGroupLabelMap.get(testGroup);
- label.render();
+ label.updateRendering();
- var self = this;
- return testGroup.updateName(label.editedText()).then(function () {
- self.render();
- }, function (error) {
- self.render();
+ return testGroup.updateName(label.editedText()).then(() => {
+ this.updateRendering();
+ }, (error) => {
+ this.updateRendering();
alert('Failed to hide the test name: ' + error);
});
}
@@ -453,14 +451,13 @@
_hideCurrentTestGroup()
{
- var self = this;
console.assert(this._currentTestGroup);
- return this._currentTestGroup.updateHiddenFlag(!this._currentTestGroup.isHidden()).then(function () {
- self._didUpdateTestGroupHiddenState();
- self.render();
+ return this._currentTestGroup.updateHiddenFlag(!this._currentTestGroup.isHidden()).then(() => {
+ this._didUpdateTestGroupHiddenState();
+ this.updateRendering();
}, function (error) {
- self._mayHaveMutatedTestGroupHiddenState();
- self.render();
+ this._mayHaveMutatedTestGroupHiddenState();
+ this.updateRendering();
alert('Failed to update the group: ' + error);
});
}
@@ -474,9 +471,9 @@
if (newChangeType == 'unconfirmed')
newChangeType = null;
- var render = this.render.bind(this);
- return this._task.updateChangeType(newChangeType).then(render, function (error) {
- render();
+ const updateRendering = () => { this.updateRendering(); };
+ return this._task.updateChangeType(newChangeType).then(updateRendering, (error) => {
+ updateRendering();
alert('Failed to update the status: ' + error);
});
}
@@ -486,9 +483,9 @@
console.assert(tracker instanceof BugTracker);
bugNumber = parseInt(bugNumber);
- var render = this.render.bind(this);
- return this._task.associateBug(tracker, bugNumber).then(render, function (error) {
- render();
+ const updateRendering = () => { this.updateRendering(); };
+ return this._task.associateBug(tracker, bugNumber).then(updateRendering, (error) => {
+ updateRendering();
alert('Failed to associate the bug: ' + error);
});
}
@@ -495,9 +492,9 @@
_dissociateBug(bug)
{
- var render = this.render.bind(this);
- return this._task.dissociateBug(bug).then(render, function (error) {
- render();
+ const updateRendering = () => { this.updateRendering(); };
+ return this._task.dissociateBug(bug).then(updateRendering, (error) => {
+ updateRendering();
alert('Failed to dissociate the bug: ' + error);
});
}
@@ -504,9 +501,9 @@
_associateCommit(kind, repository, revision)
{
- var render = this.render.bind(this);
- return this._task.associateCommit(kind, repository, revision).then(render, function (error) {
- render();
+ const updateRendering = () => { this.updateRendering(); };
+ return this._task.associateCommit(kind, repository, revision).then(updateRendering, (error) => {
+ updateRendering();
if (error == 'AmbiguousRevision')
alert('There are multiple revisions that match the specified string: ' + revision);
else if (error == 'CommitNotFound')
@@ -518,9 +515,9 @@
_dissociateCommit(commit)
{
- var render = this.render.bind(this);
- return this._task.dissociateCommit(commit).then(render, function (error) {
- render();
+ const updateRendering = () => { this.updateRendering(); };
+ return this._task.dissociateCommit(commit).then(updateRendering, (error) => {
+ updateRendering();
alert('Failed to dissociate the commit: ' + error);
});
}
@@ -542,7 +539,7 @@
_chartSelectionDidChange()
{
this._selectionWasModifiedByUser = true;
- this.render();
+ this.updateRendering();
}
_createNewTestGroupFromChart(name, repetitionCount, rootSetMap)
@@ -552,7 +549,7 @@
_selectedRowInAnalysisResultsViewer()
{
- this.render();
+ this.updateRendering();
}
_createNewTestGroupFromViewer(name, repetitionCount, rootSetMap)
Modified: trunk/Websites/perf.webkit.org/public/v3/pages/build-request-queue-page.js (210754 => 210755)
--- trunk/Websites/perf.webkit.org/public/v3/pages/build-request-queue-page.js 2017-01-14 01:32:50 UTC (rev 210754)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/build-request-queue-page.js 2017-01-14 02:53:57 UTC (rev 210755)
@@ -18,16 +18,16 @@
BuildRequest.fetchForTriggerable(entry.name).then(function (requests) {
triggerable.buildRequests = requests;
- self.render();
+ self.updateRendering();
});
return triggerable;
});
- self.render();
+ self.updateRendering();
});
AnalysisTask.fetchAll().then(function () {
- self.render();
+ self.updateRendering();
});
super.open(state);
Modified: trunk/Websites/perf.webkit.org/public/v3/pages/chart-pane.js (210754 => 210755)
--- trunk/Websites/perf.webkit.org/public/v3/pages/chart-pane.js 2017-01-14 01:32:50 UTC (rev 210754)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/chart-pane.js 2017-01-14 02:53:57 UTC (rev 210755)
@@ -186,8 +186,8 @@
{
if (repository != this._commitLogViewer.currentRepository()) {
var range = this._mainChartStatus.setCurrentRepository(repository);
- this._commitLogViewer.view(repository, range.from, range.to).then(this.render.bind(this));
- this.render();
+ this._commitLogViewer.view(repository, range.from, range.to).then(() => { this.updateRendering(); });
+ this.updateRendering();
}
}
@@ -448,7 +448,7 @@
this._updateTrendLine();
this._chartsPage.graphOptionsDidChange();
- this.render();
+ this.updateRendering();
}
_defaultParametersForTrendLine(type)
@@ -493,7 +493,7 @@
if (!currentTrendLineType.execute) {
this._mainChart.clearTrendLines();
- this.render();
+ this.updateRendering();
} else {
// Wait for all trendlines to be ready. Otherwise we might see FOC when the domain is expanded.
Promise.all(sourceList.map(function (source, sourceIndex) {
@@ -502,7 +502,7 @@
self._mainChart.setTrendLine(sourceIndex, trendlineSeries);
});
})).then(function () {
- self.render();
+ self.updateRendering();
});
}
}
Modified: trunk/Websites/perf.webkit.org/public/v3/pages/charts-page.js (210754 => 210755)
--- trunk/Websites/perf.webkit.org/public/v3/pages/charts-page.js 2017-01-14 01:32:50 UTC (rev 210754)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/charts-page.js 2017-01-14 02:53:57 UTC (rev 210755)
@@ -79,7 +79,7 @@
if (newPaneList) {
this._paneList = newPaneList;
this._paneListChanged = true;
- this.render();
+ this.updateRendering();
}
this._updateDomainsFromSerializedState(state);
@@ -109,7 +109,7 @@
since = zoom[0] - (zoom[1] - zoom[0]) / 2;
this.toolbar().setStartTime(since);
- this.toolbar().render();
+ this.toolbar().updateRendering();
this._mainDomain = zoom || null;
@@ -151,7 +151,7 @@
setNumberOfDaysFromToolbar(numberOfDays, shouldUpdateState)
{
this.toolbar().setNumberOfDays(numberOfDays, true);
- this.toolbar().render();
+ this.toolbar().updateRendering();
this._updateOverviewDomain();
this._updateMainDomain();
if (shouldUpdateState)
@@ -298,7 +298,7 @@
this._updateOverviewDomain();
this._updateMainDomain();
}
- this.render();
+ this.updateRendering();
this.scheduleUrlStateUpdate();
}
@@ -310,7 +310,7 @@
this.renderReplace(this.content().querySelector('.pane-list'), this._paneList);
for (var pane of this._paneList)
- pane.render();
+ pane.updateRendering();
this._paneListChanged = false;
}
Modified: trunk/Websites/perf.webkit.org/public/v3/pages/charts-toolbar.js (210754 => 210755)
--- trunk/Websites/perf.webkit.org/public/v3/pages/charts-toolbar.js 2017-01-14 01:32:50 UTC (rev 210754)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/charts-toolbar.js 2017-01-14 02:53:57 UTC (rev 210755)
@@ -34,7 +34,7 @@
render()
{
super.render();
- this._paneSelector.render();
+ this._paneSelector.updateRendering();
this._labelSpan.textContent = this._numberOfDays;
this._setInputElementValue(this._numberOfDays);
}
Modified: trunk/Websites/perf.webkit.org/public/v3/pages/create-analysis-task-page.js (210754 => 210755)
--- trunk/Websites/perf.webkit.org/public/v3/pages/create-analysis-task-page.js 2017-01-14 01:32:50 UTC (rev 210754)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/create-analysis-task-page.js 2017-01-14 02:53:57 UTC (rev 210755)
@@ -16,7 +16,7 @@
this._errorMessage = state.error;
if (!isOpen)
- this.render();
+ this.updateRendering();
}
render()
Modified: trunk/Websites/perf.webkit.org/public/v3/pages/dashboard-page.js (210754 => 210755)
--- trunk/Websites/perf.webkit.org/public/v3/pages/dashboard-page.js 2017-01-14 01:32:50 UTC (rev 210754)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/dashboard-page.js 2017-01-14 02:53:57 UTC (rev 210755)
@@ -35,7 +35,7 @@
this._needsTableConstruction = true;
if (!isOpen)
- this.render();
+ this.updateRendering();
}
open(state)
@@ -114,7 +114,7 @@
if (this._needsStatusUpdate) {
for (var statusView of this._statusViews)
- statusView.render();
+ statusView.updateRendering();
this._needsStatusUpdate = false;
}
}
@@ -155,7 +155,7 @@
return;
this._needsStatusUpdate = true;
- setTimeout(this.render.bind(this), 10);
+ setTimeout(() => { this.updateRendering(); }, 10);
}
static htmlTemplate()
Modified: trunk/Websites/perf.webkit.org/public/v3/pages/heading.js (210754 => 210755)
--- trunk/Websites/perf.webkit.org/public/v3/pages/heading.js 2017-01-14 01:32:50 UTC (rev 210754)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/heading.js 2017-01-14 02:53:57 UTC (rev 210755)
@@ -50,7 +50,7 @@
}
if (this._toolbar)
- this._toolbar.render();
+ this._toolbar.updateRendering();
var currentPage = this._router.currentPage();
if (this._renderedCurrentPage == currentPage)
Modified: trunk/Websites/perf.webkit.org/public/v3/pages/page-with-heading.js (210754 => 210755)
--- trunk/Websites/perf.webkit.org/public/v3/pages/page-with-heading.js 2017-01-14 01:32:50 UTC (rev 210754)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/page-with-heading.js 2017-01-14 02:53:57 UTC (rev 210755)
@@ -32,7 +32,7 @@
document.body.insertBefore(this.heading().element(), document.body.firstChild);
super.render();
- this.heading().render();
+ this.heading().updateRendering();
}
static htmlTemplate()
Modified: trunk/Websites/perf.webkit.org/public/v3/pages/page.js (210754 => 210755)
--- trunk/Websites/perf.webkit.org/public/v3/pages/page.js 2017-01-14 01:32:50 UTC (rev 210754)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/page.js 2017-01-14 02:53:57 UTC (rev 210755)
@@ -19,7 +19,7 @@
if (this._router)
this._router.pageDidOpen(this);
this.updateFromSerializedState(state, true);
- this.render();
+ this.updateRendering();
}
render()
Modified: trunk/Websites/perf.webkit.org/public/v3/pages/summary-page.js (210754 => 210755)
--- trunk/Websites/perf.webkit.org/public/v3/pages/summary-page.js 2017-01-14 01:32:50 UTC (rev 210754)
+++ trunk/Websites/perf.webkit.org/public/v3/pages/summary-page.js 2017-01-14 02:53:57 UTC (rev 210755)
@@ -36,7 +36,7 @@
var current = Date.now();
var timeRange = [current - 24 * 3600 * 1000, current];
for (var group of this._configGroups)
- group.fetchAndComputeSummary(timeRange).then(this.render.bind(this));
+ group.fetchAndComputeSummary(timeRange).then(() => { this.updateRendering(); });
}
render()
@@ -106,7 +106,7 @@
var ratioGraph = new RatioBarGraph();
if (configurationList.length == 0) {
- this._renderQueue.push(function () { ratioGraph.render(); });
+ this._renderQueue.push(() => { ratioGraph.updateRendering(); });
return element('td', ratioGraph);
}
@@ -128,7 +128,7 @@
var warningText = this._warningTextForGroup(configurationGroup);
anchor.title = warningText || 'Open charts';
ratioGraph.update(configurationGroup.ratio(), configurationGroup.label(), !!warningText);
- ratioGraph.render();
+ ratioGraph.updateRendering();
}
_warningTextForGroup(configurationGroup)
