Title: [98978] trunk
- Revision
- 98978
- Author
- [email protected]
- Date
- 2011-11-01 10:57:26 -0700 (Tue, 01 Nov 2011)
Log Message
[Chromium] Some media/video-*.html layout tests occasionally crash on WIN GPU
https://bugs.webkit.org/show_bug.cgi?id=71277
Reviewed by Simon Fraser.
Source/WebCore:
Disabled assert() in hasVisibleDescendant() until callers are fixed.
* rendering/RenderLayer.h:
(WebCore::RenderLayer::hasVisibleDescendant):
LayoutTests:
* platform/chromium/test_expectations.txt: revert tests marked as crash because of the assert().
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (98977 => 98978)
--- trunk/LayoutTests/ChangeLog 2011-11-01 17:35:24 UTC (rev 98977)
+++ trunk/LayoutTests/ChangeLog 2011-11-01 17:57:26 UTC (rev 98978)
@@ -1,3 +1,12 @@
+2011-11-01 Andrey Kosyakov <[email protected]>
+
+ [Chromium] Some media/video-*.html layout tests occasionally crash on WIN GPU
+ https://bugs.webkit.org/show_bug.cgi?id=71277
+
+ Reviewed by Simon Fraser.
+
+ * platform/chromium/test_expectations.txt: revert tests marked as crash because of the assert().
+
2011-11-01 Erik Arvidsson <[email protected]>
Unreviewed. Fix ChangeLog which broke in r98733.
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98977 => 98978)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-01 17:35:24 UTC (rev 98977)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2011-11-01 17:57:26 UTC (rev 98978)
@@ -6,7 +6,7 @@
// SLOW TESTS
// -----------------------------------------------------------------
-BUGCR24182 SLOW SNOWLEOPARD DEBUG : fast/css/large-list-of-rules-crash.html = PASS
+BUGCR24182 SLOW MAC DEBUG : fast/css/large-list-of-rules-crash.html = PASS
BUGCR24182 SLOW LINUX MAC DEBUG : fast/dom/Window/window-postmessage-clone-really-deep-array.html = PASS
BUGCR24182 SLOW MAC DEBUG : fast/forms/form-associated-element-crash3.html = PASS
BUGCR24182 SLOW SNOWLEOPARD DEBUG : fast/forms/select-set-length-with-mutation-remove.html = PASS
@@ -1131,6 +1131,7 @@
BUGWK70748 CPU : media/video-no-audio.html = IMAGE
BUGWK70748 CPU : media/video-playing-and-pause.html = IMAGE
BUGWK70748 CPU : media/video-volume-slider.html = IMAGE
+BUGWK70748 CPU : media/video-volume-slider.html = IMAGE
BUGWK70748 GPU : media/audio-controls-rendering.html = IMAGE
BUGWK70748 GPU : media/controls-after-reload.html = IMAGE
BUGWK70748 GPU : media/controls-strict.html = IMAGE
@@ -1141,6 +1142,7 @@
BUGWK70748 GPU : media/video-empty-source.html = IMAGE
BUGWK70748 GPU : media/video-no-audio.html = IMAGE
BUGWK70748 GPU : media/video-playing-and-pause.html = IMAGE
+BUGWK70748 GPU : media/video-volume-slider.html = IMAGE
BUGWK70748 CPU : svg/clip-path/clip-in-mask-objectBoundingBox.svg = IMAGE
BUGWK70748 CPU : svg/clip-path/clip-in-mask-userSpaceOnUse.svg = IMAGE
BUGWK70748 CPU : svg/clip-path/clip-path-clipped-evenodd-twice.svg = IMAGE
@@ -3676,6 +3678,7 @@
BUGWK68437 LEOPARD GPU : fast/canvas/image-pattern-rotate.html = IMAGE
BUGWK68437 LEOPARD GPU : fast/canvas/patternfill-repeat.html = IMAGE
BUGWK68437 LEOPARD GPU : fast/canvas/setWidthResetAfterForcedRender.html = IMAGE
+BUGWK68437 LEOPARD GPU : fast/canvas/shadow-offset-1.html = IMAGE
BUGWK68437 LEOPARD GPU : fast/canvas/shadow-offset-2.html = IMAGE
BUGWK68437 LEOPARD GPU : fast/canvas/shadow-offset-3.html = IMAGE
BUGWK68437 LEOPARD GPU : fast/canvas/shadow-offset-4.html = IMAGE
@@ -3935,10 +3938,6 @@
BUGWK71226 : fast/backgrounds/size/contain-and-cover-zoomed.html = IMAGE+TEXT
BUGWK71226 : fast/backgrounds/animated-svg-as-mask.html = IMAGE+TEXT IMAGE
-BUGWK71277 WIN GPU : media/video-source.html = CRASH PASS
-BUGWK71277 WIN GPU : media/video-src-change.html = CRASH PASS
-BUGWK71277 WIN GPU : media/video-transformed.html = CRASH PASS
-
BUGWK71278 SLOW WIN RELEASE : fast/events/dispatch-message-string-data.html = PASS
BUGWK71282 WIN DEBUG : inspector/extensions = CRASH PASS TIMEOUT
@@ -3946,6 +3945,3 @@
BUGWK71282 WIN DEBUG : http/tests/inspector/extensions-network-redirect.html = CRASH PASS TIMEOUT
BUGWK71282 WIN DEBUG : http/tests/inspector/extensions-useragent.html = CRASH PASS TIMEOUT
BUGWK71084 WIN DEBUG : http/tests/inspector/extensions-ignore-cache.html = CRASH FAIL CRASH
-
-BUGCASEQ GPU : media/video-volume-slider.html = IMAGE CRASH
-BUGCASEQ DEBUG GPU : fast/canvas/shadow-offset-1.html = IMAGE PASS CRASH
Modified: trunk/Source/WebCore/ChangeLog (98977 => 98978)
--- trunk/Source/WebCore/ChangeLog 2011-11-01 17:35:24 UTC (rev 98977)
+++ trunk/Source/WebCore/ChangeLog 2011-11-01 17:57:26 UTC (rev 98978)
@@ -1,3 +1,15 @@
+2011-11-01 Andrey Kosyakov <[email protected]>
+
+ [Chromium] Some media/video-*.html layout tests occasionally crash on WIN GPU
+ https://bugs.webkit.org/show_bug.cgi?id=71277
+
+ Reviewed by Simon Fraser.
+
+ Disabled assert() in hasVisibleDescendant() until callers are fixed.
+
+ * rendering/RenderLayer.h:
+ (WebCore::RenderLayer::hasVisibleDescendant):
+
2011-11-01 Mike Reed <[email protected]>
[skia] call readPixels on canvas instead of device (will be private on device soon) and check for error
Modified: trunk/Source/WebCore/rendering/RenderLayer.h (98977 => 98978)
--- trunk/Source/WebCore/rendering/RenderLayer.h 2011-11-01 17:35:24 UTC (rev 98977)
+++ trunk/Source/WebCore/rendering/RenderLayer.h 2011-11-01 17:57:26 UTC (rev 98978)
@@ -386,8 +386,9 @@
Vector<RenderLayer*>* normalFlowList() const { return m_normalFlowList; }
// FIXME: We should ASSERT(!m_visibleContentStatusDirty) here, but see https://bugs.webkit.org/show_bug.cgi?id=71044
+ // ditto for hasVisibleDescendant(), see https://bugs.webkit.org/show_bug.cgi?id=71277
bool hasVisibleContent() const { return m_hasVisibleContent; }
- bool hasVisibleDescendant() const { ASSERT(!m_visibleDescendantStatusDirty); return m_hasVisibleDescendant; }
+ bool hasVisibleDescendant() const { return m_hasVisibleDescendant; }
void setHasVisibleContent(bool);
void dirtyVisibleContentStatus();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
