Title: [210842] trunk/Source/WebCore
- Revision
- 210842
- Author
- [email protected]
- Date
- 2017-01-17 19:59:55 -0800 (Tue, 17 Jan 2017)
Log Message
Remove positionOutsideContainingSpecialElement
https://bugs.webkit.org/show_bug.cgi?id=167150
Reviewed by Antti Koivisto.
It is not used anymore.
No change in functionality.
* editing/htmlediting.cpp:
(WebCore::isFirstVisiblePositionInSpecialElement): Deleted.
(WebCore::isLastVisiblePositionInSpecialElement): Deleted.
(WebCore::positionOutsideContainingSpecialElement): Deleted.
* editing/htmlediting.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (210841 => 210842)
--- trunk/Source/WebCore/ChangeLog 2017-01-18 01:46:09 UTC (rev 210841)
+++ trunk/Source/WebCore/ChangeLog 2017-01-18 03:59:55 UTC (rev 210842)
@@ -1,3 +1,20 @@
+2017-01-17 Zalan Bujtas <[email protected]>
+
+ Remove positionOutsideContainingSpecialElement
+ https://bugs.webkit.org/show_bug.cgi?id=167150
+
+ Reviewed by Antti Koivisto.
+
+ It is not used anymore.
+
+ No change in functionality.
+
+ * editing/htmlediting.cpp:
+ (WebCore::isFirstVisiblePositionInSpecialElement): Deleted.
+ (WebCore::isLastVisiblePositionInSpecialElement): Deleted.
+ (WebCore::positionOutsideContainingSpecialElement): Deleted.
+ * editing/htmlediting.h:
+
2017-01-17 Chris Dumez <[email protected]>
Unreviewed, fix nits found after landing r210833.
Modified: trunk/Source/WebCore/editing/htmlediting.cpp (210841 => 210842)
--- trunk/Source/WebCore/editing/htmlediting.cpp 2017-01-18 01:46:09 UTC (rev 210841)
+++ trunk/Source/WebCore/editing/htmlediting.cpp 2017-01-18 03:59:55 UTC (rev 210842)
@@ -496,11 +496,6 @@
return nullptr;
}
-static bool isFirstVisiblePositionInSpecialElement(const Position& position)
-{
- return firstInSpecialElement(position);
-}
-
Position positionBeforeContainingSpecialElement(const Position& position, HTMLElement** containingSpecialElement)
{
auto* element = firstInSpecialElement(position);
@@ -514,11 +509,6 @@
return result;
}
-static bool isLastVisiblePositionInSpecialElement(const Position& position)
-{
- return lastInSpecialElement(position);
-}
-
Position positionAfterContainingSpecialElement(const Position& position, HTMLElement** containingSpecialElement)
{
auto* element = lastInSpecialElement(position);
@@ -532,15 +522,6 @@
return result;
}
-Position positionOutsideContainingSpecialElement(const Position& position, HTMLElement** containingSpecialElement)
-{
- if (isFirstVisiblePositionInSpecialElement(position))
- return positionBeforeContainingSpecialElement(position, containingSpecialElement);
- if (isLastVisiblePositionInSpecialElement(position))
- return positionAfterContainingSpecialElement(position, containingSpecialElement);
- return position;
-}
-
Element* isFirstPositionAfterTable(const VisiblePosition& position)
{
Position upstream(position.deepEquivalent().upstream());
Modified: trunk/Source/WebCore/editing/htmlediting.h (210841 => 210842)
--- trunk/Source/WebCore/editing/htmlediting.h 2017-01-18 01:46:09 UTC (rev 210841)
+++ trunk/Source/WebCore/editing/htmlediting.h 2017-01-18 03:59:55 UTC (rev 210842)
@@ -114,7 +114,6 @@
Position positionBeforeContainingSpecialElement(const Position&, HTMLElement** containingSpecialElement = nullptr);
Position positionAfterContainingSpecialElement(const Position&, HTMLElement** containingSpecialElement = nullptr);
-Position positionOutsideContainingSpecialElement(const Position&, HTMLElement** containingSpecialElement = nullptr);
Position firstPositionInOrBeforeNode(Node*);
Position lastPositionInOrAfterNode(Node*);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
