Title: [210858] trunk/Source/_javascript_Core
- Revision
- 210858
- Author
- [email protected]
- Date
- 2017-01-18 11:30:50 -0800 (Wed, 18 Jan 2017)
Log Message
JSObjectSetPrivate should not use jsCast<>
rdar://problem/30069096
Reviewed by Keith Miller.
* API/JSObjectRef.cpp:
(JSObjectSetPrivate):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/API/JSObjectRef.cpp (210857 => 210858)
--- trunk/Source/_javascript_Core/API/JSObjectRef.cpp 2017-01-18 19:27:48 UTC (rev 210857)
+++ trunk/Source/_javascript_Core/API/JSObjectRef.cpp 2017-01-18 19:30:50 UTC (rev 210858)
@@ -425,21 +425,21 @@
// Get wrapped object if proxied
if (classInfo->isSubClassOf(JSProxy::info())) {
- jsObject = jsCast<JSProxy*>(jsObject)->target();
+ jsObject = static_cast<JSProxy*>(jsObject)->target();
classInfo = jsObject->classInfo();
}
if (classInfo->isSubClassOf(JSCallbackObject<JSGlobalObject>::info())) {
- jsCast<JSCallbackObject<JSGlobalObject>*>(jsObject)->setPrivate(data);
+ static_cast<JSCallbackObject<JSGlobalObject>*>(jsObject)->setPrivate(data);
return true;
}
if (classInfo->isSubClassOf(JSCallbackObject<JSDestructibleObject>::info())) {
- jsCast<JSCallbackObject<JSDestructibleObject>*>(jsObject)->setPrivate(data);
+ static_cast<JSCallbackObject<JSDestructibleObject>*>(jsObject)->setPrivate(data);
return true;
}
#if JSC_OBJC_API_ENABLED
if (classInfo->isSubClassOf(JSCallbackObject<JSAPIWrapperObject>::info())) {
- jsCast<JSCallbackObject<JSAPIWrapperObject>*>(jsObject)->setPrivate(data);
+ static_cast<JSCallbackObject<JSAPIWrapperObject>*>(jsObject)->setPrivate(data);
return true;
}
#endif
Modified: trunk/Source/_javascript_Core/ChangeLog (210857 => 210858)
--- trunk/Source/_javascript_Core/ChangeLog 2017-01-18 19:27:48 UTC (rev 210857)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-01-18 19:30:50 UTC (rev 210858)
@@ -1,3 +1,13 @@
+2017-01-18 Filip Pizlo <[email protected]>
+
+ JSObjectSetPrivate should not use jsCast<>
+ rdar://problem/30069096
+
+ Reviewed by Keith Miller.
+
+ * API/JSObjectRef.cpp:
+ (JSObjectSetPrivate):
+
2017-01-18 Brian Burg <[email protected]>
Web Inspector: remove an unnecessary include in generated Objective-C Inspector protocol code
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
