Title: [210891] trunk/Source/_javascript_Core
- Revision
- 210891
- Author
- [email protected]
- Date
- 2017-01-18 14:53:39 -0800 (Wed, 18 Jan 2017)
Log Message
Only delete source provider caches on full collection
https://bugs.webkit.org/show_bug.cgi?id=167173
Reviewed by Andreas Kling.
They are currently often wiped and recreated during page loading due to eden collections.
It is not clear that tying the lifetime of these caches to gc makes sense at all but this
should at least help some.
* heap/Heap.cpp:
(JSC::Heap::deleteSourceProviderCaches):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (210890 => 210891)
--- trunk/Source/_javascript_Core/ChangeLog 2017-01-18 22:52:17 UTC (rev 210890)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-01-18 22:53:39 UTC (rev 210891)
@@ -1,3 +1,18 @@
+2017-01-18 Antti Koivisto <[email protected]>
+
+ Only delete source provider caches on full collection
+ https://bugs.webkit.org/show_bug.cgi?id=167173
+
+ Reviewed by Andreas Kling.
+
+ They are currently often wiped and recreated during page loading due to eden collections.
+
+ It is not clear that tying the lifetime of these caches to gc makes sense at all but this
+ should at least help some.
+
+ * heap/Heap.cpp:
+ (JSC::Heap::deleteSourceProviderCaches):
+
2017-01-18 Filip Pizlo <[email protected]>
JSObjectSetPrivate should not use jsCast<>
Modified: trunk/Source/_javascript_Core/heap/Heap.cpp (210890 => 210891)
--- trunk/Source/_javascript_Core/heap/Heap.cpp 2017-01-18 22:52:17 UTC (rev 210890)
+++ trunk/Source/_javascript_Core/heap/Heap.cpp 2017-01-18 22:53:39 UTC (rev 210891)
@@ -1679,7 +1679,8 @@
void Heap::deleteSourceProviderCaches()
{
- m_vm->clearSourceProviderCaches();
+ if (*m_lastCollectionScope == CollectionScope::Full)
+ m_vm->clearSourceProviderCaches();
}
void Heap::notifyIncrementalSweeper()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
