Title: [210911] trunk/Source/WebInspectorUI
- Revision
- 210911
- Author
- [email protected]
- Date
- 2017-01-18 21:09:49 -0800 (Wed, 18 Jan 2017)
Log Message
Web Inspector: split console should be allowed for Network and Timeline tabs when Inspector is not docked
https://bugs.webkit.org/show_bug.cgi?id=167075
Patch by Devin Rousso <[email protected]> on 2017-01-18
Reviewed by Timothy Hatcher.
* UserInterface/Base/Main.js:
(WebInspector.dockedConfigurationSupportsSplitContentBrowser):
Helper function to determine if the current docked state supports having the content view
and split console at the same time. Currently set to be true if not docked bottom.
* UserInterface/Views/ClusterContentView.js:
(WebInspector.ClusterContentView.prototype.get supportsSplitContentBrowser):
* UserInterface/Views/ContentView.js:
(WebInspector.ContentView.prototype.get supportsSplitContentBrowser):
* UserInterface/Views/NetworkTabContentView.js:
(WebInspector.NetworkTabContentView.prototype.get supportsSplitContentBrowser):
* UserInterface/Views/TimelineTabContentView.js:
(WebInspector.TimelineTabContentView.prototype.get supportsSplitContentBrowser): Deleted.
Update supportsSplitContentBrowser functions to only be true/false based on the return value
of WebInspector.dockedConfigurationSupportsSplitContentBrowser.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (210910 => 210911)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-01-19 05:06:10 UTC (rev 210910)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-01-19 05:09:49 UTC (rev 210911)
@@ -1,3 +1,26 @@
+2017-01-18 Devin Rousso <[email protected]>
+
+ Web Inspector: split console should be allowed for Network and Timeline tabs when Inspector is not docked
+ https://bugs.webkit.org/show_bug.cgi?id=167075
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Base/Main.js:
+ (WebInspector.dockedConfigurationSupportsSplitContentBrowser):
+ Helper function to determine if the current docked state supports having the content view
+ and split console at the same time. Currently set to be true if not docked bottom.
+
+ * UserInterface/Views/ClusterContentView.js:
+ (WebInspector.ClusterContentView.prototype.get supportsSplitContentBrowser):
+ * UserInterface/Views/ContentView.js:
+ (WebInspector.ContentView.prototype.get supportsSplitContentBrowser):
+ * UserInterface/Views/NetworkTabContentView.js:
+ (WebInspector.NetworkTabContentView.prototype.get supportsSplitContentBrowser):
+ * UserInterface/Views/TimelineTabContentView.js:
+ (WebInspector.TimelineTabContentView.prototype.get supportsSplitContentBrowser): Deleted.
+ Update supportsSplitContentBrowser functions to only be true/false based on the return value
+ of WebInspector.dockedConfigurationSupportsSplitContentBrowser.
+
2017-01-18 Joseph Pecoraro <[email protected]>
Web Inspector: console.table only works for the first 5 properties
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (210910 => 210911)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2017-01-19 05:06:10 UTC (rev 210910)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2017-01-19 05:09:49 UTC (rev 210911)
@@ -888,6 +888,11 @@
return !this.splitContentBrowser.element.classList.contains("hidden");
};
+WebInspector.dockedConfigurationSupportsSplitContentBrowser = function()
+{
+ return this._dockConfiguration !== WebInspector.DockConfiguration.Bottom;
+};
+
WebInspector.doesCurrentTabSupportSplitContentBrowser = function()
{
var currentContentView = this.tabBrowser.selectedTabContentView;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ClusterContentView.js (210910 => 210911)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ClusterContentView.js 2017-01-19 05:06:10 UTC (rev 210910)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ClusterContentView.js 2017-01-19 05:09:49 UTC (rev 210911)
@@ -57,7 +57,8 @@
{
if (this._contentViewContainer.currentContentView)
return this._contentViewContainer.currentContentView.supportsSplitContentBrowser;
- return true;
+
+ return super.supportsSplitContentBrowser;
}
shown()
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ContentView.js (210910 => 210911)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ContentView.js 2017-01-19 05:06:10 UTC (rev 210910)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ContentView.js 2017-01-19 05:09:49 UTC (rev 210911)
@@ -310,7 +310,7 @@
get supportsSplitContentBrowser()
{
// Implemented by subclasses.
- return true;
+ return WebInspector.dockedConfigurationSupportsSplitContentBrowser();
}
shown()
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTabContentView.js (210910 => 210911)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTabContentView.js 2017-01-19 05:06:10 UTC (rev 210910)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTabContentView.js 2017-01-19 05:09:49 UTC (rev 210911)
@@ -61,6 +61,8 @@
get supportsSplitContentBrowser()
{
+ // Since the Network tab has a real sidebar, showing the split console would cause items in
+ // the sidebar to be aligned with an item in the datagrid that isn't shown.
return false;
}
};
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js (210910 => 210911)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js 2017-01-19 05:06:10 UTC (rev 210910)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js 2017-01-19 05:09:49 UTC (rev 210911)
@@ -309,11 +309,6 @@
return representedObject instanceof WebInspector.TimelineRecording;
}
- get supportsSplitContentBrowser()
- {
- return false;
- }
-
// Protected
restoreFromCookie(cookie)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
