Title: [210949] trunk
Revision
210949
Author
[email protected]
Date
2017-01-19 19:23:50 -0800 (Thu, 19 Jan 2017)

Log Message

iterable<> should be enabled on WK1
https://bugs.webkit.org/show_bug.cgi?id=167221
<rdar://problem/30108531>

Reviewed by Youenn Fablet.

Source/_javascript_Core:

* runtime/CommonIdentifiers.h:

Source/WebCore:

* Modules/fetch/FetchHeaders.idl:
* bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodePrototype::finishCreation):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjPrototype::finishCreation):
* bindings/scripts/test/TestNode.idl:
* bindings/scripts/test/TestObj.idl:
* css/FontFaceSet.idl:
* dom/NodeList.idl:

Source/WebKit/mac:

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(-[WebPreferences setCustomElementsEnabled:]):
(-[WebPreferences DOMIteratorEnabled]): Deleted.
(-[WebPreferences setDOMIteratorEnabled:]): Deleted.
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Source/WebKit/win:

* Interfaces/IWebPreferencesPrivate.idl:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::setDOMIteratorEnabled): Deleted.
(WebPreferences::domIteratorEnabled): Deleted.
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged):

Source/WebKit2:

* Shared/WebPreferencesDefinitions.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):
* DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebPreferencesToConsistentValues):
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setDOMIteratorEnabled): Deleted.
* WebKitTestRunner/InjectedBundle/TestRunner.h:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (210948 => 210949)


--- trunk/Source/_javascript_Core/ChangeLog	2017-01-20 02:52:34 UTC (rev 210948)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-01-20 03:23:50 UTC (rev 210949)
@@ -1,3 +1,13 @@
+2017-01-19  Chris Dumez  <[email protected]>
+
+        iterable<> should be enabled on WK1
+        https://bugs.webkit.org/show_bug.cgi?id=167221
+        <rdar://problem/30108531>
+
+        Reviewed by Youenn Fablet.
+
+        * runtime/CommonIdentifiers.h:
+
 2017-01-19  Filip Pizlo  <[email protected]>
 
         Structure::pin() needs to be called while holding a lock

Modified: trunk/Source/_javascript_Core/runtime/CommonIdentifiers.h (210948 => 210949)


--- trunk/Source/_javascript_Core/runtime/CommonIdentifiers.h	2017-01-20 02:52:34 UTC (rev 210948)
+++ trunk/Source/_javascript_Core/runtime/CommonIdentifiers.h	2017-01-20 03:23:50 UTC (rev 210949)
@@ -40,7 +40,6 @@
     macro(Date) \
     macro(DateTimeFormat) \
     macro(DocumentTimeline) \
-    macro(DOMIterator) \
     macro(Error) \
     macro(EvalError) \
     macro(Function) \

Modified: trunk/Source/WebCore/ChangeLog (210948 => 210949)


--- trunk/Source/WebCore/ChangeLog	2017-01-20 02:52:34 UTC (rev 210948)
+++ trunk/Source/WebCore/ChangeLog	2017-01-20 03:23:50 UTC (rev 210949)
@@ -1,3 +1,21 @@
+2017-01-19  Chris Dumez  <[email protected]>
+
+        iterable<> should be enabled on WK1
+        https://bugs.webkit.org/show_bug.cgi?id=167221
+        <rdar://problem/30108531>
+
+        Reviewed by Youenn Fablet.
+
+        * Modules/fetch/FetchHeaders.idl:
+        * bindings/scripts/test/JS/JSTestNode.cpp:
+        (WebCore::JSTestNodePrototype::finishCreation):
+        * bindings/scripts/test/JS/JSTestObj.cpp:
+        (WebCore::JSTestObjPrototype::finishCreation):
+        * bindings/scripts/test/TestNode.idl:
+        * bindings/scripts/test/TestObj.idl:
+        * css/FontFaceSet.idl:
+        * dom/NodeList.idl:
+
 2017-01-19  Zalan Bujtas  <[email protected]>
 
         Simple line layout: Extend coverage for justified content.

Modified: trunk/Source/WebCore/Modules/fetch/FetchHeaders.idl (210948 => 210949)


--- trunk/Source/WebCore/Modules/fetch/FetchHeaders.idl	2017-01-20 02:52:34 UTC (rev 210948)
+++ trunk/Source/WebCore/Modules/fetch/FetchHeaders.idl	2017-01-20 03:23:50 UTC (rev 210949)
@@ -42,7 +42,7 @@
     [MayThrowException] boolean has(DOMString name);
     [MayThrowException] void set(DOMString name, DOMString value);
 
-    [EnabledAtRuntime=DOMIterator] iterable<DOMString, DOMString>;
+    iterable<DOMString, DOMString>;
 
     [ImplementedAs=append, MayThrowException, PrivateIdentifier] void appendFromJS(DOMString name, DOMString value);
     [ImplementedAs=fill, PrivateIdentifier] void fillFromJS(FetchHeaders? headers);

Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (210948 => 210949)


--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp	2017-01-20 02:52:34 UTC (rev 210948)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp	2017-01-20 03:23:50 UTC (rev 210949)
@@ -1897,8 +1897,7 @@
 #endif
     putDirect(vm, static_cast<JSVMClientData*>(vm.clientData)->builtinNames().privateMethodPrivateName(), JSFunction::create(vm, globalObject(), 0, String(), jsTestObjPrototypeFunctionPrivateMethod), ReadOnly | DontEnum);
     putDirect(vm, static_cast<JSVMClientData*>(vm.clientData)->builtinNames().publicAndPrivateMethodPrivateName(), JSFunction::create(vm, globalObject(), 0, String(), jsTestObjPrototypeFunctionPublicAndPrivateMethod), ReadOnly | DontEnum);
-    if (RuntimeEnabledFeatures::sharedFeatures().domIteratorEnabled())
-        addValueIterableMethods(*globalObject(), *this);
+    addValueIterableMethods(*globalObject(), *this);
     JSObject& unscopables = *constructEmptyObject(globalObject()->globalExec(), globalObject()->nullPrototypeObjectStructure());
     unscopables.putDirect(vm, Identifier::fromString(&vm, "voidMethod"), jsBoolean(true));
     unscopables.putDirect(vm, Identifier::fromString(&vm, "shortAttr"), jsBoolean(true));

Modified: trunk/Source/WebCore/bindings/scripts/test/TestObj.idl (210948 => 210949)


--- trunk/Source/WebCore/bindings/scripts/test/TestObj.idl	2017-01-20 02:52:34 UTC (rev 210948)
+++ trunk/Source/WebCore/bindings/scripts/test/TestObj.idl	2017-01-20 03:23:50 UTC (rev 210949)
@@ -114,7 +114,7 @@
     // TypedArray attribute
     attribute Float32Array typedArrayAttr;
 
-    [EnabledAtRuntime=DOMIterator] iterable<DOMString>;
+    iterable<DOMString>;
 
     // Methods
     [Unscopable] void voidMethod();

Modified: trunk/Source/WebCore/css/FontFaceSet.idl (210948 => 210949)


--- trunk/Source/WebCore/css/FontFaceSet.idl	2017-01-20 02:52:34 UTC (rev 210948)
+++ trunk/Source/WebCore/css/FontFaceSet.idl	2017-01-20 03:23:50 UTC (rev 210949)
@@ -35,7 +35,7 @@
     boolean has(FontFace font);
 
     // FIXME: We should add support for the setlike declaration.
-    [EnabledAtRuntime=DOMIterator] iterable<FontFace>;
+    iterable<FontFace>;
 
     readonly attribute long size;
 

Modified: trunk/Source/WebCore/dom/NodeList.idl (210948 => 210949)


--- trunk/Source/WebCore/dom/NodeList.idl	2017-01-20 02:52:34 UTC (rev 210948)
+++ trunk/Source/WebCore/dom/NodeList.idl	2017-01-20 03:23:50 UTC (rev 210949)
@@ -28,5 +28,5 @@
 ] interface NodeList {
     getter Node item(unsigned long index);
     readonly attribute unsigned long length;
-    [EnabledAtRuntime=DOMIterator] iterable<Node>;
+    iterable<Node>;
 };

Modified: trunk/Source/WebKit/mac/ChangeLog (210948 => 210949)


--- trunk/Source/WebKit/mac/ChangeLog	2017-01-20 02:52:34 UTC (rev 210948)
+++ trunk/Source/WebKit/mac/ChangeLog	2017-01-20 03:23:50 UTC (rev 210949)
@@ -1,5 +1,22 @@
 2017-01-19  Chris Dumez  <[email protected]>
 
+        iterable<> should be enabled on WK1
+        https://bugs.webkit.org/show_bug.cgi?id=167221
+        <rdar://problem/30108531>
+
+        Reviewed by Youenn Fablet.
+
+        * WebView/WebPreferenceKeysPrivate.h:
+        * WebView/WebPreferences.mm:
+        (-[WebPreferences setCustomElementsEnabled:]):
+        (-[WebPreferences DOMIteratorEnabled]): Deleted.
+        (-[WebPreferences setDOMIteratorEnabled:]): Deleted.
+        * WebView/WebPreferencesPrivate.h:
+        * WebView/WebView.mm:
+        (-[WebView _preferencesChanged:]):
+
+2017-01-19  Chris Dumez  <[email protected]>
+
         Make sure HTML validation bubble gets dismissed when its associated element's frame gets detached
         https://bugs.webkit.org/show_bug.cgi?id=167215
         <rdar://problem/29885052>

Modified: trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h (210948 => 210949)


--- trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h	2017-01-20 02:52:34 UTC (rev 210948)
+++ trunk/Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h	2017-01-20 03:23:50 UTC (rev 210949)
@@ -166,7 +166,6 @@
 #define WebKitMediaKeysStorageDirectoryKey @"WebKitMediaKeysStorageDirectory"
 #define WebKitShadowDOMEnabledPreferenceKey @"WebKitShadowDOMEnabled"
 #define WebKitCustomElementsEnabledPreferenceKey @"WebKitCustomElementsEnabled"
-#define WebKitDOMIteratorEnabledPreferenceKey @"WebKitDOMIteratorEnabled"
 #define WebKitFetchAPIEnabledPreferenceKey @"WebKitFetchAPIEnabled"
 #define WebKitDownloadAttributeEnabledPreferenceKey @"WebKitDownloadAttributeEnabled"
 #define WebKitCSSGridLayoutEnabledPreferenceKey @"WebKitCSSGridLayoutEnabled"

Modified: trunk/Source/WebKit/mac/WebView/WebPreferences.mm (210948 => 210949)


--- trunk/Source/WebKit/mac/WebView/WebPreferences.mm	2017-01-20 02:52:34 UTC (rev 210948)
+++ trunk/Source/WebKit/mac/WebView/WebPreferences.mm	2017-01-20 03:23:50 UTC (rev 210949)
@@ -2831,16 +2831,6 @@
     [self _setBoolValue:flag forKey:WebKitCustomElementsEnabledPreferenceKey];
 }
 
-- (BOOL)DOMIteratorEnabled
-{
-    return [self _boolValueForKey:WebKitDOMIteratorEnabledPreferenceKey];
-}
-
-- (void)setDOMIteratorEnabled:(BOOL)flag
-{
-    [self _setBoolValue:flag forKey:WebKitDOMIteratorEnabledPreferenceKey];
-}
-
 - (BOOL)fetchAPIEnabled
 {
     return [self _boolValueForKey:WebKitFetchAPIEnabledPreferenceKey];

Modified: trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h (210948 => 210949)


--- trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h	2017-01-20 02:52:34 UTC (rev 210948)
+++ trunk/Source/WebKit/mac/WebView/WebPreferencesPrivate.h	2017-01-20 03:23:50 UTC (rev 210949)
@@ -499,9 +499,6 @@
 - (void)setCustomElementsEnabled:(BOOL)flag;
 - (BOOL)customElementsEnabled;
 
-- (void)setDOMIteratorEnabled:(BOOL)flag;
-- (BOOL)DOMIteratorEnabled;
-
 - (void)setFetchAPIEnabled:(BOOL)flag;
 - (BOOL)fetchAPIEnabled;
 

Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (210948 => 210949)


--- trunk/Source/WebKit/mac/WebView/WebView.mm	2017-01-20 02:52:34 UTC (rev 210948)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm	2017-01-20 03:23:50 UTC (rev 210949)
@@ -2875,8 +2875,6 @@
 
     RuntimeEnabledFeatures::sharedFeatures().setInteractiveFormValidationEnabled([self interactiveFormValidationEnabled]);
 
-    RuntimeEnabledFeatures::sharedFeatures().setDOMIteratorEnabled([preferences DOMIteratorEnabled]);
-
     RuntimeEnabledFeatures::sharedFeatures().setModernMediaControlsEnabled([preferences modernMediaControlsEnabled]);
 
     RuntimeEnabledFeatures::sharedFeatures().setCustomElementsEnabled([preferences customElementsEnabled]);

Modified: trunk/Source/WebKit/win/ChangeLog (210948 => 210949)


--- trunk/Source/WebKit/win/ChangeLog	2017-01-20 02:52:34 UTC (rev 210948)
+++ trunk/Source/WebKit/win/ChangeLog	2017-01-20 03:23:50 UTC (rev 210949)
@@ -1,3 +1,20 @@
+2017-01-19  Chris Dumez  <[email protected]>
+
+        iterable<> should be enabled on WK1
+        https://bugs.webkit.org/show_bug.cgi?id=167221
+        <rdar://problem/30108531>
+
+        Reviewed by Youenn Fablet.
+
+        * Interfaces/IWebPreferencesPrivate.idl:
+        * WebPreferenceKeysPrivate.h:
+        * WebPreferences.cpp:
+        (WebPreferences::setDOMIteratorEnabled): Deleted.
+        (WebPreferences::domIteratorEnabled): Deleted.
+        * WebPreferences.h:
+        * WebView.cpp:
+        (WebView::notifyPreferencesChanged):
+
 2017-01-18  Alex Christensen  <[email protected]>
 
         Fix WinCairo build after r210845.

Modified: trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl (210948 => 210949)


--- trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl	2017-01-20 02:52:34 UTC (rev 210948)
+++ trunk/Source/WebKit/win/Interfaces/IWebPreferencesPrivate.idl	2017-01-20 03:23:50 UTC (rev 210949)
@@ -175,8 +175,6 @@
 {
     HRESULT showTiledScrollingIndicator([out, retval] BOOL* enabled);
     HRESULT setShowTiledScrollingIndicator([in] BOOL enabled);
-    HRESULT domIteratorEnabled([out, retval] BOOL* enabled);
-    HRESULT setDOMIteratorEnabled([in] BOOL enabled);
     HRESULT fetchAPIEnabled([out, retval] BOOL* enabled);
     HRESULT setFetchAPIEnabled([in] BOOL enabled);
     HRESULT shadowDOMEnabled([out, retval] BOOL* enabled);

Modified: trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h (210948 => 210949)


--- trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h	2017-01-20 02:52:34 UTC (rev 210948)
+++ trunk/Source/WebKit/win/WebPreferenceKeysPrivate.h	2017-01-20 03:23:50 UTC (rev 210949)
@@ -168,8 +168,6 @@
 
 #define WebKitShowTiledScrollingIndicatorPreferenceKey "WebKitShowTiledScrollingIndicator"
 
-#define WebKitDOMIteratorEnabledPreferenceKey "WebKitDOMIteratorEnabled"
-
 #define WebKitFetchAPIEnabledPreferenceKey "WebKitFetchAPIEnabled"
 
 #define WebKitShadowDOMEnabledPreferenceKey "WebKitShadowDOMEnabled"

Modified: trunk/Source/WebKit/win/WebPreferences.cpp (210948 => 210949)


--- trunk/Source/WebKit/win/WebPreferences.cpp	2017-01-20 02:52:34 UTC (rev 210948)
+++ trunk/Source/WebKit/win/WebPreferences.cpp	2017-01-20 03:23:50 UTC (rev 210949)
@@ -1947,20 +1947,6 @@
     return S_OK;
 }
 
-HRESULT WebPreferences::setDOMIteratorEnabled(BOOL enabled)
-{
-    setBoolValue(WebKitDOMIteratorEnabledPreferenceKey, enabled);
-    return S_OK;
-}
-
-HRESULT WebPreferences::domIteratorEnabled(_Out_ BOOL* enabled)
-{
-    if (!enabled)
-        return E_POINTER;
-    *enabled = boolValueForKey(WebKitDOMIteratorEnabledPreferenceKey);
-    return S_OK;
-}
-
 HRESULT WebPreferences::shadowDOMEnabled(_Out_ BOOL* enabled)
 {
     if (!enabled)

Modified: trunk/Source/WebKit/win/WebPreferences.h (210948 => 210949)


--- trunk/Source/WebKit/win/WebPreferences.h	2017-01-20 02:52:34 UTC (rev 210948)
+++ trunk/Source/WebKit/win/WebPreferences.h	2017-01-20 03:23:50 UTC (rev 210949)
@@ -234,8 +234,6 @@
     virtual HRESULT STDMETHODCALLTYPE setShowTiledScrollingIndicator(BOOL);
     virtual HRESULT STDMETHODCALLTYPE fetchAPIEnabled(_Out_ BOOL*);
     virtual HRESULT STDMETHODCALLTYPE setFetchAPIEnabled(BOOL);
-    virtual HRESULT STDMETHODCALLTYPE domIteratorEnabled(_Out_ BOOL*);
-    virtual HRESULT STDMETHODCALLTYPE setDOMIteratorEnabled(BOOL);
     virtual HRESULT STDMETHODCALLTYPE shadowDOMEnabled(_Out_ BOOL*);
     virtual HRESULT STDMETHODCALLTYPE setShadowDOMEnabled(BOOL);
     virtual HRESULT STDMETHODCALLTYPE customElementsEnabled(_Out_ BOOL*);

Modified: trunk/Source/WebKit/win/WebView.cpp (210948 => 210949)


--- trunk/Source/WebKit/win/WebView.cpp	2017-01-20 02:52:34 UTC (rev 210948)
+++ trunk/Source/WebKit/win/WebView.cpp	2017-01-20 03:23:50 UTC (rev 210949)
@@ -5232,11 +5232,6 @@
     RuntimeEnabledFeatures::sharedFeatures().setWebkitIndexedDBEnabled(true);
 #endif
 
-    hr = prefsPrivate->domIteratorEnabled(&enabled);
-    if (FAILED(hr))
-        return hr;
-    RuntimeEnabledFeatures::sharedFeatures().setDOMIteratorEnabled(!!enabled);
-
 #if ENABLE(FETCH_API)
     hr = prefsPrivate->fetchAPIEnabled(&enabled);
     if (FAILED(hr))

Modified: trunk/Source/WebKit2/ChangeLog (210948 => 210949)


--- trunk/Source/WebKit2/ChangeLog	2017-01-20 02:52:34 UTC (rev 210948)
+++ trunk/Source/WebKit2/ChangeLog	2017-01-20 03:23:50 UTC (rev 210949)
@@ -1,3 +1,17 @@
+2017-01-19  Chris Dumez  <[email protected]>
+
+        iterable<> should be enabled on WK1
+        https://bugs.webkit.org/show_bug.cgi?id=167221
+        <rdar://problem/30108531>
+
+        Reviewed by Youenn Fablet.
+
+        * Shared/WebPreferencesDefinitions.h:
+        * WebProcess/InjectedBundle/InjectedBundle.cpp:
+        (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::updatePreferences):
+
 2017-01-19  Alex Christensen  <[email protected]>
 
         Construct URLSearchParams from array or object

Modified: trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h (210948 => 210949)


--- trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h	2017-01-20 02:52:34 UTC (rev 210948)
+++ trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h	2017-01-20 03:23:50 UTC (rev 210949)
@@ -233,7 +233,6 @@
     macro(MockCaptureDevicesEnabled, mockCaptureDevicesEnabled, Bool, bool, false, "", "") \
     macro(MediaCaptureRequiresSecureConnection, mediaCaptureRequiresSecureConnection, Bool, bool, true, "", "") \
     macro(ShadowDOMEnabled, shadowDOMEnabled, Bool, bool, true, "Shadow DOM", "HTML Shadow DOM prototype") \
-    macro(DOMIteratorEnabled, domIteratorEnabled, Bool, bool, true, "", "") \
     macro(FetchAPIEnabled, fetchAPIEnabled, Bool, bool, true, "", "") \
     macro(DownloadAttributeEnabled, downloadAttributeEnabled, Bool, bool, true, "", "") \
     macro(SelectionPaintingWithoutSelectionGapsEnabled, selectionPaintingWithoutSelectionGapsEnabled, Bool, bool, DEFAULT_SELECTION_PAINTING_WITHOUT_SELECTION_GAPS_ENABLED, "", "") \

Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp (210948 => 210949)


--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp	2017-01-20 02:52:34 UTC (rev 210948)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp	2017-01-20 03:23:50 UTC (rev 210949)
@@ -195,9 +195,6 @@
     if (preference == "WebKitShadowDOMEnabled")
         RuntimeEnabledFeatures::sharedFeatures().setShadowDOMEnabled(enabled);
 
-    if (preference == "WebKitDOMIteratorEnabled")
-        RuntimeEnabledFeatures::sharedFeatures().setDOMIteratorEnabled(enabled);
-
 #if ENABLE(CSS_GRID_LAYOUT)
     if (preference == "WebKitCSSGridLayoutEnabled")
         RuntimeEnabledFeatures::sharedFeatures().setCSSGridLayoutEnabled(enabled);

Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (210948 => 210949)


--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp	2017-01-20 02:52:34 UTC (rev 210948)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp	2017-01-20 03:23:50 UTC (rev 210949)
@@ -3230,8 +3230,6 @@
 
     RuntimeEnabledFeatures::sharedFeatures().setInteractiveFormValidationEnabled(store.getBoolValueForKey(WebPreferencesKey::interactiveFormValidationEnabledKey()));
 
-    RuntimeEnabledFeatures::sharedFeatures().setDOMIteratorEnabled(store.getBoolValueForKey(WebPreferencesKey::domIteratorEnabledKey()));
-
     // Experimental Features.
 
 #if ENABLE(CSS_GRID_LAYOUT)

Modified: trunk/Tools/ChangeLog (210948 => 210949)


--- trunk/Tools/ChangeLog	2017-01-20 02:52:34 UTC (rev 210948)
+++ trunk/Tools/ChangeLog	2017-01-20 03:23:50 UTC (rev 210949)
@@ -1,3 +1,21 @@
+2017-01-19  Chris Dumez  <[email protected]>
+
+        iterable<> should be enabled on WK1
+        https://bugs.webkit.org/show_bug.cgi?id=167221
+        <rdar://problem/30108531>
+
+        Reviewed by Youenn Fablet.
+
+        * DumpRenderTree/mac/DumpRenderTree.mm:
+        (resetWebPreferencesToConsistentValues):
+        * DumpRenderTree/win/DumpRenderTree.cpp:
+        (resetWebPreferencesToConsistentValues):
+        * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
+        (WTR::InjectedBundle::beginTesting):
+        * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
+        (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
+        * WebKitTestRunner/InjectedBundle/TestRunner.h:
+
 2017-01-19  Aakash Jain  <[email protected]>
 
         Ensure status server logs go to log file

Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (210948 => 210949)


--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm	2017-01-20 02:52:34 UTC (rev 210948)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm	2017-01-20 03:23:50 UTC (rev 210949)
@@ -985,8 +985,6 @@
     [preferences setShadowDOMEnabled:YES];
     [preferences setCustomElementsEnabled:YES];
 
-    [preferences setDOMIteratorEnabled:YES];
-
     [preferences setWebGL2Enabled:YES];
 
     [preferences setFetchAPIEnabled:YES];

Modified: trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp (210948 => 210949)


--- trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp	2017-01-20 02:52:34 UTC (rev 210948)
+++ trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp	2017-01-20 03:23:50 UTC (rev 210949)
@@ -856,7 +856,6 @@
     prefsPrivate3->setShadowDOMEnabled(TRUE);
     prefsPrivate3->setCustomElementsEnabled(TRUE);
 
-    prefsPrivate3->setDOMIteratorEnabled(TRUE);
     prefsPrivate3->setModernMediaControlsEnabled(FALSE);
 
     setAlwaysAcceptCookies(false);

Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp (210948 => 210949)


--- trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp	2017-01-20 02:52:34 UTC (rev 210948)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp	2017-01-20 03:23:50 UTC (rev 210949)
@@ -322,8 +322,6 @@
     m_testRunner->setShadowDOMEnabled(true);
     m_testRunner->setCustomElementsEnabled(true);
 
-    m_testRunner->setDOMIteratorEnabled(true);
-
     m_testRunner->setWebGL2Enabled(true);
 
     m_testRunner->setFetchAPIEnabled(true);

Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp (210948 => 210949)


--- trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp	2017-01-20 02:52:34 UTC (rev 210948)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp	2017-01-20 03:23:50 UTC (rev 210949)
@@ -380,13 +380,6 @@
     WKBundleOverrideBoolPreferenceForTestRunner(injectedBundle.bundle(), injectedBundle.pageGroup(), key.get(), enabled);
 }
 
-void TestRunner::setDOMIteratorEnabled(bool enabled)
-{
-    WKRetainPtr<WKStringRef> key(AdoptWK, WKStringCreateWithUTF8CString("WebKitDOMIteratorEnabled"));
-    auto& injectedBundle = InjectedBundle::singleton();
-    WKBundleOverrideBoolPreferenceForTestRunner(injectedBundle.bundle(), injectedBundle.pageGroup(), key.get(), enabled);
-}
-
 void TestRunner::setModernMediaControlsEnabled(bool enabled)
 {
     WKRetainPtr<WKStringRef> key(AdoptWK, WKStringCreateWithUTF8CString("WebKitModernMediaControlsEnabled"));

Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h (210948 => 210949)


--- trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h	2017-01-20 02:52:34 UTC (rev 210948)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/TestRunner.h	2017-01-20 03:23:50 UTC (rev 210949)
@@ -103,7 +103,6 @@
     void setXSSAuditorEnabled(bool);
     void setShadowDOMEnabled(bool);
     void setCustomElementsEnabled(bool);
-    void setDOMIteratorEnabled(bool);
     void setModernMediaControlsEnabled(bool);
     void setWebGL2Enabled(bool);
     void setFetchAPIEnabled(bool);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to