Diff
Modified: trunk/Source/WebCore/ChangeLog (211012 => 211013)
--- trunk/Source/WebCore/ChangeLog 2017-01-21 07:40:19 UTC (rev 211012)
+++ trunk/Source/WebCore/ChangeLog 2017-01-21 07:52:20 UTC (rev 211013)
@@ -1,3 +1,29 @@
+2017-01-20 Joseph Pecoraro <[email protected]>
+
+ Remove never changing IndexedDB RuntimeEnabledFeature
+ https://bugs.webkit.org/show_bug.cgi?id=167278
+
+ Reviewed by Darin Adler.
+
+ This RuntimeEnabledFeature flag is always true and there are
+ no existing ways to change it. So lets just remove it.
+
+ * Modules/indexeddb/DOMWindowIndexedDatabase.idl:
+ * Modules/indexeddb/IDBCursor.idl:
+ * Modules/indexeddb/IDBCursorWithValue.idl:
+ * Modules/indexeddb/IDBDatabase.idl:
+ * Modules/indexeddb/IDBFactory.idl:
+ * Modules/indexeddb/IDBIndex.idl:
+ * Modules/indexeddb/IDBKeyRange.idl:
+ * Modules/indexeddb/IDBObjectStore.idl:
+ * Modules/indexeddb/IDBOpenDBRequest.idl:
+ * Modules/indexeddb/IDBRequest.idl:
+ * Modules/indexeddb/IDBTransaction.idl:
+ * Modules/indexeddb/IDBVersionChangeEvent.idl:
+ * page/RuntimeEnabledFeatures.h:
+ (WebCore::RuntimeEnabledFeatures::setIndexedDBEnabled): Deleted.
+ (WebCore::RuntimeEnabledFeatures::indexedDBEnabled): Deleted.
+
2017-01-20 Carlos Garcia Campos <[email protected]>
[SOUP] Custom protocols don't work in private browsing mode
Modified: trunk/Source/WebCore/Modules/indexeddb/DOMWindowIndexedDatabase.idl (211012 => 211013)
--- trunk/Source/WebCore/Modules/indexeddb/DOMWindowIndexedDatabase.idl 2017-01-21 07:40:19 UTC (rev 211012)
+++ trunk/Source/WebCore/Modules/indexeddb/DOMWindowIndexedDatabase.idl 2017-01-21 07:52:20 UTC (rev 211013)
@@ -27,7 +27,7 @@
[
Conditional=INDEXED_DATABASE,
] partial interface DOMWindow {
- [EnabledAtRuntime=IndexedDB] readonly attribute IDBFactory indexedDB;
- [EnabledAtRuntime=IndexedDB, ImplementedAs=indexedDB] readonly attribute IDBFactory webkitIndexedDB;
+ readonly attribute IDBFactory indexedDB;
+ [ImplementedAs=indexedDB] readonly attribute IDBFactory webkitIndexedDB;
};
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBCursor.idl (211012 => 211013)
--- trunk/Source/WebCore/Modules/indexeddb/IDBCursor.idl 2017-01-21 07:40:19 UTC (rev 211012)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBCursor.idl 2017-01-21 07:52:20 UTC (rev 211013)
@@ -27,7 +27,6 @@
ActiveDOMObject,
Conditional=INDEXED_DATABASE,
CustomToJSObject,
- EnabledAtRuntime=IndexedDB,
JSCustomMarkFunction,
SkipVTableValidation,
] interface IDBCursor {
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBCursorWithValue.idl (211012 => 211013)
--- trunk/Source/WebCore/Modules/indexeddb/IDBCursorWithValue.idl 2017-01-21 07:40:19 UTC (rev 211012)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBCursorWithValue.idl 2017-01-21 07:52:20 UTC (rev 211013)
@@ -25,7 +25,6 @@
[
Conditional=INDEXED_DATABASE,
- EnabledAtRuntime=IndexedDB,
ActiveDOMObject,
SkipVTableValidation,
JSCustomMarkFunction,
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.idl (211012 => 211013)
--- trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.idl 2017-01-21 07:40:19 UTC (rev 211012)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.idl 2017-01-21 07:52:20 UTC (rev 211013)
@@ -27,7 +27,6 @@
[
Conditional=INDEXED_DATABASE,
ActiveDOMObject,
- EnabledAtRuntime=IndexedDB,
SkipVTableValidation,
] interface IDBDatabase : EventTarget {
readonly attribute DOMString name;
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBFactory.idl (211012 => 211013)
--- trunk/Source/WebCore/Modules/indexeddb/IDBFactory.idl 2017-01-21 07:40:19 UTC (rev 211012)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBFactory.idl 2017-01-21 07:52:20 UTC (rev 211013)
@@ -25,7 +25,6 @@
[
Conditional=INDEXED_DATABASE,
- EnabledAtRuntime=IndexedDB,
SkipVTableValidation,
] interface IDBFactory {
[CallWith=ScriptExecutionContext, MayThrowException] IDBOpenDBRequest open(DOMString name, [EnforceRange] optional unsigned long long version);
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBIndex.idl (211012 => 211013)
--- trunk/Source/WebCore/Modules/indexeddb/IDBIndex.idl 2017-01-21 07:40:19 UTC (rev 211012)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBIndex.idl 2017-01-21 07:52:20 UTC (rev 211013)
@@ -29,7 +29,6 @@
[
Conditional=INDEXED_DATABASE,
- EnabledAtRuntime=IndexedDB,
GenerateIsReachable=Impl,
JSCustomMarkFunction,
SkipVTableValidation,
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBKeyRange.idl (211012 => 211013)
--- trunk/Source/WebCore/Modules/indexeddb/IDBKeyRange.idl 2017-01-21 07:40:19 UTC (rev 211012)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBKeyRange.idl 2017-01-21 07:52:20 UTC (rev 211013)
@@ -26,7 +26,6 @@
[
Conditional=INDEXED_DATABASE,
ImplementationLacksVTable,
- EnabledAtRuntime=IndexedDB,
] interface IDBKeyRange {
[OverrideIDLType=IDLIDBKey] readonly attribute any lower;
[OverrideIDLType=IDLIDBKey] readonly attribute any upper;
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.idl (211012 => 211013)
--- trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.idl 2017-01-21 07:40:19 UTC (rev 211012)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.idl 2017-01-21 07:52:20 UTC (rev 211013)
@@ -29,7 +29,6 @@
[
Conditional=INDEXED_DATABASE,
- EnabledAtRuntime=IndexedDB,
GenerateIsReachable=Impl,
JSCustomMarkFunction,
SkipVTableValidation,
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBOpenDBRequest.idl (211012 => 211013)
--- trunk/Source/WebCore/Modules/indexeddb/IDBOpenDBRequest.idl 2017-01-21 07:40:19 UTC (rev 211012)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBOpenDBRequest.idl 2017-01-21 07:52:20 UTC (rev 211013)
@@ -27,7 +27,6 @@
Conditional=INDEXED_DATABASE,
JSGenerateToJSObject,
JSGenerateToNativeObject,
- EnabledAtRuntime=IndexedDB,
SkipVTableValidation,
] interface IDBOpenDBRequest : IDBRequest {
attribute EventHandler onblocked;
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBRequest.idl (211012 => 211013)
--- trunk/Source/WebCore/Modules/indexeddb/IDBRequest.idl 2017-01-21 07:40:19 UTC (rev 211012)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBRequest.idl 2017-01-21 07:52:20 UTC (rev 211013)
@@ -30,7 +30,6 @@
[
ActiveDOMObject,
Conditional=INDEXED_DATABASE,
- EnabledAtRuntime=IndexedDB,
GenerateIsReachable=Impl,
SkipVTableValidation,
] interface IDBRequest : EventTarget {
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.idl (211012 => 211013)
--- trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.idl 2017-01-21 07:40:19 UTC (rev 211012)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.idl 2017-01-21 07:52:20 UTC (rev 211013)
@@ -27,7 +27,6 @@
[
ActiveDOMObject,
Conditional=INDEXED_DATABASE,
- EnabledAtRuntime=IndexedDB,
JSCustomMarkFunction,
SkipVTableValidation,
] interface IDBTransaction : EventTarget {
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.idl (211012 => 211013)
--- trunk/Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.idl 2017-01-21 07:40:19 UTC (rev 211012)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.idl 2017-01-21 07:52:20 UTC (rev 211013)
@@ -26,7 +26,6 @@
// FIXME: This should be exposed to workers as well.
[
Conditional=INDEXED_DATABASE,
- EnabledAtRuntime=IndexedDB,
Constructor(DOMString type, optional IDBVersionChangeEventInit eventInitDict),
] interface IDBVersionChangeEvent : Event {
readonly attribute unsigned long long oldVersion;
Modified: trunk/Source/WebCore/page/RuntimeEnabledFeatures.h (211012 => 211013)
--- trunk/Source/WebCore/page/RuntimeEnabledFeatures.h 2017-01-21 07:40:19 UTC (rev 211012)
+++ trunk/Source/WebCore/page/RuntimeEnabledFeatures.h 2017-01-21 07:52:20 UTC (rev 211013)
@@ -74,12 +74,6 @@
void setModernMediaControlsEnabled(bool areEnabled) { m_areModernMediaControlsEnabled = areEnabled; }
bool modernMediaControlsEnabled() const { return m_areModernMediaControlsEnabled; }
-#if ENABLE(INDEXED_DATABASE)
- // FIXME: This is always enabled and nobody can even toggle it off. Remove?
- void setIndexedDBEnabled(bool isEnabled) { m_isIndexedDBEnabled = isEnabled; }
- bool indexedDBEnabled() const { return m_isIndexedDBEnabled; }
-#endif
-
#if ENABLE(INDEXED_DATABASE_IN_WORKERS)
void setIndexedDBWorkersEnabled(bool isEnabled) { m_isIndexedDBWorkersEnabled = isEnabled; }
bool indexedDBWorkersEnabled() const { return m_isIndexedDBWorkersEnabled; }
@@ -219,10 +213,6 @@
bool m_areCustomElementsEnabled { true };
bool m_inputEventsEnabled { true };
-#if ENABLE(INDEXED_DATABASE)
- bool m_isIndexedDBEnabled { true };
-#endif
-
#if ENABLE(INDEXED_DATABASE_IN_WORKERS)
bool m_isIndexedDBWorkersEnabled { true };
#endif
Modified: trunk/Source/WebKit/mac/ChangeLog (211012 => 211013)
--- trunk/Source/WebKit/mac/ChangeLog 2017-01-21 07:40:19 UTC (rev 211012)
+++ trunk/Source/WebKit/mac/ChangeLog 2017-01-21 07:52:20 UTC (rev 211013)
@@ -1,5 +1,15 @@
2017-01-20 Joseph Pecoraro <[email protected]>
+ Remove never changing IndexedDB RuntimeEnabledFeature
+ https://bugs.webkit.org/show_bug.cgi?id=167278
+
+ Reviewed by Darin Adler.
+
+ * WebView/WebView.mm:
+ (-[WebView _preferencesChanged:]):
+
+2017-01-20 Joseph Pecoraro <[email protected]>
+
Cleanup RuntimeEnabledFeatures
https://bugs.webkit.org/show_bug.cgi?id=167228
Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (211012 => 211013)
--- trunk/Source/WebKit/mac/WebView/WebView.mm 2017-01-21 07:40:19 UTC (rev 211012)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2017-01-21 07:52:20 UTC (rev 211013)
@@ -2867,10 +2867,6 @@
RuntimeEnabledFeatures::sharedFeatures().setGamepadsEnabled([preferences gamepadsEnabled]);
#endif
-#if ENABLE(INDEXED_DATABASE)
- RuntimeEnabledFeatures::sharedFeatures().setIndexedDBEnabled(true);
-#endif
-
RuntimeEnabledFeatures::sharedFeatures().setShadowDOMEnabled([preferences shadowDOMEnabled]);
RuntimeEnabledFeatures::sharedFeatures().setInteractiveFormValidationEnabled([self interactiveFormValidationEnabled]);
Modified: trunk/Source/WebKit/win/ChangeLog (211012 => 211013)
--- trunk/Source/WebKit/win/ChangeLog 2017-01-21 07:40:19 UTC (rev 211012)
+++ trunk/Source/WebKit/win/ChangeLog 2017-01-21 07:52:20 UTC (rev 211013)
@@ -1,5 +1,15 @@
2017-01-20 Joseph Pecoraro <[email protected]>
+ Remove never changing IndexedDB RuntimeEnabledFeature
+ https://bugs.webkit.org/show_bug.cgi?id=167278
+
+ Reviewed by Darin Adler.
+
+ * WebView.cpp:
+ (WebView::notifyPreferencesChanged):
+
+2017-01-20 Joseph Pecoraro <[email protected]>
+
Cleanup RuntimeEnabledFeatures
https://bugs.webkit.org/show_bug.cgi?id=167228
Modified: trunk/Source/WebKit/win/WebView.cpp (211012 => 211013)
--- trunk/Source/WebKit/win/WebView.cpp 2017-01-21 07:40:19 UTC (rev 211012)
+++ trunk/Source/WebKit/win/WebView.cpp 2017-01-21 07:52:20 UTC (rev 211013)
@@ -5228,10 +5228,6 @@
// FIXME: Add preferences for the runtime enabled features.
-#if ENABLE(INDEXED_DATABASE)
- RuntimeEnabledFeatures::sharedFeatures().setIndexedDBEnabled(true);
-#endif
-
#if ENABLE(FETCH_API)
hr = prefsPrivate->fetchAPIEnabled(&enabled);
if (FAILED(hr))
Modified: trunk/Source/WebKit2/ChangeLog (211012 => 211013)
--- trunk/Source/WebKit2/ChangeLog 2017-01-21 07:40:19 UTC (rev 211012)
+++ trunk/Source/WebKit2/ChangeLog 2017-01-21 07:52:20 UTC (rev 211013)
@@ -1,3 +1,13 @@
+2017-01-20 Joseph Pecoraro <[email protected]>
+
+ Remove never changing IndexedDB RuntimeEnabledFeature
+ https://bugs.webkit.org/show_bug.cgi?id=167278
+
+ Reviewed by Darin Adler.
+
+ * WebProcess/WebProcess.cpp:
+ (WebKit::m_resourceLoadStatisticsStorage):
+
2017-01-20 Carlos Garcia Campos <[email protected]>
[SOUP] Custom protocols don't work in private browsing mode
Modified: trunk/Source/WebKit2/WebProcess/WebProcess.cpp (211012 => 211013)
--- trunk/Source/WebKit2/WebProcess/WebProcess.cpp 2017-01-21 07:40:19 UTC (rev 211012)
+++ trunk/Source/WebKit2/WebProcess/WebProcess.cpp 2017-01-21 07:52:20 UTC (rev 211013)
@@ -100,7 +100,6 @@
#include <WebCore/ResourceLoadStatistics.h>
#include <WebCore/ResourceLoadStatisticsStore.h>
#include <WebCore/RuntimeApplicationChecks.h>
-#include <WebCore/RuntimeEnabledFeatures.h>
#include <WebCore/SchemeRegistry.h>
#include <WebCore/SecurityOrigin.h>
#include <WebCore/Settings.h>
@@ -191,10 +190,6 @@
m_plugInAutoStartOriginHashes.add(SessionID::defaultSessionID(), HashMap<unsigned, double>());
-#if ENABLE(INDEXED_DATABASE)
- RuntimeEnabledFeatures::sharedFeatures().setIndexedDBEnabled(true);
-#endif
-
ResourceLoadObserver::sharedObserver().setStatisticsStore(m_resourceLoadStatisticsStorage.copyRef());
m_resourceLoadStatisticsStorage->setNotificationCallback([this] {
if (m_statisticsChangedTimer.isActive())
