Title: [211037] trunk/Source/_javascript_Core
- Revision
- 211037
- Author
- [email protected]
- Date
- 2017-01-23 02:41:42 -0800 (Mon, 23 Jan 2017)
Log Message
_javascript_Core has a weak external symbol in it
https://bugs.webkit.org/show_bug.cgi?id=167282
Patch by Joseph Pecoraro <[email protected]> on 2017-01-23
Reviewed by Yusuke Suzuki.
* debugger/Debugger.cpp:
(JSC::Debugger::ProfilingClient::~ProfilingClient):
* debugger/Debugger.h:
Avoid possible weak external symbol.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (211036 => 211037)
--- trunk/Source/_javascript_Core/ChangeLog 2017-01-23 09:54:59 UTC (rev 211036)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-01-23 10:41:42 UTC (rev 211037)
@@ -1,3 +1,15 @@
+2017-01-23 Joseph Pecoraro <[email protected]>
+
+ _javascript_Core has a weak external symbol in it
+ https://bugs.webkit.org/show_bug.cgi?id=167282
+
+ Reviewed by Yusuke Suzuki.
+
+ * debugger/Debugger.cpp:
+ (JSC::Debugger::ProfilingClient::~ProfilingClient):
+ * debugger/Debugger.h:
+ Avoid possible weak external symbol.
+
2017-01-21 Chris Dumez <[email protected]>
_javascript_ for-of does not work on a lot of collection types (e.g. HTMLCollection)
Modified: trunk/Source/_javascript_Core/debugger/Debugger.cpp (211036 => 211037)
--- trunk/Source/_javascript_Core/debugger/Debugger.cpp 2017-01-23 09:54:59 UTC (rev 211036)
+++ trunk/Source/_javascript_Core/debugger/Debugger.cpp 2017-01-23 10:41:42 UTC (rev 211037)
@@ -118,6 +118,11 @@
Debugger& m_debugger;
};
+
+Debugger::ProfilingClient::~ProfilingClient()
+{
+}
+
Debugger::Debugger(VM& vm)
: m_vm(vm)
, m_pauseOnExceptionsState(DontPauseOnExceptions)
Modified: trunk/Source/_javascript_Core/debugger/Debugger.h (211036 => 211037)
--- trunk/Source/_javascript_Core/debugger/Debugger.h 2017-01-23 09:54:59 UTC (rev 211036)
+++ trunk/Source/_javascript_Core/debugger/Debugger.h 2017-01-23 10:41:42 UTC (rev 211037)
@@ -138,7 +138,7 @@
class ProfilingClient {
public:
- virtual ~ProfilingClient() { }
+ virtual ~ProfilingClient();
virtual bool isAlreadyProfiling() const = 0;
virtual double willEvaluateScript() = 0;
virtual void didEvaluateScript(double startTime, ProfilingReason) = 0;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
