Title: [211050] trunk/Source/ThirdParty
- Revision
- 211050
- Author
- [email protected]
- Date
- 2017-01-23 12:29:41 -0800 (Mon, 23 Jan 2017)
Log Message
gtest fails to link on Linux due to missing -lpthread
https://bugs.webkit.org/show_bug.cgi?id=167313
* gtest/CMakeLists.txt: Remove find_package(Threads) that was added in my last commit.
This is assumed to already happen in the platform cmake options file.
Modified Paths
Diff
Modified: trunk/Source/ThirdParty/ChangeLog (211049 => 211050)
--- trunk/Source/ThirdParty/ChangeLog 2017-01-23 20:21:40 UTC (rev 211049)
+++ trunk/Source/ThirdParty/ChangeLog 2017-01-23 20:29:41 UTC (rev 211050)
@@ -3,6 +3,14 @@
gtest fails to link on Linux due to missing -lpthread
https://bugs.webkit.org/show_bug.cgi?id=167313
+ * gtest/CMakeLists.txt: Remove find_package(Threads) that was added in my last commit.
+ This is assumed to already happen in the platform cmake options file.
+
+2017-01-23 Timothy Hatcher <[email protected]>
+
+ gtest fails to link on Linux due to missing -lpthread
+ https://bugs.webkit.org/show_bug.cgi?id=167313
+
Reviewed by Alex Christensen.
* gtest/CMakeLists.txt: Add call to find_package(Threads) before testing CMAKE_USE_PTHREADS_INIT.
Modified: trunk/Source/ThirdParty/gtest/CMakeLists.txt (211049 => 211050)
--- trunk/Source/ThirdParty/gtest/CMakeLists.txt 2017-01-23 20:21:40 UTC (rev 211049)
+++ trunk/Source/ThirdParty/gtest/CMakeLists.txt 2017-01-23 20:29:41 UTC (rev 211050)
@@ -45,8 +45,6 @@
WTF
)
-find_package(Threads)
-
if (CMAKE_USE_PTHREADS_INIT)
target_link_libraries(gtest ${CMAKE_THREAD_LIBS_INIT})
add_definitions(-DGTEST_HAS_PTHREAD=1)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
