Log Message
Web Inspector: Asserts seen opening and closing Remote Web Inspector windows https://bugs.webkit.org/show_bug.cgi?id=167316 <rdar://problem/28891161>
Patch by Joseph Pecoraro <[email protected]> on 2017-01-23 Reviewed by Alexey Proskuryakov. * UIProcess/RemoteWebInspectorProxy.cpp: (WebKit::RemoteWebInspectorProxy::createFrontendPageAndWindow): Assume read access, like the local web inspector, to Web Inspector resources. * WebProcess/WebPage/RemoteWebInspectorUI.cpp: (WebKit::RemoteWebInspectorUI::closeWindow): Clear ourselves as the inspector frontend client when closing.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (211053 => 211054)
--- trunk/Source/WebKit2/ChangeLog 2017-01-23 21:00:21 UTC (rev 211053)
+++ trunk/Source/WebKit2/ChangeLog 2017-01-23 21:08:02 UTC (rev 211054)
@@ -1,3 +1,19 @@
+2017-01-23 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Asserts seen opening and closing Remote Web Inspector windows
+ https://bugs.webkit.org/show_bug.cgi?id=167316
+ <rdar://problem/28891161>
+
+ Reviewed by Alexey Proskuryakov.
+
+ * UIProcess/RemoteWebInspectorProxy.cpp:
+ (WebKit::RemoteWebInspectorProxy::createFrontendPageAndWindow):
+ Assume read access, like the local web inspector, to Web Inspector resources.
+
+ * WebProcess/WebPage/RemoteWebInspectorUI.cpp:
+ (WebKit::RemoteWebInspectorUI::closeWindow):
+ Clear ourselves as the inspector frontend client when closing.
+
2017-01-20 Anders Carlsson <[email protected]>
When Safari reloads pages with Flash objects after Flash is installed, placeholders don't paint (but do work!)
Modified: trunk/Source/WebKit2/UIProcess/RemoteWebInspectorProxy.cpp (211053 => 211054)
--- trunk/Source/WebKit2/UIProcess/RemoteWebInspectorProxy.cpp 2017-01-23 21:00:21 UTC (rev 211053)
+++ trunk/Source/WebKit2/UIProcess/RemoteWebInspectorProxy.cpp 2017-01-23 21:08:02 UTC (rev 211054)
@@ -129,6 +129,7 @@
trackInspectorPage(m_inspectorPage);
m_inspectorPage->process().addMessageReceiver(Messages::RemoteWebInspectorProxy::messageReceiverName(), m_inspectorPage->pageID(), *this);
+ m_inspectorPage->process().assumeReadAccessToBaseURL(WebInspectorProxy::inspectorBaseURL());
}
void RemoteWebInspectorProxy::closeFrontendPageAndWindow()
Modified: trunk/Source/WebKit2/WebProcess/WebPage/RemoteWebInspectorUI.cpp (211053 => 211054)
--- trunk/Source/WebKit2/WebProcess/WebPage/RemoteWebInspectorUI.cpp 2017-01-23 21:00:21 UTC (rev 211053)
+++ trunk/Source/WebKit2/WebProcess/WebPage/RemoteWebInspectorUI.cpp 2017-01-23 21:08:02 UTC (rev 211054)
@@ -119,6 +119,8 @@
void RemoteWebInspectorUI::closeWindow()
{
+ m_page.corePage()->inspectorController().setInspectorFrontendClient(nullptr);
+
WebProcess::singleton().parentProcessConnection()->send(Messages::RemoteWebInspectorProxy::FrontendDidClose(), m_page.pageID());
}
_______________________________________________ webkit-changes mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-changes
