Title: [211063] trunk/Source/_javascript_Core
- Revision
- 211063
- Author
- [email protected]
- Date
- 2017-01-23 14:49:26 -0800 (Mon, 23 Jan 2017)
Log Message
ObjCCallbackFunction::destroy() should not use jsCast().
https://bugs.webkit.org/show_bug.cgi?id=167322
Reviewed by Filip Pizlo.
Since r210829, it is no longer correct for object destructors to use jsCast().
Fixed ObjCCallbackFunction::destroy() to use a static_cast instead.
* API/ObjCCallbackFunction.mm:
(JSC::ObjCCallbackFunction::destroy):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/API/ObjCCallbackFunction.mm (211062 => 211063)
--- trunk/Source/_javascript_Core/API/ObjCCallbackFunction.mm 2017-01-23 22:25:59 UTC (rev 211062)
+++ trunk/Source/_javascript_Core/API/ObjCCallbackFunction.mm 2017-01-23 22:49:26 UTC (rev 211063)
@@ -523,7 +523,7 @@
void ObjCCallbackFunction::destroy(JSCell* cell)
{
- ObjCCallbackFunction& function = *jsCast<ObjCCallbackFunction*>(cell);
+ ObjCCallbackFunction& function = *static_cast<ObjCCallbackFunction*>(cell);
function.impl()->destroy(*Heap::heap(cell));
function.~ObjCCallbackFunction();
}
Modified: trunk/Source/_javascript_Core/ChangeLog (211062 => 211063)
--- trunk/Source/_javascript_Core/ChangeLog 2017-01-23 22:25:59 UTC (rev 211062)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-01-23 22:49:26 UTC (rev 211063)
@@ -1,3 +1,16 @@
+2017-01-23 Mark Lam <[email protected]>
+
+ ObjCCallbackFunction::destroy() should not use jsCast().
+ https://bugs.webkit.org/show_bug.cgi?id=167322
+
+ Reviewed by Filip Pizlo.
+
+ Since r210829, it is no longer correct for object destructors to use jsCast().
+ Fixed ObjCCallbackFunction::destroy() to use a static_cast instead.
+
+ * API/ObjCCallbackFunction.mm:
+ (JSC::ObjCCallbackFunction::destroy):
+
2017-01-23 Michael Saboff <[email protected]>
IntlObject uses JSArray::tryCreateUninitialized in an unsafe way
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
