Title: [211081] trunk
- Revision
- 211081
- Author
- [email protected]
- Date
- 2017-01-24 02:29:21 -0800 (Tue, 24 Jan 2017)
Log Message
Remove always true syncXHRInDocumentsEnabled setting
https://bugs.webkit.org/show_bug.cgi?id=167359
Patch by Joseph Pecoraro <[email protected]> on 2017-01-24
Reviewed by Alex Christensen.
Source/WebCore:
Setting added by Chromium and never used by other ports.
* page/Settings.in:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::open):
LayoutTests:
* fast/xmlhttprequest/xmlhttprequest-sync-disabled-expected.txt: Removed.
* fast/xmlhttprequest/xmlhttprequest-sync-disabled.html: Removed.
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (211080 => 211081)
--- trunk/LayoutTests/ChangeLog 2017-01-24 10:04:27 UTC (rev 211080)
+++ trunk/LayoutTests/ChangeLog 2017-01-24 10:29:21 UTC (rev 211081)
@@ -1,3 +1,13 @@
+2017-01-24 Joseph Pecoraro <[email protected]>
+
+ Remove always true syncXHRInDocumentsEnabled setting
+ https://bugs.webkit.org/show_bug.cgi?id=167359
+
+ Reviewed by Alex Christensen.
+
+ * fast/xmlhttprequest/xmlhttprequest-sync-disabled-expected.txt: Removed.
+ * fast/xmlhttprequest/xmlhttprequest-sync-disabled.html: Removed.
+
2017-01-15 Yusuke Suzuki <[email protected]>
Add the support for nomodule attribute on script element
Deleted: trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-sync-disabled-expected.txt (211080 => 211081)
--- trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-sync-disabled-expected.txt 2017-01-24 10:04:27 UTC (rev 211080)
+++ trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-sync-disabled-expected.txt 2017-01-24 10:29:21 UTC (rev 211081)
@@ -1,11 +0,0 @@
-CONSOLE MESSAGE: line 1: Synchronous XMLHttpRequests are disabled for this page.
-This tests that synchronous XMLHttpRequests fail when they are disabled for documents.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS xhr.open("GET", "http://mydomain/", false) threw exception InvalidAccessError (DOM Exception 15): The object does not support the operation or argument..
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-sync-disabled.html (211080 => 211081)
--- trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-sync-disabled.html 2017-01-24 10:04:27 UTC (rev 211080)
+++ trunk/LayoutTests/fast/xmlhttprequest/xmlhttprequest-sync-disabled.html 2017-01-24 10:29:21 UTC (rev 211081)
@@ -1,22 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
- <script src=""
- <script>
- if ('internals' in window) {
- window.internals.settings.setSyncXHRInDocumentsEnabled(false);
- } else {
- document.write('This test depends on the syncXHRInDocumentsEnabled setting being false, so run in DumpRenderTree or manually enable it');
- }
-
- description('This tests that synchronous XMLHttpRequests fail when they are disabled for documents.');
- var xhr = new XMLHttpRequest();
- shouldThrow('xhr.open("GET", "http://mydomain/", false)');
- </script>
- <script src=""
-</head>
-<body>
- <div id="description"></div>
- <div id="console"></div>
-</body>
-</html>
Modified: trunk/Source/WebCore/ChangeLog (211080 => 211081)
--- trunk/Source/WebCore/ChangeLog 2017-01-24 10:04:27 UTC (rev 211080)
+++ trunk/Source/WebCore/ChangeLog 2017-01-24 10:29:21 UTC (rev 211081)
@@ -1,5 +1,18 @@
2017-01-24 Joseph Pecoraro <[email protected]>
+ Remove always true syncXHRInDocumentsEnabled setting
+ https://bugs.webkit.org/show_bug.cgi?id=167359
+
+ Reviewed by Alex Christensen.
+
+ Setting added by Chromium and never used by other ports.
+
+ * page/Settings.in:
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::open):
+
+2017-01-24 Joseph Pecoraro <[email protected]>
+
Remove always true antialiased2dCanvasEnabled setting
https://bugs.webkit.org/show_bug.cgi?id=167361
Modified: trunk/Source/WebCore/page/Settings.in (211080 => 211081)
--- trunk/Source/WebCore/page/Settings.in 2017-01-24 10:04:27 UTC (rev 211080)
+++ trunk/Source/WebCore/page/Settings.in 2017-01-24 10:29:21 UTC (rev 211081)
@@ -159,7 +159,6 @@
requestAnimationFrameEnabled initial=true
fixedPositionCreatesStackingContext initial=defaultFixedPositionCreatesStackingContext
-syncXHRInDocumentsEnabled initial=true
cookieEnabled initial=true
mediaEnabled initial=true
DOMPasteAllowed initial=false
Modified: trunk/Source/WebCore/xml/XMLHttpRequest.cpp (211080 => 211081)
--- trunk/Source/WebCore/xml/XMLHttpRequest.cpp 2017-01-24 10:04:27 UTC (rev 211080)
+++ trunk/Source/WebCore/xml/XMLHttpRequest.cpp 2017-01-24 10:29:21 UTC (rev 211081)
@@ -424,11 +424,6 @@
return Exception { SECURITY_ERR };
if (!async && scriptExecutionContext()->isDocument()) {
- if (document()->settings() && !document()->settings()->syncXHRInDocumentsEnabled()) {
- logConsoleError(scriptExecutionContext(), "Synchronous XMLHttpRequests are disabled for this page.");
- return Exception { INVALID_ACCESS_ERR };
- }
-
// Newer functionality is not available to synchronous requests in window contexts, as a spec-mandated
// attempt to discourage synchronous XHR use. responseType is one such piece of functionality.
// We'll only disable this functionality for HTTP(S) requests since sync requests for local protocols
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
