Diff
Modified: trunk/Source/WebCore/ChangeLog (211108 => 211109)
--- trunk/Source/WebCore/ChangeLog 2017-01-24 21:38:20 UTC (rev 211108)
+++ trunk/Source/WebCore/ChangeLog 2017-01-24 21:45:13 UTC (rev 211109)
@@ -1,3 +1,22 @@
+2017-01-24 Joseph Pecoraro <[email protected]>
+
+ Clean up Performance IDL interfaces so they are easier to read
+ https://bugs.webkit.org/show_bug.cgi?id=167378
+
+ Reviewed by Sam Weinig.
+
+ * page/Performance.idl:
+ * page/PerformanceEntry.idl:
+ * page/PerformanceMark.idl:
+ * page/PerformanceMeasure.idl:
+ Update spec links and use a typedef to match specs.
+
+ * page/PerformanceResourceTiming.cpp:
+ (WebCore::PerformanceResourceTiming::workerStart):
+ * page/PerformanceResourceTiming.h:
+ * page/PerformanceResourceTiming.idl:
+ Add the workerStart property which always returns 0 for non-workers.
+
2017-01-24 Zalan Bujtas <[email protected]>
Simple line layout: Add support for hyphen: auto.
Modified: trunk/Source/WebCore/page/Performance.idl (211108 => 211109)
--- trunk/Source/WebCore/page/Performance.idl 2017-01-24 21:38:20 UTC (rev 211108)
+++ trunk/Source/WebCore/page/Performance.idl 2017-01-24 21:45:13 UTC (rev 211109)
@@ -29,34 +29,36 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-// See: https://dvcs.w3.org/hg/webperf/raw-file/tip/specs/NavigationTiming/Overview.html
+// https://w3c.github.io/hr-time/
+
+typedef double DOMHighResTimeStamp;
+
[
Conditional=WEB_TIMING,
GenerateIsReachable=ImplFrame,
] interface Performance : EventTarget {
+
+ DOMHighResTimeStamp now();
+
+ // https://w3c.github.io/navigation-timing/
readonly attribute PerformanceNavigation navigation;
readonly attribute PerformanceTiming timing;
+ // https://w3c.github.io/performance-timeline/
[EnabledAtRuntime=ResourceTiming] PerformanceEntryList getEntries();
[EnabledAtRuntime=ResourceTiming] PerformanceEntryList getEntriesByType(DOMString entryType);
[EnabledAtRuntime=ResourceTiming] PerformanceEntryList getEntriesByName(DOMString name, optional DOMString entryType);
+ // https://w3c.github.io/resource-timing/
[EnabledAtRuntime=ResourceTiming] void clearResourceTimings();
[EnabledAtRuntime=ResourceTiming] void setResourceTimingBufferSize(unsigned long maxSize);
-
[EnabledAtRuntime=ResourceTiming] attribute EventHandler onresourcetimingbufferfull;
- // See http://www.w3.org/TR/2012/CR-user-timing-20120726/
-#if defined(ENABLE_USER_TIMING) && ENABLE_USER_TIMING
- [MayThrowException] void webkitMark(DOMString markName);
- void webkitClearMarks(optional DOMString markName);
-
- [MayThrowException] void webkitMeasure(DOMString measureName, optional DOMString startMark, optional DOMString endMark);
- void webkitClearMeasures(optional DOMString measureName);
-#endif
-
- // See http://www.w3.org/TR/hr-time/ for details.
- unrestricted double now();
+ // https://w3c.github.io/user-timing/
+ [Conditional=USER_TIMING, MayThrowException] void webkitMark(DOMString markName);
+ [Conditional=USER_TIMING] void webkitClearMarks(optional DOMString markName);
+ [Conditional=USER_TIMING, MayThrowException] void webkitMeasure(DOMString measureName, optional DOMString startMark, optional DOMString endMark);
+ [Conditional=USER_TIMING] void webkitClearMeasures(optional DOMString measureName);
};
typedef sequence<PerformanceEntry> PerformanceEntryList;
Modified: trunk/Source/WebCore/page/PerformanceEntry.idl (211108 => 211109)
--- trunk/Source/WebCore/page/PerformanceEntry.idl 2017-01-24 21:38:20 UTC (rev 211108)
+++ trunk/Source/WebCore/page/PerformanceEntry.idl 2017-01-24 21:45:13 UTC (rev 211109)
@@ -28,7 +28,10 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-// See: https://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PerformanceTimeline/Overview.html
+// https://w3c.github.io/performance-timeline/
+
+typedef double DOMHighResTimeStamp;
+
[
Conditional=WEB_TIMING,
EnabledAtRuntime=ResourceTiming,
@@ -36,6 +39,6 @@
] interface PerformanceEntry {
readonly attribute DOMString name;
readonly attribute DOMString entryType;
- readonly attribute unrestricted double startTime;
- readonly attribute unrestricted double duration;
+ readonly attribute DOMHighResTimeStamp startTime;
+ readonly attribute DOMHighResTimeStamp duration;
};
Modified: trunk/Source/WebCore/page/PerformanceMark.idl (211108 => 211109)
--- trunk/Source/WebCore/page/PerformanceMark.idl 2017-01-24 21:38:20 UTC (rev 211108)
+++ trunk/Source/WebCore/page/PerformanceMark.idl 2017-01-24 21:45:13 UTC (rev 211109)
@@ -23,6 +23,8 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
+// https://w3c.github.io/user-timing/
+
[
Conditional=USER_TIMING,
] interface PerformanceMark : PerformanceEntry {
Modified: trunk/Source/WebCore/page/PerformanceMeasure.idl (211108 => 211109)
--- trunk/Source/WebCore/page/PerformanceMeasure.idl 2017-01-24 21:38:20 UTC (rev 211108)
+++ trunk/Source/WebCore/page/PerformanceMeasure.idl 2017-01-24 21:45:13 UTC (rev 211109)
@@ -23,6 +23,8 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
+// https://w3c.github.io/user-timing/
+
[
Conditional=USER_TIMING,
] interface PerformanceMeasure : PerformanceEntry {
Modified: trunk/Source/WebCore/page/PerformanceResourceTiming.cpp (211108 => 211109)
--- trunk/Source/WebCore/page/PerformanceResourceTiming.cpp 2017-01-24 21:38:20 UTC (rev 211108)
+++ trunk/Source/WebCore/page/PerformanceResourceTiming.cpp 2017-01-24 21:45:13 UTC (rev 211109)
@@ -94,6 +94,11 @@
return m_initiatorType;
}
+double PerformanceResourceTiming::workerStart() const
+{
+ return 0.0;
+}
+
double PerformanceResourceTiming::redirectStart() const
{
if (!m_shouldReportDetails)
Modified: trunk/Source/WebCore/page/PerformanceResourceTiming.h (211108 => 211109)
--- trunk/Source/WebCore/page/PerformanceResourceTiming.h 2017-01-24 21:38:20 UTC (rev 211108)
+++ trunk/Source/WebCore/page/PerformanceResourceTiming.h 2017-01-24 21:45:13 UTC (rev 211109)
@@ -55,6 +55,7 @@
AtomicString initiatorType() const;
+ double workerStart() const;
double redirectStart() const;
double redirectEnd() const;
double fetchStart() const;
Modified: trunk/Source/WebCore/page/PerformanceResourceTiming.idl (211108 => 211109)
--- trunk/Source/WebCore/page/PerformanceResourceTiming.idl 2017-01-24 21:38:20 UTC (rev 211108)
+++ trunk/Source/WebCore/page/PerformanceResourceTiming.idl 2017-01-24 21:45:13 UTC (rev 211109)
@@ -28,7 +28,10 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-// See: https://dvcs.w3.org/hg/webperf/raw-file/tip/specs/ResourceTiming/Overview.html
+// https://w3c.github.io/resource-timing/
+
+typedef double DOMHighResTimeStamp;
+
[
Conditional=WEB_TIMING,
EnabledAtRuntime=ResourceTiming
@@ -35,15 +38,16 @@
] interface PerformanceResourceTiming : PerformanceEntry {
readonly attribute DOMString initiatorType;
- readonly attribute unrestricted double redirectStart;
- readonly attribute unrestricted double redirectEnd;
- readonly attribute unrestricted double fetchStart;
- readonly attribute unrestricted double domainLookupStart;
- readonly attribute unrestricted double domainLookupEnd;
- readonly attribute unrestricted double connectStart;
- readonly attribute unrestricted double connectEnd;
- readonly attribute unrestricted double secureConnectionStart;
- readonly attribute unrestricted double requestStart;
- readonly attribute unrestricted double responseStart;
- readonly attribute unrestricted double responseEnd;
+ readonly attribute DOMHighResTimeStamp workerStart;
+ readonly attribute DOMHighResTimeStamp redirectStart;
+ readonly attribute DOMHighResTimeStamp redirectEnd;
+ readonly attribute DOMHighResTimeStamp fetchStart;
+ readonly attribute DOMHighResTimeStamp domainLookupStart;
+ readonly attribute DOMHighResTimeStamp domainLookupEnd;
+ readonly attribute DOMHighResTimeStamp connectStart;
+ readonly attribute DOMHighResTimeStamp connectEnd;
+ readonly attribute DOMHighResTimeStamp secureConnectionStart;
+ readonly attribute DOMHighResTimeStamp requestStart;
+ readonly attribute DOMHighResTimeStamp responseStart;
+ readonly attribute DOMHighResTimeStamp responseEnd;
};
