Title: [211123] trunk/Tools
- Revision
- 211123
- Author
- [email protected]
- Date
- 2017-01-24 16:55:10 -0800 (Tue, 24 Jan 2017)
Log Message
WKR should not confuse Miguel Gomez with Andres Gomez
https://bugs.webkit.org/show_bug.cgi?id=167389
Reviewed by Lucas Forschler.
Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
"mAndres Gomez". Fix this.
* Scripts/webkitpy/tool/commands/newcommitbot.py:
(NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
space on each side of the email address, so expect both spaces to be there before
considering the email for replacement.
* Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (211122 => 211123)
--- trunk/Tools/ChangeLog 2017-01-25 00:53:48 UTC (rev 211122)
+++ trunk/Tools/ChangeLog 2017-01-25 00:55:10 UTC (rev 211123)
@@ -1,3 +1,19 @@
+2017-01-24 Michael Catanzaro <[email protected]>
+
+ WKR should not confuse Miguel Gomez with Andres Gomez
+ https://bugs.webkit.org/show_bug.cgi?id=167389
+
+ Reviewed by Lucas Forschler.
+
+ Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
+ "mAndres Gomez". Fix this.
+
+ * Scripts/webkitpy/tool/commands/newcommitbot.py:
+ (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
+ space on each side of the email address, so expect both spaces to be there before
+ considering the email for replacement.
+ * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
+
2017-01-24 Matt Rajca <[email protected]>
Pass down website autoplay policies to media elements
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py (211122 => 211123)
--- trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py 2017-01-25 00:53:48 UTC (rev 211122)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py 2017-01-25 00:55:10 UTC (rev 211123)
@@ -134,7 +134,7 @@
commit_log = commit_log.replace(' <' + email + '>', '')
else:
for email in contributor.emails:
- commit_log = commit_log.replace(email, name_with_nick)
+ commit_log = commit_log.replace(' %s ' % email, ' %s ' % name_with_nick)
lines = commit_log.split('\n')[1:-2] # Ignore lines with ----------.
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot_unittest.py (211122 => 211123)
--- trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot_unittest.py 2017-01-25 00:53:48 UTC (rev 211122)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot_unittest.py 2017-01-25 00:55:10 UTC (rev 211123)
@@ -127,3 +127,25 @@
------------------------------------------------------------------------"""),
"Vsevolod Vlasov (vsevik) rolled out r134927 and r134944 in https://trac.webkit.org/r135487 :"
" Reverting the reverts after merging.")
+
+ # Miguel <[email protected]> is not to be confused with Andres <[email protected]>.
+ def test_email_substring_problem(self):
+ self.assertEqual(NewCommitBot._summarize_commit_log("""------------------------------------------------------------------------
+r211084 | [email protected] | 2017-01-24 10:25:31 -0600 (Tue, 24 Jan 2017) | 13 lines
+
+[GTK] Do not paint non composited content into the window when using the threaded compositor
+https://bugs.webkit.org/show_bug.cgi?id=167367
+
+Reviewed by Carlos Garcia Campos.
+
+When using the threaded compositor we need to send the non composited content for compositing as well,
+not painting it directly into the window.
+
+No new tests.
+
+* rendering/RenderLayerBacking.cpp:
+(WebCore::RenderLayerBacking::paintsIntoWindow):
+
+------------------------------------------------------------------------"""),
+ "https://trac.webkit.org/r211084 by Miguel Gomez (magomez) [GTK] Do not paint non composited content into the window when using the threaded compositor"
+ " https://webkit.org/b/167367 Reviewed by Carlos Garcia Campos (KaL).")
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
