Title: [211127] trunk
- Revision
- 211127
- Author
- [email protected]
- Date
- 2017-01-24 18:18:01 -0800 (Tue, 24 Jan 2017)
Log Message
[WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
https://bugs.webkit.org/show_bug.cgi?id=167353
Patch by Youenn Fablet <[email protected]> on 2017-01-24
Reviewed by Alex Christensen.
Source/ThirdParty/libwebrtc:
* CMakeLists.txt:
Tools:
* Scripts/webkitpy/libwebrtc/generate_cmake.py:
(CMakeGenerator.initialize_targets):
Modified Paths
Diff
Modified: trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt (211126 => 211127)
--- trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt 2017-01-25 01:44:09 UTC (rev 211126)
+++ trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt 2017-01-25 02:18:01 UTC (rev 211127)
@@ -2747,7 +2747,7 @@
${LIBWEBRTC_INPUT_DIR}/webrtc/base/logging_mac.mm)
add_library(WebrtcBaseRtc_Base_Approved STATIC ${WebrtcBaseRtc_Base_Approved_SOURCES})
target_compile_options(WebrtcBaseRtc_Base_Approved PRIVATE "-fno-strict-aliasing" "-fstack-protector-strong" "-fcolor-diagnostics" "-arch" "x86_64" "-gdwarf-2" "-mmacosx-version-min=10.9" "-Wall" "-Werror" "-Wextra" "-Wpartial-availability" "-Wno-missing-field-initializers" "-Wno-unused-parameter" "-Wno-c++11-narrowing" "-Wno-covered-switch-default" "-Wno-deprecated-register" "-Wno-unneeded-internal-declaration" "-Wno-inconsistent-missing-override" "-Wno-shift-negative-value" "-O0" "-fvisibility=hidden" "-Wheader-hygiene" "-Wstring-conversion" "-Wno-strict-overflow" "-Wimplicit-fallthrough" "-Wthread-safety" "-Winconsistent-missing-override" "-Wundef" "-std=c99" &quo
t;-fno-threadsafe-statics" "-fvisibility-inlines-hidden" "-Wno-undefined-bool-conversion" "-Wno-tautological-undefined-compare" "-stdlib=libc++" "-fno-rtti" "-fno-exceptions" "-Wnon-virtual-dtor" "-Woverloaded-virtual" "-Wobjc-missing-property-synthesis" "-fobjc-call-cxx-cdtors")
-target_compile_definitions(WebrtcBaseRtc_Base_Approved PRIVATE V8_DEPRECATION_WARNINGS ENABLE_NOTIFICATIONS ENABLE_PLUGINS=1 ENABLE_PDF=1 ENABLE_PRINTING=1 ENABLE_BASIC_PRINTING=1 ENABLE_PRINT_PREVIEW=1 ENABLE_SPELLCHECK=1 USE_BROWSER_SPELLCHECKER=1 NO_TCMALLOC USE_EXTERNAL_POPUP_MENU=1 ENABLE_WEBRTC=1 ENABLE_EXTENSIONS=1 ENABLE_TASK_MANAGER=1 ENABLE_THEMES=1 ENABLE_SESSION_SERVICE=1 ENABLE_SUPERVISED_USERS=1 FULL_SAFE_BROWSING SAFE_BROWSING_CSD SAFE_BROWSING_DB_LOCAL CHROMIUM_BUILD ENABLE_MEDIA_ROUTER=1 FIELDTRIAL_TESTING_ENABLED CR_CLANG_REVISION=284979-1 CR_XCODE_VERSION=0820 __STDC_CONSTANT_MACROS __STDC_FORMAT_MACROS __ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 _DEBUG DYNAMIC_ANNOTATIONS_ENABLED=1 WTF_USE_DYNAMIC_ANNOTATIONS=1 WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE EXPAT_RELATIVE_PATH RTC_DISABLE_VP9 WEBRTC_POSIX WEBRTC_MAC)
+target_compile_definitions(WebrtcBaseRtc_Base_Approved PRIVATE V8_DEPRECATION_WARNINGS ENABLE_NOTIFICATIONS ENABLE_PLUGINS=1 ENABLE_PDF=1 ENABLE_PRINTING=1 ENABLE_BASIC_PRINTING=1 ENABLE_PRINT_PREVIEW=1 ENABLE_SPELLCHECK=1 USE_BROWSER_SPELLCHECKER=1 NO_TCMALLOC USE_EXTERNAL_POPUP_MENU=1 ENABLE_WEBRTC=1 ENABLE_EXTENSIONS=1 ENABLE_TASK_MANAGER=1 ENABLE_THEMES=1 ENABLE_SESSION_SERVICE=1 ENABLE_SUPERVISED_USERS=1 FULL_SAFE_BROWSING SAFE_BROWSING_CSD SAFE_BROWSING_DB_LOCAL CHROMIUM_BUILD ENABLE_MEDIA_ROUTER=1 FIELDTRIAL_TESTING_ENABLED CR_CLANG_REVISION=284979-1 CR_XCODE_VERSION=0820 __STDC_CONSTANT_MACROS __STDC_FORMAT_MACROS __ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 _DEBUG DYNAMIC_ANNOTATIONS_ENABLED=1 WTF_USE_DYNAMIC_ANNOTATIONS=1 WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE EXPAT_RELATIVE_PATH RTC_DISABLE_VP9 WEBRTC_POSIX WEBRTC_MAC HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE)
target_include_directories(WebrtcBaseRtc_Base_Approved PRIVATE ${LIBWEBRTC_INPUT_DIR}/ ${LIBWEBRTC_OUTPUT_DIR}/gen/)
set_target_properties(WebrtcBaseRtc_Base_Approved PROPERTIES LINK_FLAGS "-stdlib=libc++ -arch x86_64 -mmacosx-version-min=10.9")
set_target_properties(WebrtcBaseRtc_Base_Approved PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${LIBWEBRTC_OUTPUT_DIR}/obj/webrtc/base)
Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (211126 => 211127)
--- trunk/Source/ThirdParty/libwebrtc/ChangeLog 2017-01-25 01:44:09 UTC (rev 211126)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog 2017-01-25 02:18:01 UTC (rev 211127)
@@ -1,3 +1,12 @@
+2017-01-24 Youenn Fablet <[email protected]>
+
+ [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
+ https://bugs.webkit.org/show_bug.cgi?id=167353
+
+ Reviewed by Alex Christensen.
+
+ * CMakeLists.txt:
+
2017-01-23 Youenn Fablet <[email protected]>
[WebRTC] Filter libwebrtc link flags
Modified: trunk/Tools/ChangeLog (211126 => 211127)
--- trunk/Tools/ChangeLog 2017-01-25 01:44:09 UTC (rev 211126)
+++ trunk/Tools/ChangeLog 2017-01-25 02:18:01 UTC (rev 211127)
@@ -1,3 +1,13 @@
+2017-01-24 Youenn Fablet <[email protected]>
+
+ [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
+ https://bugs.webkit.org/show_bug.cgi?id=167353
+
+ Reviewed by Alex Christensen.
+
+ * Scripts/webkitpy/libwebrtc/generate_cmake.py:
+ (CMakeGenerator.initialize_targets):
+
2017-01-24 Michael Catanzaro <[email protected]>
WKR should not confuse Miguel Gomez with Andres Gomez
Modified: trunk/Tools/Scripts/webkitpy/libwebrtc/generate_cmake.py (211126 => 211127)
--- trunk/Tools/Scripts/webkitpy/libwebrtc/generate_cmake.py 2017-01-25 01:44:09 UTC (rev 211126)
+++ trunk/Tools/Scripts/webkitpy/libwebrtc/generate_cmake.py 2017-01-25 02:18:01 UTC (rev 211127)
@@ -160,6 +160,8 @@
self.remove_webrtc_base_sha1()
self.targets.pop("//build/config/sanitizers:options_sources")
+ self.targets["//webrtc/base:rtc_base_approved"]["defines"].append("HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE")
+
def _remove_target(self, targetName):
self.targets.pop(targetName)
for name, target in self.targets.iteritems():
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
