Title: [211131] trunk
- Revision
- 211131
- Author
- [email protected]
- Date
- 2017-01-24 18:59:11 -0800 (Tue, 24 Jan 2017)
Log Message
LayoutTest media/modern-media-controls/tracks-panel/tracks-panel-hide.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=167311
Patch by Antoine Quint <[email protected]> on 2017-01-24
Reviewed by Dean Jackson.
Source/WebCore:
Ensure we have a chance to start the transition (on the next frame) before registering for an event
tracking its completion.
* Modules/modern-media-controls/controls/tracks-panel.js:
(TracksPanel.prototype.hide):
LayoutTests:
This test should no longer be flaky, so let's no mark it as such anymore.
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (211130 => 211131)
--- trunk/LayoutTests/ChangeLog 2017-01-25 02:56:40 UTC (rev 211130)
+++ trunk/LayoutTests/ChangeLog 2017-01-25 02:59:11 UTC (rev 211131)
@@ -1,5 +1,16 @@
2017-01-24 Antoine Quint <[email protected]>
+ LayoutTest media/modern-media-controls/tracks-panel/tracks-panel-hide.html is a flaky timeout
+ https://bugs.webkit.org/show_bug.cgi?id=167311
+
+ Reviewed by Dean Jackson.
+
+ This test should no longer be flaky, so let's no mark it as such anymore.
+
+ * platform/mac/TestExpectations:
+
+2017-01-24 Antoine Quint <[email protected]>
+
Work around a crash when running media/modern-media-controls/pip-support/pip-support-enabled.html
https://bugs.webkit.org/show_bug.cgi?id=167381
Modified: trunk/LayoutTests/platform/mac/TestExpectations (211130 => 211131)
--- trunk/LayoutTests/platform/mac/TestExpectations 2017-01-25 02:56:40 UTC (rev 211130)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2017-01-25 02:59:11 UTC (rev 211131)
@@ -1493,8 +1493,6 @@
webkit.org/b/167275 media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html [ Pass Failure ]
-webkit.org/b/167311 [ Debug ] media/modern-media-controls/tracks-panel/tracks-panel-hide.html [ Pass Timeout ]
-
webkit.org/b/167347 media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html [ Pass Failure ]
webkit.org/b/167266 media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar.html [ Pass Failure ]
Modified: trunk/Source/WebCore/ChangeLog (211130 => 211131)
--- trunk/Source/WebCore/ChangeLog 2017-01-25 02:56:40 UTC (rev 211130)
+++ trunk/Source/WebCore/ChangeLog 2017-01-25 02:59:11 UTC (rev 211131)
@@ -1,3 +1,16 @@
+2017-01-24 Antoine Quint <[email protected]>
+
+ LayoutTest media/modern-media-controls/tracks-panel/tracks-panel-hide.html is a flaky timeout
+ https://bugs.webkit.org/show_bug.cgi?id=167311
+
+ Reviewed by Dean Jackson.
+
+ Ensure we have a chance to start the transition (on the next frame) before registering for an event
+ tracking its completion.
+
+ * Modules/modern-media-controls/controls/tracks-panel.js:
+ (TracksPanel.prototype.hide):
+
2017-01-24 Simon Fraser <[email protected]>
[iOS WK2] Avoid IOSurface readback for snapshot creation
Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/tracks-panel.js (211130 => 211131)
--- trunk/Source/WebCore/Modules/modern-media-controls/controls/tracks-panel.js 2017-01-25 02:56:40 UTC (rev 211130)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/tracks-panel.js 2017-01-25 02:59:11 UTC (rev 211131)
@@ -43,7 +43,9 @@
window.removeEventListener("keydown", this, true);
this.element.addEventListener("transitionend", this);
- this.element.classList.add("fade-out");
+
+ // Ensure a transition will indeed happen by starting it only on the next frame.
+ window.requestAnimationFrame(() => { this.element.classList.add("fade-out") });
}
get bottomY()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
