Title: [211149] trunk
- Revision
- 211149
- Author
- [email protected]
- Date
- 2017-01-25 09:42:44 -0800 (Wed, 25 Jan 2017)
Log Message
Revert r210882, removing support for background-repeat-x/y
https://bugs.webkit.org/show_bug.cgi?id=167223
Reviewed by Myles Maxfield.
Source/WebCore:
CSSPropertyBackgroundRepeatX and CSSPropertyBackgroundRepeatY only exist to make it easier
to parse CSSPropertyBackgroundRepeat as if it were a shorthand; they were never intended to
be web-exposed. r210882 mistakenly expose them to the web, so undo that patch, and annotate
the properties in CSSProperties.json with a flag which indicates their special status.
In addition, remove background-repeat-x/y from the list of properties allowed in video cues,
since these are not valid properties.
* css/CSSProperties.json:
* css/StyleResolver.cpp:
(WebCore::StyleResolver::isValidCueStyleProperty):
* css/makeprop.pl:
(addProperty):
* css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isKeywordPropertyID):
LayoutTests:
Modify the test to check that background-repeat-x and background-repeat-y are not parsed.
* fast/backgrounds/background-repeat-x-y-parse-expected.txt:
* fast/backgrounds/background-repeat-x-y-parse.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (211148 => 211149)
--- trunk/LayoutTests/ChangeLog 2017-01-25 17:38:24 UTC (rev 211148)
+++ trunk/LayoutTests/ChangeLog 2017-01-25 17:42:44 UTC (rev 211149)
@@ -1,3 +1,15 @@
+2017-01-25 Simon Fraser <[email protected]>
+
+ Revert r210882, removing support for background-repeat-x/y
+ https://bugs.webkit.org/show_bug.cgi?id=167223
+
+ Reviewed by Myles Maxfield.
+
+ Modify the test to check that background-repeat-x and background-repeat-y are not parsed.
+
+ * fast/backgrounds/background-repeat-x-y-parse-expected.txt:
+ * fast/backgrounds/background-repeat-x-y-parse.html:
+
2017-01-25 Youenn Fablet <[email protected]>
Flaky Test: imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html
Modified: trunk/Source/WebCore/ChangeLog (211148 => 211149)
--- trunk/Source/WebCore/ChangeLog 2017-01-25 17:38:24 UTC (rev 211148)
+++ trunk/Source/WebCore/ChangeLog 2017-01-25 17:42:44 UTC (rev 211149)
@@ -1,3 +1,26 @@
+2017-01-25 Simon Fraser <[email protected]>
+
+ Revert r210882, removing support for background-repeat-x/y
+ https://bugs.webkit.org/show_bug.cgi?id=167223
+
+ Reviewed by Myles Maxfield.
+
+ CSSPropertyBackgroundRepeatX and CSSPropertyBackgroundRepeatY only exist to make it easier
+ to parse CSSPropertyBackgroundRepeat as if it were a shorthand; they were never intended to
+ be web-exposed. r210882 mistakenly expose them to the web, so undo that patch, and annotate
+ the properties in CSSProperties.json with a flag which indicates their special status.
+
+ In addition, remove background-repeat-x/y from the list of properties allowed in video cues,
+ since these are not valid properties.
+
+ * css/CSSProperties.json:
+ * css/StyleResolver.cpp:
+ (WebCore::StyleResolver::isValidCueStyleProperty):
+ * css/makeprop.pl:
+ (addProperty):
+ * css/parser/CSSParserFastPaths.cpp:
+ (WebCore::CSSParserFastPaths::isKeywordPropertyID):
+
2017-01-25 Carlos Garcia Campos <[email protected]>
[GTK] UIProcess from WebKitGtk+ 2.15.x SIGSEGVs because of X Error BadDamage in WebKit::AcceleratedBackingStoreX11::update(WebKit::LayerTreeContext const&) () at Source/WebKit2/UIProcess/gtk/AcceleratedBackingStoreX11.cpp:145
Modified: trunk/Source/WebCore/css/CSSProperties.json (211148 => 211149)
--- trunk/Source/WebCore/css/CSSProperties.json 2017-01-25 17:38:24 UTC (rev 211148)
+++ trunk/Source/WebCore/css/CSSProperties.json 2017-01-25 17:42:44 UTC (rev 211149)
@@ -682,13 +682,15 @@
"background-repeat-x": {
"codegen-properties": {
"name-for-methods": "RepeatX",
- "fill-layer-property": true
+ "fill-layer-property": true,
+ "internal-only": true
}
},
"background-repeat-y": {
"codegen-properties": {
"name-for-methods": "RepeatY",
- "fill-layer-property": true
+ "fill-layer-property": true,
+ "internal-only": true
}
},
"background-size": {
@@ -3542,13 +3544,15 @@
"-webkit-mask-repeat-x": {
"codegen-properties": {
"name-for-methods": "RepeatX",
- "fill-layer-property": true
+ "fill-layer-property": true,
+ "internal-only": true
}
},
"-webkit-mask-repeat-y": {
"codegen-properties": {
"name-for-methods": "RepeatY",
- "fill-layer-property": true
+ "fill-layer-property": true,
+ "internal-only": true
}
},
"-webkit-mask-size": {
Modified: trunk/Source/WebCore/css/StyleResolver.cpp (211148 => 211149)
--- trunk/Source/WebCore/css/StyleResolver.cpp 2017-01-25 17:38:24 UTC (rev 211148)
+++ trunk/Source/WebCore/css/StyleResolver.cpp 2017-01-25 17:42:44 UTC (rev 211149)
@@ -1483,8 +1483,6 @@
case CSSPropertyBackgroundPositionX:
case CSSPropertyBackgroundPositionY:
case CSSPropertyBackgroundRepeat:
- case CSSPropertyBackgroundRepeatX:
- case CSSPropertyBackgroundRepeatY:
case CSSPropertyBackgroundSize:
case CSSPropertyColor:
case CSSPropertyFont:
Modified: trunk/Source/WebCore/css/makeprop.pl (211148 => 211149)
--- trunk/Source/WebCore/css/makeprop.pl 2017-01-25 17:38:24 UTC (rev 211148)
+++ trunk/Source/WebCore/css/makeprop.pl 2017-01-25 17:42:44 UTC (rev 211149)
@@ -139,6 +139,8 @@
$nameToAliases{$name} = $codegenProperties->{"aliases"};
} elsif ($styleBuilderOptions{$codegenOptionName}) {
$propertiesWithStyleBuilderOptions{$name}{$codegenOptionName} = $codegenProperties->{$codegenOptionName};
+ } elsif ($codegenOptionName eq "internal-only") {
+ # internal-only properties exist to make it easier to parse compound properties (e.g. background-repeat) as if they were shorthands. This doesn't currently affect codegen.
} else {
die "Unrecognized codegen property \"$optionName\" for $name property.";
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
