Diff
Modified: trunk/Source/WebCore/ChangeLog (211255 => 211256)
--- trunk/Source/WebCore/ChangeLog 2017-01-27 06:09:41 UTC (rev 211255)
+++ trunk/Source/WebCore/ChangeLog 2017-01-27 07:14:47 UTC (rev 211256)
@@ -1,3 +1,27 @@
+2017-01-26 Chris Dumez <[email protected]>
+
+ Revert r210474 it is no longer needed
+ https://bugs.webkit.org/show_bug.cgi?id=167487
+
+ Reviewed by Daniel Bates.
+
+ Revert r210474 it is no longer needed after r211254.
+
+ * dom/Document.cpp:
+ (WebCore::Document::canNavigate):
+ * html/HTMLAnchorElement.cpp:
+ (WebCore::HTMLAnchorElement::handleClick):
+ * html/HTMLLinkElement.cpp:
+ (WebCore::HTMLLinkElement::handleClick):
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::urlSelected):
+ (WebCore::FrameLoader::submitForm):
+ (WebCore::FrameLoader::loadFrameRequest):
+ * mathml/MathMLElement.cpp:
+ (WebCore::MathMLElement::defaultEventHandler):
+ * svg/SVGAElement.cpp:
+ (WebCore::SVGAElement::defaultEventHandler):
+
2017-01-26 Youenn Fablet <[email protected]>
[WebRTC] Implement WebRTC PeerConnection backend based on libwebrtc
Modified: trunk/Source/WebCore/dom/Document.cpp (211255 => 211256)
--- trunk/Source/WebCore/dom/Document.cpp 2017-01-27 06:09:41 UTC (rev 211255)
+++ trunk/Source/WebCore/dom/Document.cpp 2017-01-27 07:14:47 UTC (rev 211256)
@@ -2996,9 +2996,6 @@
if (!m_frame)
return false;
- if (pageCacheState() != Document::NotInPageCache)
- return false;
-
// FIXME: We shouldn't call this function without a target frame, but
// fast/forms/submit-to-blank-multiple-times.html depends on this function
// returning true when supplied with a 0 targetFrame.
Modified: trunk/Source/WebCore/html/HTMLAnchorElement.cpp (211255 => 211256)
--- trunk/Source/WebCore/html/HTMLAnchorElement.cpp 2017-01-27 06:09:41 UTC (rev 211255)
+++ trunk/Source/WebCore/html/HTMLAnchorElement.cpp 2017-01-27 07:14:47 UTC (rev 211256)
@@ -369,9 +369,6 @@
if (!frame)
return;
- if (document().pageCacheState() != Document::NotInPageCache)
- return;
-
StringBuilder url;
url.append(stripLeadingAndTrailingHTMLSpaces(attributeWithoutSynchronization(hrefAttr)));
appendServerMapMousePosition(url, event);
Modified: trunk/Source/WebCore/html/HTMLLinkElement.cpp (211255 => 211256)
--- trunk/Source/WebCore/html/HTMLLinkElement.cpp 2017-01-27 06:09:41 UTC (rev 211255)
+++ trunk/Source/WebCore/html/HTMLLinkElement.cpp 2017-01-27 07:14:47 UTC (rev 211256)
@@ -489,8 +489,6 @@
Frame* frame = document().frame();
if (!frame)
return;
- if (document().pageCacheState() != Document::NotInPageCache)
- return;
frame->loader().urlSelected(url, target(), &event, LockHistory::No, LockBackForwardList::No, MaybeSendReferrer, document().shouldOpenExternalURLsPolicyToPropagate());
}
Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (211255 => 211256)
--- trunk/Source/WebCore/loader/FrameLoader.cpp 2017-01-27 06:09:41 UTC (rev 211255)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp 2017-01-27 07:14:47 UTC (rev 211256)
@@ -345,9 +345,6 @@
void FrameLoader::urlSelected(const FrameLoadRequest& passedRequest, Event* triggeringEvent)
{
- ASSERT_WITH_SECURITY_IMPLICATION(!triggeringEvent || !triggeringEvent->target() || !triggeringEvent->target()->toNode()
- || triggeringEvent->target()->toNode()->document().pageCacheState() == Document::NotInPageCache);
-
Ref<Frame> protect(m_frame);
FrameLoadRequest frameRequest(passedRequest);
@@ -373,9 +370,6 @@
if (!m_frame.page())
return;
- if (submission->state().sourceDocument().pageCacheState() != Document::NotInPageCache)
- return;
-
if (submission->action().isEmpty())
return;
@@ -1133,9 +1127,6 @@
void FrameLoader::loadFrameRequest(const FrameLoadRequest& request, Event* event, FormState* formState)
{
- ASSERT_WITH_SECURITY_IMPLICATION(!event || !event->target() || !event->target()->toNode()
- || event->target()->toNode()->document().pageCacheState() == Document::NotInPageCache);
-
// Protect frame from getting blown away inside dispatchBeforeLoadEvent in loadWithDocumentLoader.
auto protectFrame = makeRef(m_frame);
Modified: trunk/Source/WebCore/mathml/MathMLElement.cpp (211255 => 211256)
--- trunk/Source/WebCore/mathml/MathMLElement.cpp 2017-01-27 06:09:41 UTC (rev 211255)
+++ trunk/Source/WebCore/mathml/MathMLElement.cpp 2017-01-27 07:14:47 UTC (rev 211256)
@@ -149,8 +149,6 @@
auto& href = ""
const auto& url = ""
event.setDefaultHandled();
- if (document().pageCacheState() != Document::NotInPageCache)
- return;
if (auto* frame = document().frame())
frame->loader().urlSelected(document().completeURL(url), "_self", &event, LockHistory::No, LockBackForwardList::No, MaybeSendReferrer, document().shouldOpenExternalURLsPolicyToPropagate());
return;
Modified: trunk/Source/WebCore/svg/SVGAElement.cpp (211255 => 211256)
--- trunk/Source/WebCore/svg/SVGAElement.cpp 2017-01-27 06:09:41 UTC (rev 211255)
+++ trunk/Source/WebCore/svg/SVGAElement.cpp 2017-01-27 07:14:47 UTC (rev 211256)
@@ -144,8 +144,6 @@
Frame* frame = document().frame();
if (!frame)
return;
- if (document().pageCacheState() != Document::NotInPageCache)
- return;
frame->loader().urlSelected(document().completeURL(url), target, &event, LockHistory::No, LockBackForwardList::No, MaybeSendReferrer, document().shouldOpenExternalURLsPolicyToPropagate());
return;
}
