Title: [211343] trunk/Source
- Revision
- 211343
- Author
- [email protected]
- Date
- 2017-01-28 16:16:51 -0800 (Sat, 28 Jan 2017)
Log Message
Don't flash a tap highlight for the entirety of an editable WKWebView
https://bugs.webkit.org/show_bug.cgi?id=167486
<rdar://problem/30193996>
Reviewed by Dan Bernstein.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::sendTapHighlightForNodeIfNecessary):
Bail from providing a tap highlight if we are about to highlight
the entire body of an editable web view.
* dom/Document.h:
Export.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (211342 => 211343)
--- trunk/Source/WebCore/ChangeLog 2017-01-28 23:13:17 UTC (rev 211342)
+++ trunk/Source/WebCore/ChangeLog 2017-01-29 00:16:51 UTC (rev 211343)
@@ -1,3 +1,14 @@
+2017-01-28 Tim Horton <[email protected]>
+
+ Don't flash a tap highlight for the entirety of an editable WKWebView
+ https://bugs.webkit.org/show_bug.cgi?id=167486
+ <rdar://problem/30193996>
+
+ Reviewed by Dan Bernstein.
+
+ * dom/Document.h:
+ Export.
+
2017-01-28 Wenson Hsieh <[email protected]>
Check USE(APPLE_INTERNAL_SDK) instead of specific headers when importing from WebKitAdditions
Modified: trunk/Source/WebCore/dom/Document.h (211342 => 211343)
--- trunk/Source/WebCore/dom/Document.h 2017-01-28 23:13:17 UTC (rev 211342)
+++ trunk/Source/WebCore/dom/Document.h 2017-01-29 00:16:51 UTC (rev 211343)
@@ -889,7 +889,7 @@
static bool hasValidNamespaceForElements(const QualifiedName&);
static bool hasValidNamespaceForAttributes(const QualifiedName&);
- HTMLBodyElement* body() const;
+ WEBCORE_EXPORT HTMLBodyElement* body() const;
WEBCORE_EXPORT HTMLElement* bodyOrFrameset() const;
WEBCORE_EXPORT ExceptionOr<void> setBodyOrFrameset(RefPtr<HTMLElement>&&);
Modified: trunk/Source/WebKit2/ChangeLog (211342 => 211343)
--- trunk/Source/WebKit2/ChangeLog 2017-01-28 23:13:17 UTC (rev 211342)
+++ trunk/Source/WebKit2/ChangeLog 2017-01-29 00:16:51 UTC (rev 211343)
@@ -1,3 +1,16 @@
+2017-01-28 Tim Horton <[email protected]>
+
+ Don't flash a tap highlight for the entirety of an editable WKWebView
+ https://bugs.webkit.org/show_bug.cgi?id=167486
+ <rdar://problem/30193996>
+
+ Reviewed by Dan Bernstein.
+
+ * WebProcess/WebPage/ios/WebPageIOS.mm:
+ (WebKit::WebPage::sendTapHighlightForNodeIfNecessary):
+ Bail from providing a tap highlight if we are about to highlight
+ the entire body of an editable web view.
+
2017-01-28 Wenson Hsieh <[email protected]>
Check USE(APPLE_INTERNAL_SDK) instead of specific headers when importing from WebKitAdditions
Modified: trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm (211342 => 211343)
--- trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm 2017-01-28 23:13:17 UTC (rev 211342)
+++ trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm 2017-01-29 00:16:51 UTC (rev 211343)
@@ -68,6 +68,7 @@
#import <WebCore/GeometryUtilities.h>
#import <WebCore/HTMLAreaElement.h>
#import <WebCore/HTMLAttachmentElement.h>
+#import <WebCore/HTMLBodyElement.h>
#import <WebCore/HTMLElement.h>
#import <WebCore/HTMLElementTypeHelpers.h>
#import <WebCore/HTMLFormElement.h>
@@ -633,6 +634,9 @@
if (!node)
return;
+ if (m_page->isEditable() && node == m_page->mainFrame().document()->body())
+ return;
+
if (is<Element>(*node)) {
ASSERT(m_page);
m_page->mainFrame().loader().client().prefetchDNS(downcast<Element>(*node).absoluteLinkURL().host());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
