Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (211431 => 211432)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-01-31 15:49:54 UTC (rev 211431)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-01-31 15:59:52 UTC (rev 211432)
@@ -1,3 +1,49 @@
+2017-01-31 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Address some ESLint warnings
+ https://bugs.webkit.org/show_bug.cgi?id=167634
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Base/DOMUtilities.js:
+ (WebInspector.linkifyNodeReference):
+ (isSimiliarNode):
+ (WebInspector.xpathIndex):
+ These empty statements were supposed to be returns!
+
+ * UserInterface/Base/Main.js:
+ * UserInterface/Models/CSSProperty.js:
+ (WebInspector.CSSProperty.prototype.get relatedLonghandProperties):
+ * UserInterface/Models/DOMNode.js:
+ * UserInterface/Protocol/Connection.js:
+ (InspectorBackend.Connection):
+ (InspectorBackend.MainConnection):
+ (InspectorBackend.WorkerConnection):
+ * UserInterface/Protocol/MainTarget.js:
+ (WebInspector.MainTarget):
+ * UserInterface/Protocol/WorkerTarget.js:
+ (WebInspector.WorkerTarget):
+ * UserInterface/Test/Test.js:
+ * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
+ * UserInterface/Views/ConsoleSession.js:
+ (WebInspector.ConsoleSession):
+ * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
+ (WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshAccessibility.accessibilityPropertiesCallback):
+ (WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshAccessibility):
+ * UserInterface/Views/ResourceSidebarPanel.js:
+ (WebInspector.ResourceSidebarPanel.prototype._scriptWasAdded):
+ * UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
+ (WebInspector.ScopeChainDetailsSidebarPanel):
+ * UserInterface/Views/ScriptContentView.js:
+ (WebInspector.ScriptContentView.prototype._toggleTypeAnnotations):
+ * UserInterface/Views/SourceCodeTextEditor.js:
+ (WebInspector.SourceCodeTextEditor.prototype._createControlFlowScrollEventHandler):
+ * UserInterface/Views/TextResourceContentView.js:
+ (WebInspector.TextResourceContentView.prototype._toggleTypeAnnotations):
+ * UserInterface/Workers/Formatter/EsprimaFormatter.js:
+ (EsprimaFormatter.prototype._handleTokenAtNode):
+ Address pedantic warnings for consistent style.
+
2017-01-30 Devin Rousso <[email protected]>
Web Inspector: "bouncy highlight" element in TextEditor/DOMTreeOutline should update or dismiss when user scrolls
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/DOMUtilities.js (211431 => 211432)
--- trunk/Source/WebInspectorUI/UserInterface/Base/DOMUtilities.js 2017-01-31 15:49:54 UTC (rev 211431)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/DOMUtilities.js 2017-01-31 15:59:52 UTC (rev 211432)
@@ -66,9 +66,9 @@
let link = document.createElement("span");
link.append(displayName);
link.setAttribute("role", "link");
-
+
link.title = displayName;
-
+
let nodeType = node.nodeType();
if ((nodeType !== Node.DOCUMENT_NODE || node.parentNode) && nodeType !== Node.TEXT_NODE)
link.className = "node-link";
@@ -239,7 +239,7 @@
break;
case Node.PROCESSING_INSTRUCTION_NODE:
value = "processing-instruction()";
- break
+ break;
default:
value = "";
break;
@@ -278,9 +278,9 @@
// XPath CDATA and text() are the same.
if (aType === Node.CDATA_SECTION_NODE)
- aType === Node.TEXT_NODE;
+ return aType === Node.TEXT_NODE;
if (bType === Node.CDATA_SECTION_NODE)
- bType === Node.TEXT_NODE;
+ return bType === Node.TEXT_NODE;
return aType === bType;
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (211431 => 211432)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2017-01-31 15:49:54 UTC (rev 211431)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2017-01-31 15:59:52 UTC (rev 211432)
@@ -2588,7 +2588,7 @@
WebInspector.assumingMainTarget = function()
{
return WebInspector.mainTarget;
-}
+};
// OpenResourceDialog delegate
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/CSSProperty.js (211431 => 211432)
--- trunk/Source/WebInspectorUI/UserInterface/Models/CSSProperty.js 2017-01-31 15:49:54 UTC (rev 211431)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/CSSProperty.js 2017-01-31 15:59:52 UTC (rev 211432)
@@ -230,7 +230,7 @@
this._relatedShorthandProperty = property || null;
}
- get relatedLonghandProperties() { return this._relatedLonghandProperties;}
+ get relatedLonghandProperties() { return this._relatedLonghandProperties; }
addRelatedLonghandProperty(property)
{
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/DOMNode.js (211431 => 211432)
--- trunk/Source/WebInspectorUI/UserInterface/Models/DOMNode.js 2017-01-31 15:49:54 UTC (rev 211431)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/DOMNode.js 2017-01-31 15:59:52 UTC (rev 211432)
@@ -824,7 +824,7 @@
Closed: "closed",
Open: "open",
};
-
+
WebInspector.DOMNode.CustomElementState = {
Builtin: "builtin",
Custom: "custom",
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Connection.js (211431 => 211432)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Connection.js 2017-01-31 15:49:54 UTC (rev 211431)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Connection.js 2017-01-31 15:59:52 UTC (rev 211432)
@@ -270,7 +270,7 @@
for (let script of scriptsToRun)
script.call(this);
}
-}
+};
InspectorBackend.MainConnection = class InspectorBackendPageConnection extends InspectorBackend.Connection
{
@@ -285,7 +285,7 @@
{
InspectorFrontendHost.sendMessageToBackend(message);
}
-}
+};
InspectorBackend.WorkerConnection = class InspectorBackendWorkerConnection extends InspectorBackend.Connection
{
@@ -310,6 +310,6 @@
{
WorkerAgent.sendMessageToWorker(this._workerId, message);
}
-}
+};
InspectorBackend.mainConnection = new InspectorBackend.MainConnection;
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/MainTarget.js (211431 => 211432)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/MainTarget.js 2017-01-31 15:49:54 UTC (rev 211431)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/MainTarget.js 2017-01-31 15:59:52 UTC (rev 211432)
@@ -53,4 +53,4 @@
let mainFrame = WebInspector.frameResourceManager.mainFrame;
return mainFrame ? mainFrame.mainResource : null;
}
-}
+};
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/WorkerTarget.js (211431 => 211432)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/WorkerTarget.js 2017-01-31 15:49:54 UTC (rev 211431)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/WorkerTarget.js 2017-01-31 15:59:52 UTC (rev 211432)
@@ -56,4 +56,4 @@
{
return WebInspector.displayNameForURL(this._name);
}
-}
+};
Modified: trunk/Source/WebInspectorUI/UserInterface/Test/Test.js (211431 => 211432)
--- trunk/Source/WebInspectorUI/UserInterface/Test/Test.js 2017-01-31 15:49:54 UTC (rev 211431)
+++ trunk/Source/WebInspectorUI/UserInterface/Test/Test.js 2017-01-31 15:59:52 UTC (rev 211432)
@@ -114,7 +114,7 @@
InspectorTest.redirectConsoleToTestOutput();
-WebInspector.reportInternalError = (e) => { console.error(e); }
+WebInspector.reportInternalError = (e) => { console.error(e); };
window.reportUnhandledRejection = InspectorTest.reportUnhandledRejection.bind(InspectorTest);
window._onerror_ = InspectorTest.reportUncaughtExceptionFromEvent.bind(InspectorTest);
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js (211431 => 211432)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js 2017-01-31 15:49:54 UTC (rev 211431)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js 2017-01-31 15:59:52 UTC (rev 211432)
@@ -1377,7 +1377,7 @@
_inlineSwatchDeactivated()
{
this._hasActiveInlineSwatchEditor = false;
- }
+ }
_propertyOverriddenStatusChanged(event)
{
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleSession.js (211431 => 211432)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleSession.js 2017-01-31 15:49:54 UTC (rev 211431)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleSession.js 2017-01-31 15:59:52 UTC (rev 211432)
@@ -43,7 +43,7 @@
let headerText = "";
switch (data.newSessionReason) {
case WebInspector.ConsoleSession.NewSessionReason.PageReloaded:
- headerText = WebInspector.UIString("Page reloaded at %s");
+ headerText = WebInspector.UIString("Page reloaded at %s");
break;
case WebInspector.ConsoleSession.NewSessionReason.PageNavigated:
headerText = WebInspector.UIString("Page navigated at %s");
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js (211431 => 211432)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js 2017-01-31 15:49:54 UTC (rev 211431)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js 2017-01-31 15:59:52 UTC (rev 211432)
@@ -500,8 +500,8 @@
let roleType = null;
let buttonType = null;
let buttonTypePopupString = WebInspector.UIString("popup");
- let buttonTypeToggleString = WebInspector.UIString("toggle")
- let buttonTypePopupToggleString = WebInspector.UIString("popup, toggle")
+ let buttonTypeToggleString = WebInspector.UIString("toggle");
+ let buttonTypePopupToggleString = WebInspector.UIString("popup, toggle");
if (role === "" || role === "unknown")
role = WebInspector.UIString("No exact ARIA role match.");
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js (211431 => 211432)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js 2017-01-31 15:49:54 UTC (rev 211431)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js 2017-01-31 15:59:52 UTC (rev 211432)
@@ -289,7 +289,7 @@
// Worker script.
if (script.target !== WebInspector.mainTarget) {
if (script.isMainResource())
- this._addTargetWithMainResource(script.target)
+ this._addTargetWithMainResource(script.target);
return;
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ScopeChainDetailsSidebarPanel.js (211431 => 211432)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ScopeChainDetailsSidebarPanel.js 2017-01-31 15:49:54 UTC (rev 211431)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ScopeChainDetailsSidebarPanel.js 2017-01-31 15:59:52 UTC (rev 211432)
@@ -64,7 +64,7 @@
WebInspector.runtimeManager.addEventListener(WebInspector.RuntimeManager.Event.DidEvaluate, this._didEvaluateExpression, this);
// Update watch expressions when console execution context changes.
- WebInspector.runtimeManager.addEventListener(WebInspector.RuntimeManager.Event.ActiveExecutionContextChanged, this._activeExecutionContextChanged, this)
+ WebInspector.runtimeManager.addEventListener(WebInspector.RuntimeManager.Event.ActiveExecutionContextChanged, this._activeExecutionContextChanged, this);
// Update watch expressions on navigations.
WebInspector.Frame.addEventListener(WebInspector.Frame.Event.MainResourceDidChange, this._mainResourceDidChange, this);
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ScriptContentView.js (211431 => 211432)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ScriptContentView.js 2017-01-31 15:49:54 UTC (rev 211431)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ScriptContentView.js 2017-01-31 15:59:52 UTC (rev 211432)
@@ -234,7 +234,7 @@
this._showTypesButtonNavigationItem.enabled = false;
this._textEditor.toggleTypeAnnotations().then(() => {
this._showTypesButtonNavigationItem.enabled = true;
- })
+ });
}
_toggleUnexecutedCodeHighlights(event)
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js (211431 => 211432)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js 2017-01-31 15:49:54 UTC (rev 211431)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js 2017-01-31 15:59:52 UTC (rev 211432)
@@ -2213,7 +2213,7 @@
else if (this._basicBlockAnnotator)
this._basicBlockAnnotator.pause();
- timeoutIdentifier = setTimeout(() => {
+ timeoutIdentifier = setTimeout(() => {
timeoutIdentifier = null;
if (this._basicBlockAnnotator)
this._basicBlockAnnotator.resume();
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TextResourceContentView.js (211431 => 211432)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TextResourceContentView.js 2017-01-31 15:49:54 UTC (rev 211431)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TextResourceContentView.js 2017-01-31 15:59:52 UTC (rev 211432)
@@ -222,7 +222,7 @@
this._showTypesButtonNavigationItem.enabled = false;
this._textEditor.toggleTypeAnnotations().then(() => {
this._showTypesButtonNavigationItem.enabled = true;
- })
+ });
}
_toggleUnexecutedCodeHighlights(event)
Modified: trunk/Source/WebInspectorUI/UserInterface/Workers/Formatter/EsprimaFormatter.js (211431 => 211432)
--- trunk/Source/WebInspectorUI/UserInterface/Workers/Formatter/EsprimaFormatter.js 2017-01-31 15:49:54 UTC (rev 211431)
+++ trunk/Source/WebInspectorUI/UserInterface/Workers/Formatter/EsprimaFormatter.js 2017-01-31 15:59:52 UTC (rev 211432)
@@ -815,7 +815,7 @@
builder.appendSpace();
builder.appendToken(tokenValue, tokenOffset);
builder.appendSpace();
- return;
+ return;
}
if (nodeType === "ExportAllDeclaration" || nodeType === "ExportDefaultDeclaration" || nodeType === "ImportDefaultSpecifier" || nodeType === "ImportNamespaceSpecifier") {
