Title: [99055] trunk/Source/WebCore
Revision
99055
Author
[email protected]
Date
2011-11-02 07:00:51 -0700 (Wed, 02 Nov 2011)

Log Message

Web Inspector: [REGRESSION] Clicking in a CSS property/value being edited commits the editor
https://bugs.webkit.org/show_bug.cgi?id=71360

Reviewed by Pavel Feldman.

Selecting a selected TreeElement should be an idempotent operation.

* inspector/front-end/treeoutline.js:
(TreeElement.prototype.select):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (99054 => 99055)


--- trunk/Source/WebCore/ChangeLog	2011-11-02 12:56:00 UTC (rev 99054)
+++ trunk/Source/WebCore/ChangeLog	2011-11-02 14:00:51 UTC (rev 99055)
@@ -1,3 +1,15 @@
+2011-11-02  Alexander Pavlov  <[email protected]>
+
+        Web Inspector: [REGRESSION] Clicking in a CSS property/value being edited commits the editor
+        https://bugs.webkit.org/show_bug.cgi?id=71360
+
+        Reviewed by Pavel Feldman.
+
+        Selecting a selected TreeElement should be an idempotent operation.
+
+        * inspector/front-end/treeoutline.js:
+        (TreeElement.prototype.select):
+
 2011-11-02  Ben Wells  <[email protected]>
 
         Canvas filling paths or rects need to be invalidate larger rects for some compositing modes.

Modified: trunk/Source/WebCore/inspector/front-end/treeoutline.js (99054 => 99055)


--- trunk/Source/WebCore/inspector/front-end/treeoutline.js	2011-11-02 12:56:00 UTC (rev 99054)
+++ trunk/Source/WebCore/inspector/front-end/treeoutline.js	2011-11-02 14:00:51 UTC (rev 99055)
@@ -833,15 +833,9 @@
  */
 TreeElement.prototype.select = function(omitFocus, selectedByUser)
 {
-    if (!this.treeOutline || !this.selectable)
+    if (!this.treeOutline || !this.selectable || this.selected)
         return;
 
-    if (this.selected) {
-        if (!omitFocus)
-            this.treeOutline._childrenListNode.focus();
-        return;
-    }
-    
     if (this.treeOutline.selectedTreeElement)
         this.treeOutline.selectedTreeElement.deselect();
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to