Title: [211675] trunk/Source/_javascript_Core
- Revision
- 211675
- Author
- [email protected]
- Date
- 2017-02-04 17:26:25 -0800 (Sat, 04 Feb 2017)
Log Message
Static Analyzer: Value stored to 'prev' is never read
https://bugs.webkit.org/show_bug.cgi?id=167844
Patch by Joseph Pecoraro <[email protected]> on 2017-02-04
Reviewed by Saam Barati.
Source/_javascript_Core/runtime/JSMapIterator.h:60:13: warning: Value stored to 'prev' is never read
prev = bucket;
^ ~~~~~~
Source/_javascript_Core/runtime/JSSetIterator.h:60:13: warning: Value stored to 'prev' is never read
prev = bucket;
^ ~~~~~~
* runtime/JSMapIterator.h:
(JSC::JSMapIterator::advanceIter):
* runtime/JSSetIterator.h:
(JSC::JSSetIterator::advanceIter):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (211674 => 211675)
--- trunk/Source/_javascript_Core/ChangeLog 2017-02-04 21:46:21 UTC (rev 211674)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-02-05 01:26:25 UTC (rev 211675)
@@ -1,3 +1,22 @@
+2017-02-04 Joseph Pecoraro <[email protected]>
+
+ Static Analyzer: Value stored to 'prev' is never read
+ https://bugs.webkit.org/show_bug.cgi?id=167844
+
+ Reviewed by Saam Barati.
+
+ Source/_javascript_Core/runtime/JSMapIterator.h:60:13: warning: Value stored to 'prev' is never read
+ prev = bucket;
+ ^ ~~~~~~
+ Source/_javascript_Core/runtime/JSSetIterator.h:60:13: warning: Value stored to 'prev' is never read
+ prev = bucket;
+ ^ ~~~~~~
+
+ * runtime/JSMapIterator.h:
+ (JSC::JSMapIterator::advanceIter):
+ * runtime/JSSetIterator.h:
+ (JSC::JSSetIterator::advanceIter):
+
2017-02-04 Yusuke Suzuki <[email protected]>
[JSC] Add operationToInt32SensibleSlow to optimize kraken pbkdf2 and sha256
Modified: trunk/Source/_javascript_Core/runtime/JSMapIterator.h (211674 => 211675)
--- trunk/Source/_javascript_Core/runtime/JSMapIterator.h 2017-02-04 21:46:21 UTC (rev 211674)
+++ trunk/Source/_javascript_Core/runtime/JSMapIterator.h 2017-02-05 01:26:25 UTC (rev 211675)
@@ -56,10 +56,8 @@
if (!prev)
return nullptr;
HashMapBucketType* bucket = m_iter->next();
- while (bucket && bucket->deleted()) {
- prev = bucket;
+ while (bucket && bucket->deleted())
bucket = bucket->next();
- }
if (!bucket) {
setIterator(exec->vm(), nullptr);
return nullptr;
Modified: trunk/Source/_javascript_Core/runtime/JSSetIterator.h (211674 => 211675)
--- trunk/Source/_javascript_Core/runtime/JSSetIterator.h 2017-02-04 21:46:21 UTC (rev 211674)
+++ trunk/Source/_javascript_Core/runtime/JSSetIterator.h 2017-02-05 01:26:25 UTC (rev 211675)
@@ -56,10 +56,8 @@
if (!prev)
return nullptr;
HashMapBucketType* bucket = m_iter->next();
- while (bucket && bucket->deleted()) {
- prev = bucket;
+ while (bucket && bucket->deleted())
bucket = bucket->next();
- }
if (!bucket) {
setIterator(exec->vm(), nullptr);
return nullptr;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
