Title: [211835] trunk/Source
- Revision
- 211835
- Author
- achristen...@apple.com
- Date
- 2017-02-07 13:29:50 -0800 (Tue, 07 Feb 2017)
Log Message
Revert r166597
https://bugs.webkit.org/show_bug.cgi?id=167951
Reviewed by Andreas Kling.
Source/WebCore:
* platform/spi/cf/CFNetworkSPI.h:
Remove now-unused SPI declaration.
Source/WebKit2:
CFURLConnectionInvalidateConnectionCache is not commonly called and is likely causing
CFNetwork to be in a strange state when using NSURLSession and invalidating the connection
cache during authentication, especially server trust evaluation. Right now we only call
it when handling memory pressure, and it isn't worth getting into such a strange state
in a poorly tested situation. See rdar://problem/27439617
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::lowMemoryHandler):
(WebKit::NetworkProcess::initializeSandbox):
(WebKit::NetworkProcess::platformLowMemoryHandler): Deleted.
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformLowMemoryHandler): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (211834 => 211835)
--- trunk/Source/WebCore/ChangeLog 2017-02-07 21:22:20 UTC (rev 211834)
+++ trunk/Source/WebCore/ChangeLog 2017-02-07 21:29:50 UTC (rev 211835)
@@ -1,3 +1,13 @@
+2017-02-07 Alex Christensen <achristen...@webkit.org>
+
+ Revert r166597
+ https://bugs.webkit.org/show_bug.cgi?id=167951
+
+ Reviewed by Andreas Kling.
+
+ * platform/spi/cf/CFNetworkSPI.h:
+ Remove now-unused SPI declaration.
+
2017-02-07 Sam Weinig <s...@webkit.org>
Try to fix the windows build.
Modified: trunk/Source/WebCore/platform/spi/cf/CFNetworkSPI.h (211834 => 211835)
--- trunk/Source/WebCore/platform/spi/cf/CFNetworkSPI.h 2017-02-07 21:22:20 UTC (rev 211834)
+++ trunk/Source/WebCore/platform/spi/cf/CFNetworkSPI.h 2017-02-07 21:29:50 UTC (rev 211835)
@@ -155,8 +155,6 @@
#endif
#endif // PLATFORM(COCOA)
-void CFURLConnectionInvalidateConnectionCache();
-
extern CFStringRef const kCFHTTPCookieLocalFileDomain;
extern const CFStringRef kCFHTTPVersion1_1;
extern const CFStringRef kCFURLRequestAllowAllPOSTCaching;
Modified: trunk/Source/WebKit2/ChangeLog (211834 => 211835)
--- trunk/Source/WebKit2/ChangeLog 2017-02-07 21:22:20 UTC (rev 211834)
+++ trunk/Source/WebKit2/ChangeLog 2017-02-07 21:29:50 UTC (rev 211835)
@@ -1,3 +1,24 @@
+2017-02-07 Alex Christensen <achristen...@webkit.org>
+
+ Revert r166597
+ https://bugs.webkit.org/show_bug.cgi?id=167951
+
+ Reviewed by Andreas Kling.
+
+ CFURLConnectionInvalidateConnectionCache is not commonly called and is likely causing
+ CFNetwork to be in a strange state when using NSURLSession and invalidating the connection
+ cache during authentication, especially server trust evaluation. Right now we only call
+ it when handling memory pressure, and it isn't worth getting into such a strange state
+ in a poorly tested situation. See rdar://problem/27439617
+
+ * NetworkProcess/NetworkProcess.cpp:
+ (WebKit::NetworkProcess::lowMemoryHandler):
+ (WebKit::NetworkProcess::initializeSandbox):
+ (WebKit::NetworkProcess::platformLowMemoryHandler): Deleted.
+ * NetworkProcess/NetworkProcess.h:
+ * NetworkProcess/cocoa/NetworkProcessCocoa.mm:
+ (WebKit::NetworkProcess::platformLowMemoryHandler): Deleted.
+
2017-02-07 Brian Burg <bb...@apple.com>
[Mac] Web Automation: NSEventType not initialized in WebAutomationSession::platformSimulateMouseInteraction
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp (211834 => 211835)
--- trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp 2017-02-07 21:22:20 UTC (rev 211834)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp 2017-02-07 21:29:50 UTC (rev 211835)
@@ -195,7 +195,6 @@
if (m_suppressMemoryPressureHandler)
return;
- platformLowMemoryHandler(critical);
WTF::releaseFastMallocFreeMemory();
}
@@ -655,10 +654,6 @@
void NetworkProcess::initializeSandbox(const ChildProcessInitializationParameters&, SandboxInitializationParameters&)
{
}
-
-void NetworkProcess::platformLowMemoryHandler(Critical)
-{
-}
#endif
} // namespace WebKit
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h (211834 => 211835)
--- trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h 2017-02-07 21:22:20 UTC (rev 211834)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h 2017-02-07 21:29:50 UTC (rev 211835)
@@ -128,7 +128,6 @@
void platformTerminate();
void lowMemoryHandler(WebCore::Critical);
- void platformLowMemoryHandler(WebCore::Critical);
// ChildProcess
void initializeProcess(const ChildProcessInitializationParameters&) override;
Modified: trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm (211834 => 211835)
--- trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm 2017-02-07 21:22:20 UTC (rev 211834)
+++ trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm 2017-02-07 21:29:50 UTC (rev 211835)
@@ -43,11 +43,6 @@
namespace WebKit {
-void NetworkProcess::platformLowMemoryHandler(WebCore::Critical)
-{
- CFURLConnectionInvalidateConnectionCache();
-}
-
static void initializeNetworkSettings()
{
static const unsigned preferredConnectionCount = 6;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
