Title: [211861] releases/WebKitGTK/webkit-2.14/Source/WebKit2
Revision
211861
Author
[email protected]
Date
2017-02-08 03:05:33 -0800 (Wed, 08 Feb 2017)

Log Message

Merge r211816 - [Soup] WebKitSoupRequestInputStream can still leave requests unfinished after r211773
https://bugs.webkit.org/show_bug.cgi?id=167929

Reviewed by Michael Catanzaro.

The while loop to process the pending data requests was not a good idea, because having a new pending request
doesn't mean we have more data available, but that more data was requested.

* WebProcess/soup/WebKitSoupRequestInputStream.cpp:
(webkitSoupRequestInputStreamPendingReadAsyncComplete): Process only one request if needed.

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.14/Source/WebKit2/ChangeLog (211860 => 211861)


--- releases/WebKitGTK/webkit-2.14/Source/WebKit2/ChangeLog	2017-02-08 11:05:26 UTC (rev 211860)
+++ releases/WebKitGTK/webkit-2.14/Source/WebKit2/ChangeLog	2017-02-08 11:05:33 UTC (rev 211861)
@@ -1,3 +1,16 @@
+2017-02-07  Carlos Garcia Campos  <[email protected]>
+
+        [Soup] WebKitSoupRequestInputStream can still leave requests unfinished after r211773
+        https://bugs.webkit.org/show_bug.cgi?id=167929
+
+        Reviewed by Michael Catanzaro.
+
+        The while loop to process the pending data requests was not a good idea, because having a new pending request
+        doesn't mean we have more data available, but that more data was requested.
+
+        * WebProcess/soup/WebKitSoupRequestInputStream.cpp:
+        (webkitSoupRequestInputStreamPendingReadAsyncComplete): Process only one request if needed.
+
 2017-02-06  Carlos Garcia Campos  <[email protected]>
 
         [Soup] Long resources loaded by custom protocols sometimes never finish loading

Modified: releases/WebKitGTK/webkit-2.14/Source/WebKit2/WebProcess/soup/WebKitSoupRequestInputStream.cpp (211860 => 211861)


--- releases/WebKitGTK/webkit-2.14/Source/WebKit2/WebProcess/soup/WebKitSoupRequestInputStream.cpp	2017-02-08 11:05:26 UTC (rev 211860)
+++ releases/WebKitGTK/webkit-2.14/Source/WebKit2/WebProcess/soup/WebKitSoupRequestInputStream.cpp	2017-02-08 11:05:33 UTC (rev 211861)
@@ -63,10 +63,8 @@
 
 static void webkitSoupRequestInputStreamPendingReadAsyncComplete(WebKitSoupRequestInputStream* stream)
 {
-    while (stream->priv->pendingAsyncRead) {
-        auto data = ""
+    if (auto data = ""
         webkitSoupRequestInputStreamReadAsyncResultComplete(data->task.get(), data->buffer, data->count);
-    }
 }
 
 static bool webkitSoupRequestInputStreamHasDataToRead(WebKitSoupRequestInputStream* stream)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to