Title: [211872] trunk/LayoutTests
- Revision
- 211872
- Author
- [email protected]
- Date
- 2017-02-08 08:25:43 -0800 (Wed, 08 Feb 2017)
Log Message
[GTK] Test fast/forms/select-empty-option-height.html fails
https://bugs.webkit.org/show_bug.cgi?id=167985
Reviewed by Michael Catanzaro.
This seems to be a problem with the differences in scroll step or the size of the items in the list. The thing
is that 10 attempts with an scroll amount of 10 is not enough in the GTk+ port to scroll the list to the desired
point. Either increasing the scroll amount or the maximum attempts would fix the test. Increasing the scroll
amount would break the test in other ports so better use a higher number of maximum attempts.
* fast/forms/listbox-respects-padding-bottom.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (211871 => 211872)
--- trunk/LayoutTests/ChangeLog 2017-02-08 16:20:19 UTC (rev 211871)
+++ trunk/LayoutTests/ChangeLog 2017-02-08 16:25:43 UTC (rev 211872)
@@ -1,5 +1,19 @@
2017-02-08 Carlos Garcia Campos <[email protected]>
+ [GTK] Test fast/forms/select-empty-option-height.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=167985
+
+ Reviewed by Michael Catanzaro.
+
+ This seems to be a problem with the differences in scroll step or the size of the items in the list. The thing
+ is that 10 attempts with an scroll amount of 10 is not enough in the GTk+ port to scroll the list to the desired
+ point. Either increasing the scroll amount or the maximum attempts would fix the test. Increasing the scroll
+ amount would break the test in other ports so better use a higher number of maximum attempts.
+
+ * fast/forms/listbox-respects-padding-bottom.html:
+
+2017-02-08 Carlos Garcia Campos <[email protected]>
+
Unreviewed GTK+ gardening. Skip animations/font-variations/ tests.
They are marked as ImageOnlyFailure, but are actually failing now. I think it's better to simply skip all font
Modified: trunk/LayoutTests/fast/forms/listbox-respects-padding-bottom.html (211871 => 211872)
--- trunk/LayoutTests/fast/forms/listbox-respects-padding-bottom.html 2017-02-08 16:20:19 UTC (rev 211871)
+++ trunk/LayoutTests/fast/forms/listbox-respects-padding-bottom.html 2017-02-08 16:25:43 UTC (rev 211872)
@@ -6,7 +6,7 @@
window.jsTestIsAsync = true;
var i = 0;
- var maxAttempts = 10;
+ var maxAttempts = 20;
function runTest()
{
var scrollAmount = 0;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
