Log Message
Remove the ability to generate custom lookupGetter/lookupSetter functions, now that they can not be overridden
Reviewed by Adam Roben. * bindings/scripts/CodeGeneratorJS.pm: (GenerateHeader):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (99136 => 99137)
--- trunk/Source/WebCore/ChangeLog 2011-11-03 04:17:54 UTC (rev 99136)
+++ trunk/Source/WebCore/ChangeLog 2011-11-03 04:21:21 UTC (rev 99137)
@@ -1,5 +1,15 @@
2011-11-02 Sam Weinig <[email protected]>
+ Remove the ability to generate custom lookupGetter/lookupSetter functions,
+ now that they can not be overridden
+
+ Reviewed by Adam Roben.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GenerateHeader):
+
+2011-11-02 Sam Weinig <[email protected]>
+
Fix crashing tests after r99126 (commit for https://bugs.webkit.org/show_bug.cgi?id=71307)
Reviewed by Adam Roben.
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (99136 => 99137)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2011-11-03 04:17:54 UTC (rev 99136)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2011-11-03 04:21:21 UTC (rev 99137)
@@ -847,12 +847,6 @@
# Custom defineSetter function
push(@headerContent, " static void defineSetter(JSC::JSObject*, JSC::ExecState*, const JSC::Identifier& propertyName, JSC::JSObject* setterFunction, unsigned attributes);\n") if $dataNode->extendedAttributes->{"CustomDefineSetter"};
- # Custom lookupGetter function
- push(@headerContent, " virtual JSC::JSValue lookupGetter(JSC::ExecState*, const JSC::Identifier& propertyName);\n") if $dataNode->extendedAttributes->{"CustomLookupGetter"};
-
- # Custom lookupSetter function
- push(@headerContent, " virtual JSC::JSValue lookupSetter(JSC::ExecState*, const JSC::Identifier& propertyName);\n") if $dataNode->extendedAttributes->{"CustomLookupSetter"};
-
# Override toBoolean to return false for objects that want to 'MasqueradesAsUndefined'.
if ($dataNode->extendedAttributes->{"MasqueradesAsUndefined"}) {
push(@headerContent, " virtual bool toBoolean(JSC::ExecState*) const { return false; };\n");
_______________________________________________ webkit-changes mailing list [email protected] http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
