Title: [212400] trunk/Source/WebInspectorUI
- Revision
- 212400
- Author
- [email protected]
- Date
- 2017-02-15 14:48:35 -0800 (Wed, 15 Feb 2017)
Log Message
Web Inspector: Split console should be allowed when docked bottom on Elements/Resources/Debugger/Storage tabs
https://bugs.webkit.org/show_bug.cgi?id=168385
Patch by Devin Rousso <[email protected]> on 2017-02-15
Reviewed by Timothy Hatcher.
* UserInterface/Base/Main.js:
(WebInspector.updateDockedState):
If the new docked configuration does not support the split console, hide it.
* UserInterface/Views/DebuggerTabContentView.js:
(WebInspector.DebuggerTabContentView.prototype.get supportsSplitContentBrowser):
* UserInterface/Views/ElementsTabContentView.js:
(WebInspector.ElementsTabContentView.prototype.get supportsSplitContentBrowser):
* UserInterface/Views/ResourcesTabContentView.js:
(WebInspector.ResourcesTabContentView.prototype.get supportsSplitContentBrowser):
* UserInterface/Views/StorageTabContentView.js:
(WebInspector.StorageTabContentView.prototype.get supportsSplitContentBrowser):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (212399 => 212400)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-02-15 22:44:25 UTC (rev 212399)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-02-15 22:48:35 UTC (rev 212400)
@@ -1,3 +1,23 @@
+2017-02-15 Devin Rousso <[email protected]>
+
+ Web Inspector: Split console should be allowed when docked bottom on Elements/Resources/Debugger/Storage tabs
+ https://bugs.webkit.org/show_bug.cgi?id=168385
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Base/Main.js:
+ (WebInspector.updateDockedState):
+ If the new docked configuration does not support the split console, hide it.
+
+ * UserInterface/Views/DebuggerTabContentView.js:
+ (WebInspector.DebuggerTabContentView.prototype.get supportsSplitContentBrowser):
+ * UserInterface/Views/ElementsTabContentView.js:
+ (WebInspector.ElementsTabContentView.prototype.get supportsSplitContentBrowser):
+ * UserInterface/Views/ResourcesTabContentView.js:
+ (WebInspector.ResourcesTabContentView.prototype.get supportsSplitContentBrowser):
+ * UserInterface/Views/StorageTabContentView.js:
+ (WebInspector.StorageTabContentView.prototype.get supportsSplitContentBrowser):
+
2017-02-14 Brian Burg <[email protected]>
Web Inspector: RTL: adjust padding of dashboard icons
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (212399 => 212400)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2017-02-15 22:44:25 UTC (rev 212399)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2017-02-15 22:48:35 UTC (rev 212400)
@@ -766,7 +766,7 @@
this._updateDockNavigationItems();
- if (!this.dockedConfigurationSupportsSplitContentBrowser() && this.isShowingSplitConsole())
+ if (!this.dockedConfigurationSupportsSplitContentBrowser() && !this.doesCurrentTabSupportSplitContentBrowser())
this.hideSplitConsole();
};
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerTabContentView.js (212399 => 212400)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerTabContentView.js 2017-02-15 22:44:25 UTC (rev 212399)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerTabContentView.js 2017-02-15 22:48:35 UTC (rev 212400)
@@ -49,6 +49,11 @@
return WebInspector.DebuggerTabContentView.Type;
}
+ get supportsSplitContentBrowser()
+ {
+ return true;
+ }
+
canShowRepresentedObject(representedObject)
{
if (representedObject instanceof WebInspector.Script)
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js (212399 => 212400)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js 2017-02-15 22:44:25 UTC (rev 212399)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js 2017-02-15 22:48:35 UTC (rev 212400)
@@ -60,6 +60,11 @@
return WebInspector.ElementsTabContentView.Type;
}
+ get supportsSplitContentBrowser()
+ {
+ return true;
+ }
+
canShowRepresentedObject(representedObject)
{
return representedObject instanceof WebInspector.DOMTree;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourcesTabContentView.js (212399 => 212400)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourcesTabContentView.js 2017-02-15 22:44:25 UTC (rev 212399)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourcesTabContentView.js 2017-02-15 22:48:35 UTC (rev 212400)
@@ -54,6 +54,11 @@
return WebInspector.ResourcesTabContentView.Type;
}
+ get supportsSplitContentBrowser()
+ {
+ return true;
+ }
+
canShowRepresentedObject(representedObject)
{
return representedObject instanceof WebInspector.Frame
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/StorageTabContentView.js (212399 => 212400)
--- trunk/Source/WebInspectorUI/UserInterface/Views/StorageTabContentView.js 2017-02-15 22:44:25 UTC (rev 212399)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/StorageTabContentView.js 2017-02-15 22:48:35 UTC (rev 212400)
@@ -54,6 +54,11 @@
return WebInspector.StorageTabContentView.Type;
}
+ get supportsSplitContentBrowser()
+ {
+ return true;
+ }
+
canShowRepresentedObject(representedObject)
{
return representedObject instanceof WebInspector.DOMStorageObject || representedObject instanceof WebInspector.CookieStorageObject ||
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
